Commit 48f8754
fix(scip): ruby encoding fallback + surface swallowed nightly failures
- ruby was missing from effective_encoding's spec-convention fallback
table added by D4 (7672f52): every scip-ruby occurrence had no byte
span, so ingest_occurrences_with_proof_context's
identity_version >= 2 gate never matched a row and
ruby_overlay_upgrades_ambiguous_case_when_calls_on_the_multi_lang_fixture
failed 6 nightly runs straight (2026-08-01 through 08-07). Verified
against scip-ruby's real source (SCIPIndexer.cc sets
text_document_encoding=UTF8 but never calls set_position_encoding
anywhere in the repo) and end-to-end against the real pinned
scip-ruby-v0.4.7 binary -- the ignored test now passes for real, not
just at the unit level.
- cargo test's lib harness never installed a tracing subscriber, so
run_overlay_for_with_catalog's tracing::warn! on a real indexer
subprocess failure -- already carrying a real stderr tail from
runner.rs's run_indexer -- was a complete no-op. Nightly
python/js/etc. failures showed only the generic "expected at least
one edge upgraded to formal" with zero diagnostic value, which is
why the python/js regression (unrelated to the ruby one, still
under investigation) went unnoticed for weeks. Added
init_test_tracing() (with_test_writer, so output only surfaces on a
failing test like println! does) to all 11 real-indexer nightly
tests plus the calm-cli CLI-level mirror test. Verified by forcing a
real 1ms timeout locally: the real subprocess-failure reason now
prints even without --nocapture, matching exactly how the nightly
workflow invokes cargo test.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>1 parent 0ab9bca commit 48f8754
5 files changed
Lines changed: 123 additions & 22 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
68 | 68 | | |
69 | 69 | | |
70 | 70 | | |
71 | | - | |
| 71 | + | |
| 72 | + | |
72 | 73 | | |
73 | | - | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
74 | 78 | | |
75 | 79 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
104 | 104 | | |
105 | 105 | | |
106 | 106 | | |
| 107 | + | |
| 108 | + | |
| 109 | + | |
| 110 | + | |
| 111 | + | |
| 112 | + | |
| 113 | + | |
| 114 | + | |
107 | 115 | | |
108 | 116 | | |
109 | 117 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
979 | 979 | | |
980 | 980 | | |
981 | 981 | | |
| 982 | + | |
| 983 | + | |
| 984 | + | |
| 985 | + | |
| 986 | + | |
| 987 | + | |
| 988 | + | |
| 989 | + | |
| 990 | + | |
| 991 | + | |
| 992 | + | |
| 993 | + | |
| 994 | + | |
| 995 | + | |
| 996 | + | |
| 997 | + | |
| 998 | + | |
| 999 | + | |
| 1000 | + | |
| 1001 | + | |
| 1002 | + | |
| 1003 | + | |
| 1004 | + | |
| 1005 | + | |
| 1006 | + | |
| 1007 | + | |
982 | 1008 | | |
983 | 1009 | | |
984 | 1010 | | |
| |||
1365 | 1391 | | |
1366 | 1392 | | |
1367 | 1393 | | |
| 1394 | + | |
1368 | 1395 | | |
1369 | 1396 | | |
1370 | 1397 | | |
| |||
1409 | 1436 | | |
1410 | 1437 | | |
1411 | 1438 | | |
| 1439 | + | |
1412 | 1440 | | |
1413 | 1441 | | |
1414 | 1442 | | |
| |||
1557 | 1585 | | |
1558 | 1586 | | |
1559 | 1587 | | |
| 1588 | + | |
1560 | 1589 | | |
1561 | 1590 | | |
1562 | 1591 | | |
| |||
1606 | 1635 | | |
1607 | 1636 | | |
1608 | 1637 | | |
| 1638 | + | |
1609 | 1639 | | |
1610 | 1640 | | |
1611 | 1641 | | |
| |||
1647 | 1677 | | |
1648 | 1678 | | |
1649 | 1679 | | |
| 1680 | + | |
1650 | 1681 | | |
1651 | 1682 | | |
1652 | 1683 | | |
| |||
1692 | 1723 | | |
1693 | 1724 | | |
1694 | 1725 | | |
| 1726 | + | |
1695 | 1727 | | |
1696 | 1728 | | |
1697 | 1729 | | |
| |||
1753 | 1785 | | |
1754 | 1786 | | |
1755 | 1787 | | |
| 1788 | + | |
1756 | 1789 | | |
1757 | 1790 | | |
1758 | 1791 | | |
| |||
1876 | 1909 | | |
1877 | 1910 | | |
1878 | 1911 | | |
| 1912 | + | |
1879 | 1913 | | |
1880 | 1914 | | |
1881 | 1915 | | |
| |||
1979 | 2013 | | |
1980 | 2014 | | |
1981 | 2015 | | |
| 2016 | + | |
1982 | 2017 | | |
1983 | 2018 | | |
1984 | 2019 | | |
| |||
2047 | 2082 | | |
2048 | 2083 | | |
2049 | 2084 | | |
| 2085 | + | |
2050 | 2086 | | |
2051 | 2087 | | |
2052 | 2088 | | |
| |||
2132 | 2168 | | |
2133 | 2169 | | |
2134 | 2170 | | |
| 2171 | + | |
2135 | 2172 | | |
2136 | 2173 | | |
2137 | 2174 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
11 | 11 | | |
12 | 12 | | |
13 | 13 | | |
14 | | - | |
15 | | - | |
16 | | - | |
17 | | - | |
18 | | - | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
19 | 20 | | |
20 | 21 | | |
21 | 22 | | |
22 | 23 | | |
23 | 24 | | |
24 | 25 | | |
25 | | - | |
26 | | - | |
27 | | - | |
28 | | - | |
29 | | - | |
30 | | - | |
31 | | - | |
32 | | - | |
33 | | - | |
34 | | - | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
35 | 59 | | |
36 | 60 | | |
37 | 61 | | |
| |||
45 | 69 | | |
46 | 70 | | |
47 | 71 | | |
| 72 | + | |
48 | 73 | | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
49 | 77 | | |
50 | 78 | | |
51 | 79 | | |
| |||
469 | 497 | | |
470 | 498 | | |
471 | 499 | | |
| 500 | + | |
| 501 | + | |
| 502 | + | |
| 503 | + | |
| 504 | + | |
| 505 | + | |
| 506 | + | |
| 507 | + | |
| 508 | + | |
| 509 | + | |
| 510 | + | |
| 511 | + | |
| 512 | + | |
| 513 | + | |
| 514 | + | |
| 515 | + | |
| 516 | + | |
| 517 | + | |
| 518 | + | |
| 519 | + | |
| 520 | + | |
472 | 521 | | |
473 | 522 | | |
474 | 523 | | |
475 | | - | |
476 | | - | |
477 | | - | |
478 | | - | |
479 | | - | |
| 524 | + | |
| 525 | + | |
| 526 | + | |
| 527 | + | |
| 528 | + | |
| 529 | + | |
| 530 | + | |
480 | 531 | | |
481 | 532 | | |
482 | 533 | | |
| |||
0 commit comments