changed all rand to random_int in Game files, add type of return in game functions

Author: Eksi-tech

src/Games/Calc.php

@@ -1,22 +1,24 @@
 <?php
 
-function getRules()
+function getRules(): string
 {
     return 'What is the result of the expression?';
 }
 
-function generateQuestion()
+function generateQuestion(): string
 {
-    $firstOperand = rand(1, 20);
-    $secondOperand = rand(1, 20);
+    $firstOperand = random_int(1, 20);
+    $secondOperand = random_int(1, 20);
     $actions = ["+", "-", "*"];
-    $operation = $actions[rand(0, 2)];
+    $operation = $actions[random_int(0, 2)];
     return "$firstOperand $operation $secondOperand";
 }
 
-function getCorrectAnswer($question)
+function getCorrectAnswer($question): int
 {
     list($firstOperand, $operation, $secondOperand) = explode(" ", $question);
+    $firstOperand = (int)$firstOperand;
+    $secondOperand = (int)$secondOperand;
     switch ($operation) {
         case "+":
             return $firstOperand + $secondOperand;

src/Games/Even.php

@@ -1,16 +1,16 @@
 <?php
 
-function getRules()
+function getRules(): string
 {
     return 'Answer "yes" if the number is even, otherwise answer "no".';
 }
 
-function generateQuestion()
+function generateQuestion(): int
 {
-    return rand(1, 20);
+    return random_int(1, 20);
 }
 
-function getCorrectAnswer($question)
+function getCorrectAnswer($question): string
 {
     return $question % 2 ? 'no' : 'yes';
 }

src/Games/Gcd.php

@@ -1,26 +1,24 @@
 <?php
 
-function getRules()
+function getRules(): string
 {
     return 'Find the greatest common divisor of given numbers.';
 }
 
-function generateQuestion()
+function generateQuestion(): string
 {
     if (rand(1, 3) === 1) {
-        // 33% случаев - гарантированный нетривиальный НОД
-        $base = rand(2, 25);
-        $firstNumber = $base * rand(2, 10);
-        $secondNumber = $base * rand(2, 10);
+        $base = random_int(2, 25);
+        $firstNumber = $base * random_int(2, 10);
+        $secondNumber = $base * random_int(2, 10);
     } else {
-        // 67% случаев - полностью случайные
-        $firstNumber = rand(1, 100);
-        $secondNumber = rand(1, 100);
+        $firstNumber = random_int(1, 100);
+        $secondNumber = random_int(1, 100);
     }
     return "$firstNumber $secondNumber";
 }
 
-function getCorrectAnswer($question)
+function getCorrectAnswer($question): int
 {
     list($secondNumber, $firstNumber ) = explode(" ", $question);