Extract static source fields into their own dedicated provider

The product/category slug fields aren't tied to attributes or options,
they don't belong in ProductAttributeSourceFieldProvider either.

Author: PierreGauthier

src/Indexer/Provider/ProductAttributeSourceFieldProvider.php

@@ -19,7 +19,7 @@
 use Sylius\Component\Resource\Repository\RepositoryInterface;
 
 /**
- * Gally source field provider for Sylius product attributes, plus the plugin's static fields.
+ * Gally source field provider for Sylius product attributes.
  */
 class ProductAttributeSourceFieldProvider extends AbstractSourceFieldProvider
 {
@@ -39,16 +39,5 @@ public function provide(): iterable
         foreach ($this->productAttributeRepository->findAll() as $productAttribute) {
             yield $this->buildSourceField('product', $productAttribute);
         }
-
-        // Static fields are not tied to attributes or options, kept here to avoid a third provider.
-        $staticSourceField = [
-            'product' => ['slug' => 'text'],
-            'category' => ['slug' => 'text'],
-        ];
-        foreach ($staticSourceField as $entity => $fields) {
-            foreach ($fields as $code => $type) {
-                yield new SourceField($this->getMetadata($entity), $code, $this->getGallyType($type), $code, []);
-            }
-        }
     }
 }

src/Indexer/Provider/StaticSourceFieldProvider.php

@@ -0,0 +1,47 @@
+<?php
+/**
+ * DISCLAIMER
+ *
+ * Do not edit or add to this file if you wish to upgrade Gally to newer versions in the future.
+ *
+ * @package   Gally
+ * @author    Stephan Hochdörfer <S.Hochdoerfer@bitexpert.de>, Gally Team <elasticsuite@smile.fr>
+ * @copyright 2022-present Smile
+ * @license   Open Software License v. 3.0 (OSL-3.0)
+ */
+
+declare(strict_types=1);
+
+namespace Gally\SyliusPlugin\Indexer\Provider;
+
+use Gally\Sdk\Entity\Metadata;
+use Gally\Sdk\Entity\SourceField;
+
+/**
+ * Gally source field provider for the plugin's built-in fields, not tied to any Sylius attribute or option.
+ */
+class StaticSourceFieldProvider implements ProviderInterface
+{
+    public function getEntity(): string
+    {
+        return 'sourceField';
+    }
+
+    /**
+     * @return iterable<SourceField>
+     */
+    public function provide(): iterable
+    {
+        $staticSourceField = [
+            'product' => ['slug' => 'text'],
+            'category' => ['slug' => 'text'],
+        ];
+
+        foreach ($staticSourceField as $entity => $fields) {
+            $metadata = new Metadata($entity);
+            foreach ($fields as $code => $type) {
+                yield new SourceField($metadata, $code, $type, $code, []);
+            }
+        }
+    }
+}

src/Resources/config/services/indexers.xml

@@ -9,6 +9,9 @@
             <argument type="service" id="sylius.context.locale" />
             <tag name="gally.dataprovider" entity="catalog"/>
         </service>
+        <service id="Gally\SyliusPlugin\Indexer\Provider\StaticSourceFieldProvider">
+            <tag name="gally.dataprovider" entity="sourceField"/>
+        </service>
         <service id="Gally\SyliusPlugin\Indexer\Provider\ProductAttributeSourceFieldProvider">
             <argument type="service" id="Gally\SyliusPlugin\Indexer\Provider\CatalogProvider"/>
             <argument type="service" id="sylius.repository.product_attribute" />