[Filter] Fix numeric facet option labels replaced by their index

Author: PierreGauthier

src/Resources/views/shop/form/checkbox.html.twig

@@ -1,9 +1,12 @@
 {% block sylius_gally_filter_checkbox_row -%}
     <div class="{% if required %}required {% endif %}field{% if (not compound or force_error|default(false)) and not valid %} error{% endif %}">
         {{- form_label(form) -}}
-        {% set choices = {} %}
+        {% set choices = [] %}
         {% for choice in form.vars.choices %}
-            {% set choices = choices|merge({(choice.label): choice.value}) %}
+            {# merge() renumbers integer-like keys (PHP array_merge behavior), so labels that
+               look like numbers (e.g. "12") must not be used as array keys: kept as a list of
+               {label, value} pairs instead. #}
+            {% set choices = choices|merge([{label: choice.label, value: choice.value}]) %}
         {% endfor %}
         {{ component('gally_shop:filter:facet_options', {
             filterField: form.vars.name,

src/Resources/views/shop/product/_shared/facet_options.html.twig

@@ -12,14 +12,14 @@
         </div>
     {% endif %}
     <div class="ui">
-        {% for label, value in choices %}
+        {% for choice in choices %}
             <div class="form-check">
                 <input type="checkbox" class="form-check-input"
                     id="{{ baseId }}_{{ loop.index0 }}"
                     name="{{ fieldName }}[]"
-                    value="{{ value }}"
-                    {% if value in selectedValues %}checked{% endif %}>
-                <label class="form-check-label" for="{{ baseId }}_{{ loop.index0 }}">{{ label }}</label>
+                    value="{{ choice.value }}"
+                    {% if choice.value in selectedValues %}checked{% endif %}>
+                <label class="form-check-label" for="{{ baseId }}_{{ loop.index0 }}">{{ choice.label }}</label>
             </div>
         {% endfor %}
     </div>

src/Twig/Component/Filter/FacetOptionsComponent.php

@@ -48,7 +48,7 @@ class FacetOptionsComponent
     #[LiveProp]
     public string $baseId = '';
 
-    /** @var array<string, string> */
+    /** @var list<array{label: string, value: string}> */
     #[LiveProp]
     public array $initialChoices = [];
 
@@ -97,7 +97,7 @@ public function viewMore(): void
     }
 
     /**
-     * @return array<string, string>
+     * @return list<array{label: string, value: string}>
      */
     #[ExposeInTemplate('choices')]
     public function getChoices(): array
@@ -116,7 +116,7 @@ public function getChoices(): array
         /** @var array<string, string> $option */
         foreach ($aggregationOptions as $option) {
             if (isset($option['label'])) {
-                $choices[$option['label']] = $option['value'] ?? '';
+                $choices[] = ['label' => $option['label'], 'value' => $option['value'] ?? ''];
             }
         }