Feat improve facet - #49
Open
PierreGauthier wants to merge 7 commits into
Open
Conversation
PierreGauthier
commented
Jul 13, 2026
PierreGauthier
commented
Contributor
| Q | A |
|---|---|
| Branch? | master for features / current stable version branch for bug fixes |
| Tickets | #... |
| License | OSL-3.0 |
There was a problem hiding this comment.
Pull request overview
This PR enhances the shop facet/filter UX by adding “active filter” chips (with per-filter removal + clear-all), improving facet option interactions (autosubmit, option search, view-more), and refining category facet handling across taxon vs non-taxon pages.
Changes:
- Add an
ActiveFilterResolver+ Twig component/templates to render active filter chips and a clear-all link. - Replace the old “view more” JS with a consolidated
filters.jsthat handles autosubmit, view-more, and debounced facet option search. - Improve category facet behavior (taxonomy navigation on taxon pages, hidden persistence of selected category, indexing ancestors for category visibility).
Reviewed changes
Copilot reviewed 24 out of 25 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| src/Twig/Component/Product/ActiveFiltersComponent.php | New Twig component exposing active filters + clear-all URL. |
| src/Search/Aggregation/ActiveFilter.php | New value object representing an active filter “chip”. |
| src/Search/ActiveFilterResolver.php | New resolver building active filters and removal/clear URLs from request criteria. |
| src/Resources/views/shop/shared/components/header/search/autocomplete/results.html.twig | Adjusts conditional rendering for separator based on products presence. |
| src/Resources/views/shop/product/search/content/body/sidebar/filters.html.twig | Removes manual search/clear buttons from sidebar filter form. |
| src/Resources/views/shop/product/index/content/body/sidebar/filters.html.twig | Removes manual search/clear buttons from sidebar filter form. |
| src/Resources/views/shop/product/_shared/categories.html.twig | New taxonomy categories block (children + go-up) for taxon browsing. |
| src/Resources/views/shop/product/_shared/active_filters.html.twig | New active filter chips + clear-all rendering. |
| src/Resources/views/shop/grid/filter/gally_dynamic_filter.html.twig | Renders filters title, active filters component, and full filter form widget. |
| src/Resources/views/shop/form/checkbox.html.twig | Adds facet option search UI + category-specific blocks. |
| src/Resources/views/shop/events_javascript.html.twig | Switches included script from view-more.js to filters.js. |
| src/Resources/translations/messages.en.yaml | Adds translations for facet search and active filter actions. |
| src/Resources/public/view-more.js | Removes old standalone “view more” implementation. |
| src/Resources/public/range-slider.js | Improves slider behavior (multi-instance support, user-interaction guard, debounced change). |
| src/Resources/public/filters.js | New unified filters script (autosubmit, view-more, facet option search). |
| src/Resources/public/filters.css | Adds styling for new filter UI elements (title, chips, category links, facet search). |
| src/Resources/config/services/twig/component/product.xml | Registers the new active filters Twig component service. |
| src/Resources/config/services/search.xml | Registers ActiveFilterResolver service + event listener + reset hook. |
| src/Resources/config/app/twig_hooks_shop.yml | Disables default taxonomy hook on product index sidebar. |
| src/Indexer/ProductIndexer.php | Indexes taxon ancestors so products appear in parent categories. |
| src/Indexer/CategoryIndexer.php | Uses null for root parentId instead of empty string. |
| src/Grid/Filter/Type/SelectFilterType.php | Replaces has_more_url with has_more + search_url view vars. |
| src/Form/Type/Filter/GallyDynamicFilterType.php | Adds category facet logic, persistence for selected category, and builds facet search/view-more URLs. |
| src/Controller/Shop/FilterController.php | Adds optionSearch support and passes it to the SDK view-more call. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
PierreGauthier
force-pushed
the
feat-improveFacet
branch
2 times, most recently
from
July 13, 2026 13:18
7a62c91 to
74f20e8
Compare
PierreGauthier
force-pushed
the
feat-improveFacet
branch
from
July 15, 2026 10:09
74f20e8 to
433cc0e
Compare
PierreGauthier
force-pushed
the
feat-improveFacet
branch
from
July 27, 2026 09:21
d876fcf to
60c2767
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.