Skip to content

Commit 94540b3

Browse files
refactor(parametricbuilder): update error and info messages in iterate_problems
1 parent dcb6d02 commit 94540b3

1 file changed

Lines changed: 2 additions & 47 deletions

File tree

src/parametricbuilder/systembuilderspec.jl

Lines changed: 2 additions & 47 deletions
Original file line numberDiff line numberDiff line change
@@ -107,51 +107,6 @@ _expand_earth(e::EarthSpec) = (
107107
# Overlaps are *not* emitted (skipped with warning by catching the geometry error).
108108
# Designs are identical per system realization (no cross-mixing).
109109
# ─────────────────────────────────────────────────────────────────────────────
110-
# function iterate_problems(spec::SystemBuilderSpec)
111-
# return Channel{LineParametersProblem}(32) do ch
112-
# for des in spec.builder
113-
# for L in _expand_pair(spec.length)
114-
# pos_spaces = map(_expand_position, spec.positions)
115-
# for choice in product(pos_spaces...)
116-
# try
117-
# # first cable via DataModel.CablePosition; rest via add!
118-
# x1, y1, c1 = choice[1]
119-
# sys = DataModel.LineCableSystem(
120-
# spec.system_id,
121-
# L,
122-
# DataModel.CablePosition(des, x1, y1, c1),
123-
# )
124-
# for k in Iterators.drop(eachindex(choice), 1)
125-
# xk, yk, ck = choice[k]
126-
# sys = add!(sys, des, xk, yk, ck)
127-
# end
128-
129-
# for T in _expand_pair(spec.temperature)
130-
# for (ρ, ε, μ, t) in _expand_earth(spec.earth)
131-
# em = EarthModel(spec.frequencies, ρ, ε, μ; t = t)
132-
# prob = LineParametersProblem(sys;
133-
# temperature = T, earth_props = em,
134-
# frequencies = spec.frequencies)
135-
# put!(ch, prob)
136-
# end
137-
# end
138-
# catch e
139-
# # Do not generate overlapping systems.
140-
# # If the underlying add!/ctor throws an overlap/geometry error, skip.
141-
# if occursin("overlap", sprint(showerror, e))
142-
# @warn sprint(showerror, e)
143-
# @warn "Skipping..."
144-
# continue
145-
# else
146-
# rethrow()
147-
# end
148-
# end
149-
# end
150-
# end
151-
# end
152-
# end
153-
# end
154-
155110
function iterate_problems(spec::SystemBuilderSpec)
156111
return Channel{LineParametersProblem}(32) do ch
157112
produced = 0
@@ -191,9 +146,9 @@ function iterate_problems(spec::SystemBuilderSpec)
191146
end
192147
end
193148
catch e
194-
@error "iterate_problems failed" exception=(e, catch_backtrace())
149+
@error "iterate SystemBuilderSpec failed" exception=(e, catch_backtrace())
195150
finally
196-
@info "iterate_problems finished" produced=produced upper_bound=cardinality(
151+
@info "iterate SystemBuilderSpec finished" produced=produced upper_bound=cardinality(
197152
spec,
198153
)
199154
end

0 commit comments

Comments
 (0)