Refactor FEMWorkspace to manage physical groups and update cable geometry functions to register physical groups

Author: amaurigmartins

src/FEMTools.jl

@@ -431,8 +431,8 @@ mutable struct FEMWorkspace
     unassigned_entities::Dict{Vector{Float64},AbstractEntityData}
     "Container for all material names used in the model."
     material_registry::Dict{String,Int}
-    "ONELAB parameters."
-    onelab_params::Dict{String,Any}
+    "Container for unique physical groups."
+    physical_groups::Dict{Int,Material}
     "Results storage."
     results::Dict{String,Any}
 
@@ -474,7 +474,7 @@ mutable struct FEMWorkspace
             Vector{FEMEntity{<:AbstractEntityData}}(), #boundaries
             Dict{Vector{Float64},AbstractEntityData}(), #unassigned_entities
             Dict{String,Int}(),  # Initialize empty material registry
-            Dict{String,Any}(),
+            Dict{Int,Material}(), # Maps physical group tags to materials
             Dict{String,Any}()
         )
 
@@ -511,9 +511,13 @@ workspace = $(FUNCTIONNAME)(cable_system, problem_def, solver)
 function run_fem_model(cable_system::LineCableSystem,
     problem_def::FEMProblemDefinition,
     solver::FEMSolver;
-    frequency::Float64=50.0)
+    frequency::Float64=50.0, workspace::Union{FEMWorkspace,Nothing}=nothing)
+
     # Create and initialize workspace
-    workspace = FEMWorkspace(cable_system, problem_def, solver, frequency=frequency)
+    if isnothing(workspace) || !isa(workspace, FEMWorkspace)
+        workspace = FEMWorkspace(cable_system, problem_def, solver, frequency=frequency)
+    end
+    # workspace = FEMWorkspace(cable_system, problem_def, solver, frequency=frequency)
 
     # Log start
     _log(workspace, 1, "Starting FEM simulation for cable system: $(cable_system.case_id)")

src/FEMTools/cable.jl

@@ -187,6 +187,9 @@ function _make_cablepart!(workspace::FEMWorkspace, part::AbstractCablePart,
     # Add to workspace in the unassigned container for subsequent processing
     workspace.unassigned_entities[marker] = entity_data
 
+    # Add physical groups to the workspace
+    register_physical_group!(workspace, physical_group_tag, part.material_props)
+
 end
 
 """
@@ -320,6 +323,8 @@ function _make_cablepart!(workspace::FEMWorkspace, part::WireArray,
         # Add to workspace
         workspace.unassigned_entities[marker] = entity_data
     end
+    # Add physical groups to the workspace
+    register_physical_group!(workspace, physical_group_tag, part.material_props)
 
     # Handle WireArray outermost boundary
     mesh_size = (radius_ext - radius_in)
@@ -376,4 +381,7 @@ function _make_cablepart!(workspace::FEMWorkspace, part::WireArray,
         workspace.unassigned_entities[marker] = entity_data
     end
 
+    # Add physical groups to the workspace
+    register_physical_group!(workspace, physical_group_tag_air_gap, air_material)
+
 end

src/FEMTools/encoding.jl

@@ -281,7 +281,23 @@ function get_or_register_material_id(workspace::FEMWorkspace, material::Material
     return material_id
 end
 
+function register_physical_group!(workspace::FEMWorkspace, physical_group_tag::Int, material::Material)
 
+    # Create physical_groups if it doesn't exist
+    if !isdefined(workspace, :physical_groups)
+        workspace.physical_groups = Dict{Int,Material}()
+    end
+
+    # # Get material name using existing function that checks library first
+    # material_name = get_material_name(material, workspace.problem_def.materials_db)
+
+    # Find or create the ID
+    if !haskey(workspace.physical_groups, physical_group_tag)
+        # New material - assign next available ID
+        workspace.physical_groups[physical_group_tag] = material
+    end
+
+end
 """
 $(TYPEDSIGNATURES)
 

src/FEMTools/space.jl

@@ -159,6 +159,12 @@ function _make_space_geometry(workspace::FEMWorkspace)
     workspace.unassigned_entities[earth_boundary_marker] = earth_boundary_entity
     workspace.unassigned_entities[earth_infty_marker] = earth_infty_entity
 
+    # Add physical groups to the workspace
+    register_physical_group!(workspace, air_region_tag, air_material)
+    register_physical_group!(workspace, earth_region_tag, earth_material)
+    register_physical_group!(workspace, air_infshell_tag, air_material)
+    register_physical_group!(workspace, earth_infshell_tag, earth_material)
+
     # Create domain surfaces
     air_region_entity = SurfaceEntity(
         CoreEntityData(air_region_tag, air_region_name, mesh_size_default),