CompatHelper: bump compat for XLSX to 0.11, (keep existing compat)#36
Closed
github-actions[bot] wants to merge 1145 commits into
Closed
CompatHelper: bump compat for XLSX to 0.11, (keep existing compat)#36github-actions[bot] wants to merge 1145 commits into
github-actions[bot] wants to merge 1145 commits into
Conversation
…ld_designs for trace output
…s, update internal conversions
…rSpec, and related logic to separate files
…d systembuilderspec modules
…tting in SystemBuilderSpec
…insulation kernel
…arameters constructor
…es and include xlsx module
…nd conductor definitions
…e.error for type mismatch
Bumps [actions/checkout](https://github.com/actions/checkout) from 5 to 6. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v5...v6) --- updated-dependencies: - dependency-name: actions/checkout dependency-version: '6' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* feat(sector): add Sector and SectorInsulator types with geometric properties * fix(sector): fix typo insulator group inclusion to SectorInsulator * feat(sector): add GeometryBasics and PolygonOps dependencies with version updates * feat(sector): add LinearAlgebra import * feat(sectorinsulator): update _calculate_offset_polygon to use vertices and improve offset calculation * feat(setor): update preview of insulator to be transparent (to be handled later) * feat(sector): update preview function to handle Sector layers with TODOs for nominal length and offset adjustments * feat(sector): adjust vertex calculations for Sector and SectorInsulator layers to take the offset into account * feat(sector-FEM): add functions to draw polygons (from points) and polygons with holes in Gmsh * feat(sector-FEM): add specialized `_make_cablepart!` methods for creating Sector and SectorInsulator geometries * feat(sector-FEM): add GeometryBasics dependency for geometric operations (using Point) * feat(sector-FEM): update vertex translation to use GeometryBasics.Point for Sector and SectorInsulator * feat(sector-FEM): enhance draw_polygon to calculate centroid for Point vertices manually * fix(helper): use Base.error for GetDP executable error handling * feat(sector-FEM): update logging in draw_polygon function for clarity * feat(sector-FEM): add draw_polygon function with max edge length parameter * feat(sector-FEM): enhance draw_polygon_with_hole to support max edge length parameter TODO: it is using thickness to divide! * feat(sector-FEM): refactor _densify_vertices for better meshing of sector shaped conductor and insulator * chore(ci): remove main branch trigger from CI workflow to make it test on my feature branch too * chore(ci): add gh-pages to branches-ignore in CI workflow but make it run CI on anything else * refactor(fem): add GeometryBasics dependency for enhanced geometric operations - needed for sector shaped cable * feat(sector): add insulation thickness and enhance geometry calculations with debug logging * feat(sector): implement Shoelace formula for area calculations and ensure polygon closure in sector geometry * refactor(sector): correct debug logging for cross-sectional area calculation and increase arc points for improved accuracy * refactor(sector): remove GeometryBasics dependency and use Makie for point definitions * feat(sector): add support for rendering Sector and SectorInsulator layers with Makie * feat(sector): add comprehensive tutorial for sector-shaped cable design along with tests for CI * tutorial(sector): added save capability * feat(sector): add centroid calculation for sector shape * fix(sector-geometry): improve centroid calculation * feat(sector-cableslibrary): enhance handling for Sector and SectorInsulator layer types * feat(Sector): export Sector and SectorInsulator in the data model * fix(Sector): fix export of Sector Shape functions * fix(Sector): correct include statement for SectorInsulator file * feat(SectorParams): basic validation and constructor parameters for SectorParams struct. just testing validation. * feat(SectorParams): ADDED Validation for sector geometry. I followed the rules so the sectors play nice with other cable parts, In hope of being accepted into the main branch. * fix(fem/cable): correct botched merge conflict * fix(sectorinsulator): fix missing export * fix(fix): fix * fix(fix): now vibe fixing * fixfixfixfixfixfix --------- Co-authored-by: Amauri Martins <amauri.martinsbritto@kuleuven.be> Co-authored-by: Amauri Martins <amaurigmartins@gmail.com>
amaurigmartins
force-pushed
the
compathelper/new_version/2026-03-24-00-16-37-925-00136373867
branch
from
343df69 to
3e18378
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #36 +/- ##
==========================================
- Coverage 51.24% 42.33% -8.92%
==========================================
Files 95 137 +42
Lines 6966 10265 +3299
==========================================
+ Hits 3570 4346 +776
- Misses 3396 5919 +2523 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
amaurigmartins
deleted the
compathelper/new_version/2026-03-24-00-16-37-925-00136373867
branch
amaurigmartins
restored the
compathelper/new_version/2026-03-24-00-16-37-925-00136373867
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request changes the compat entry for the
XLSXpackage from0.10.4to0.10.4, 0.11.This keeps the compat entries for earlier versions.
Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.