Refactor and clean up code across multiple modules

- Removed unused function declarations and variables in http_server, bt_gatts, bt_spam, buzzer, id_open, id_open_esp32, odrone_id, spoofer, flash_fs, ieee_sniffer, ledc_controller, nmea_parser, sd_card, thread_broadcast, uart_sender, zigbee_light, and various command modules.
- Updated logging macros to use consistent naming conventions in bt_gatts.
- Fixed type casting issues for string parameters in various modules to ensure proper handling of character pointers.
- Improved memory management by ensuring proper allocation and deallocation of dynamic memory in menus_module and gps modules.
- Enhanced readability by adding const qualifiers where appropriate and removing redundant code.
- Adjusted function signatures to include unused attribute where necessary to suppress compiler warnings.

Author: Darcko123

firmware/components/OTA/modules/http_server/http_server.c

@@ -63,7 +63,6 @@ static esp_err_t http_server_app_js_handler(httpd_req_t* req);
 static esp_err_t http_server_favicon_handler(httpd_req_t* req);
 static esp_err_t http_server_ota_update_handler(httpd_req_t* req);
 static esp_err_t http_server_ota_status_handler(httpd_req_t* req);
-static esp_err_t http_server_sensor_value_handler(httpd_req_t* req);
 static void http_server_fw_update_reset_timer(void);
 
 // Public Function Definition

firmware/components/bt_gatts/bt_gatts.c

@@ -172,9 +172,9 @@ void ble_server_write_event(esp_gatt_if_t gatts_if,
 void ble_server_exce_write_event(prepare_type_env_t* prepare_write_env,
                                  esp_ble_gatts_cb_param_t* param) {
   if (param->exec_write.exec_write_flag == ESP_GATT_PREP_WRITE_EXEC) {
-    esp_log_buffer_hex(TAG_BT_GATTS, prepare_write_env->prepare_buf,
+    ESP_LOG_BUFFER_HEX(TAG_BT_GATTS, prepare_write_env->prepare_buf,
                        prepare_write_env->prepare_len);
-    esp_log_buffer_char(TAG_BT_GATTS, param->write.value, param->write.len);
+    ESP_LOG_BUFFER_CHAR(TAG_BT_GATTS, param->write.value, param->write.len);
   } else {
     ESP_LOGI(TAG_BT_GATTS, "ESP_GATT_PREP_WRITE_CANCEL");
   }
@@ -290,8 +290,8 @@ void ble_server_gatt_profiles_event_handler(esp_gatts_cb_event_t event,
       if (!param->write.is_prep) {
         ESP_LOGI(TAG_BT_GATTS,
                  "GATT_WRITE_EVT, value len %d, value :", param->write.len);
-        esp_log_buffer_hex(TAG_BT_GATTS, param->write.value, param->write.len);
-        esp_log_buffer_char(TAG_BT_GATTS, param->write.value, param->write.len);
+        ESP_LOG_BUFFER_HEX(TAG_BT_GATTS, param->write.value, param->write.len);
+        ESP_LOG_BUFFER_CHAR(TAG_BT_GATTS, param->write.value, param->write.len);
 
         if (ble_server_gatt_profile_tab[DEVICE_PROFILE].descr_handle ==
                 param->write.handle &&
@@ -319,7 +319,7 @@ void ble_server_gatt_profiles_event_handler(esp_gatts_cb_event_t event,
             ESP_LOGI(TAG_BT_GATTS, "notify/indicate disable ");
           } else {
             ESP_LOGE(TAG_BT_GATTS, "unknown descr value");
-            esp_log_buffer_hex(TAG_BT_GATTS, param->write.value,
+            ESP_LOG_BUFFER_HEX(TAG_BT_GATTS, param->write.value,
                                param->write.len);
           }
         }
@@ -463,8 +463,8 @@ void ble_server_gatt_profiles_event_handler(esp_gatts_cb_event_t event,
                param->conf.status, param->conf.handle);
       if (param->conf.status != ESP_GATT_OK) {
         ESP_LOGW(TAG_BT_GATTS, "Confirm error, status %d", param->conf.status);
-        esp_log_buffer_hex(TAG_BT_GATTS, param->conf.value, param->conf.len);
-        esp_log_buffer_char(TAG_BT_GATTS, param->conf.value, param->conf.len);
+        ESP_LOG_BUFFER_HEX(TAG_BT_GATTS, param->conf.value, param->conf.len);
+        ESP_LOG_BUFFER_CHAR(TAG_BT_GATTS, param->conf.value, param->conf.len);
       }
       break;
     }

firmware/components/bt_spam/bt_spam.c

@@ -9,7 +9,6 @@
 static const char* TAG = "bt_spam";
 
 static bt_spam_cb_display display_records_cb = NULL;
-static TimerHandle_t adv_timer;
 static volatile bool running_task = false;
 static int adv_index = 0;
 static TaskHandle_t adv_task_handle = NULL;
@@ -142,7 +141,7 @@ static void start_adv_timer_callback() {
 
   display_records_cb(long_names_devices[adv_index]);
   esp_err_t err = esp_ble_gap_config_adv_data_raw(
-      long_devices_raw[adv_index], sizeof(long_devices_raw[adv_index]));
+      (uint8_t*) long_devices_raw[adv_index], sizeof(long_devices_raw[adv_index]));
   if (err != ESP_OK) {
     ESP_LOGE(TAG, "Error setting adv data: %s", esp_err_to_name(err));
     return;

firmware/components/buzzer/buzzer.c

@@ -12,8 +12,6 @@
 #define BUZZER_DEFAULT_DUTTY        (4096)  // Set duty to 50%. (2 ** 13) * 50% = 4096
 #define BUZZER_DEFAULT_FREQUENCY_HZ (4000)  // Set frequency at 4 kHz
 
-static const char* TAG = "buzzer";
-
 typedef struct {
   uint8_t pin;
   uint32_t freq;

firmware/components/drone_id/id_open/id_open.cpp

@@ -172,10 +172,9 @@ ID_OpenDrone::ID_OpenDrone() {
 void ID_OpenDrone::init(UTM_parameters* parameters, bool ble_drone) {
   bt_mode = ble_drone;
 
-  int status, i;
+  int i;
   char text[128];
 
-  status = 0;
   text[0] = text[63] = 0;
 
 #if DIAGNOSTICS
@@ -322,7 +321,6 @@ void ID_OpenDrone::set_auth(char* auth) {
 
 void ID_OpenDrone::set_auth(uint8_t* auth, short int len, uint8_t type) {
   int i, j;
-  char text[160];
   uint8_t check[32];
 
   auth_page_count = 1;
@@ -403,14 +401,12 @@ void ID_OpenDrone::set_auth(uint8_t* auth, short int len, uint8_t type) {
 
 int ID_OpenDrone::transmit(struct UTM_data* utm_data) {
   int i, status = 0;
-  char text[128];
   time_t secs = 0;
   static int phase = 0;
 
   //
 
   i = 0;
-  text[0] = 0;
   msecs = esp_timer_get_time() / 1000;
 
   // For the ODID 2.0 and auth timestamps.
@@ -640,9 +636,6 @@ int ID_OpenDrone::transmit_wifi(struct UTM_data* utm_data, int prepacked) {
 
   int length = 0, wifi_status = 0;
   uint64_t usecs = 0;
-  char text[128];
-
-  text[0] = 0;
 
   //
 
@@ -781,10 +774,8 @@ int ID_OpenDrone::transmit_ble(uint8_t* odid_msg, int length) {
   // #if ID_OD_BT
 
   int i, j, k, len, status;
-  uint8_t* a;
 
-  i = j = k = len = 0;
-  a = ble_message;
+  i = j = k = len = status = 0;
 
   memset(ble_message, 0, sizeof(ble_message));
 

firmware/components/drone_id/id_open_esp32/id_open_esp32.cpp

@@ -62,7 +62,6 @@
 #if ID_OD_WIFI
 
   #include <esp_event.h>
-  #include <esp_event_loop.h>
   #include <esp_system.h>
   #include <esp_wifi.h>
   #include <esp_wifi_types.h>
@@ -171,10 +170,8 @@ void init_w(char* ssid,
             int ssid_length,
             uint8_t* WiFi_mac_addr,
             uint8_t wifi_channel) {
-  int status;
   char text[128];
 
-  status = 0;
   text[0] = text[63] = 0;
 
 #if ID_OD_WIFI

firmware/components/drone_id/odrone_id.cpp

@@ -32,7 +32,7 @@ void odrone_id_set_num_spoofers(uint8_t num_drones) {
 }
 
 void odrone_id_set_wifi_ap(uint8_t channel) {
-  set_wifi_ap("Mini Drone", channel);
+  set_wifi_ap((char*)"Mini Drone", channel);
 }
 
 void odrone_id_set_location(float latitude, float longitude) {

firmware/components/drone_id/spoofer/spoofer.cpp

@@ -27,7 +27,7 @@ void Spoofer::updateLocation(float latitude, float longitude) {
   double lat_d = utm_data.latitude_d = utm_data.base_latitude =
       latitude + (float) (rand() % 10 - 5) / 10000.0;
 
-  double long_d = utm_data.longitude_d = utm_data.base_longitude =
+  [[maybe_unused]] double long_d = utm_data.longitude_d = utm_data.base_longitude =
       longitude + (float) (rand() % 10 - 5) / 10000.0;
 
   utm_data.base_valid = 1;
@@ -79,7 +79,7 @@ void Spoofer::update() {
   y += speed_m_y * time_elapsed_secs;
 
   // calculate new height
-  float climbrate =
+  [[maybe_unused]] float climbrate =
       float(rand() % int(2 * max_climbrate) - max_climbrate) / 1000.0;
   z = (z < -max_height) ? -max_height : (z > max_height ? max_height : z);
   utm_data.alt_msl_m = utm_data.base_alt_m + z;

firmware/components/flash_fs/flash_fs.c

@@ -9,7 +9,6 @@
 static size_t flash_fs_size, flash_fs_used;
 
 static void (*flash_fs_show_event_cb)(flash_fs_events_t, void*) = NULL;
-static bool already_mounted = false;
 
 void flash_fs_begin(void* screens_cb) {
   flash_fs_show_event_cb = screens_cb;

firmware/components/ieee_sniffer/ieee_sniffer.c

@@ -18,7 +18,7 @@ static ieee_sniffer_cb_t packet_callback = NULL;
 static int current_channel = IEEE_SNIFFER_CHANNEL_DEFAULT;
 static bool running = false;
 
-static void debug_print_packet(uint8_t* packet, uint8_t packet_length);
+static void debug_print_packet(uint8_t* packet, uint8_t packet_length) __attribute__((unused));
 static void debug_handler_task(void* pvParameters);
 
 static char addressing_mode[4][15] = {"None", "Reserved", "Short/16-bit",
@@ -291,7 +291,7 @@ static void debug_print_packet(uint8_t* packet, uint8_t packet_length) {
 
       printf("Data length: %u\n", data_length);
       printf("Data: ==================================================\n");
-      esp_log_buffer_hex(TAG_IEEE_SNIFFER, data, data_length);
+      ESP_LOG_BUFFER_HEX(TAG_IEEE_SNIFFER, data, data_length);
 
       uint16_t checksum = *((uint16_t*) &packet[position]);
 
@@ -309,6 +309,6 @@ static void debug_print_packet(uint8_t* packet, uint8_t packet_length) {
       break;
     }
   }
-  esp_log_buffer_hex(TAG_IEEE_SNIFFER, packet, packet_length);
+  ESP_LOG_BUFFER_HEX(TAG_IEEE_SNIFFER, packet, packet_length);
   printf("-----------------------\n");
 }