Skip to content

Mostly cleaning code a bit - #15

Open
sigmdel wants to merge 4 commits into
ElektorLabs:masterfrom
sigmdel:master
Open

Mostly cleaning code a bit#15
sigmdel wants to merge 4 commits into
ElektorLabs:masterfrom
sigmdel:master

Conversation

@sigmdel

@sigmdel sigmdel commented Jun 14, 2023

Copy link
Copy Markdown

Proposed changes to NTP_Server

  • 53fa221: ntp_packet_t.precision is a signed byte and usually negative.
  • 138f945: can't imagine processUDPPacket() would ever need to be called from outside the NTP_Server.
  • 725ae69: removing the initial byte order swaps of the timestamps that get overwritten later.

Compilation error in platform-espressif32 v 6.3.1

  • c23def7: compiler throwing error when comparing 0 to deserializeJson in line 443
  • all the other changes are fluff; my editor automatically removed trailing spaces. Sorry about that.

Thank you very much for NTP_Server, it is very useful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant