Skip to content

_forward_step_fn does not always return two values so eval.py breaks if is_pipe_parallel is false #1320

New issue
New issue
Open
#1356
Open
_forward_step_fn does not always return two values so eval.py breaks if is_pipe_parallel is false#1320
#1356
Labels
bugSomething isn't working
@markNZed

Description

@markNZed
markNZed
opened on Nov 12, 2024

This call to _forward_step_fn expects two values returned

gpt-neox/eval_tasks/eval_adapter.py

Line 372 in 59a5236

_, logits = self._forward_step_fn(model=self.model, data_iterator=inps)

The forward_step can return three values

gpt-neox/megatron/training.py

Line 847 in 59a5236

return loss, outputs, metrics

I guess I am seeing this because I have is_pipe_parallel false and that is uncommon. Maybe there needs to be an option not to return metrics.

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions