Corrupt url when deleting filter using ajax.

[dhacquebord]

Hi,

I'm trying to add Ajax filtering to our websites but at some times i'm encountering a weird error.

For example:
I'm currently at the this URL: /kleding/schoenen/eigenschappen/rits/geslacht/unisex/merk/nike/merk/adidas.

Expected result:
I expect the new URL to be /kleding/schoenen/eigenschappen/rits/geslacht/unisex/merk/adidas.

Actual result:
When i try to remove filter merk/nike the page does refresh and give me the correct products and selected filters but the URL turned to:
/kleding/schoenen/eigenschappen/rits/geslacht/unisex/merk/nike/merk/adidas/eigenschappen/rits/geslacht/unisex/merk/adidas/.

I think the problem lies in the following function:

Magento2Tweakwise/Model/Catalog/Layer/Url/Strategy/PathSlugStrategy.php

Lines 375 to 416 in e75e97d

	public function buildFilterUrl(MagentoHttpRequest $request, array $filters = []): string
	{
	$currentUrl = $this->getOriginalUrl($request);
	$currentFilterPath = $request->getParam(self::REQUEST_FILTER_PATH);
	$newFilterPath = $this->buildFilterSlugPath($filters);
	if (empty($currentFilterPath)) {
	$urlParts = parse_url($currentUrl);
	if (strpos($urlParts['path'], $newFilterPath) === false) {
	$url = $urlParts['path'] . $newFilterPath;
	} else {
	//filter path already exists in url
	$url = $urlParts['path'];
	}
	if (isset($urlParts['query'])) {
	$url .= '?' . $urlParts['query'];
	}
	} else {
	// Replace filter path in current URL with the new filter combination path
	if (strpos($currentUrl, $currentFilterPath) !== false) {
	$url = str_replace(
	sprintf('%s/', rtrim($currentFilterPath, '/')),
	sprintf('%s/', $newFilterPath),
	$currentUrl
	);
	} else {
	$url = $currentUrl . '/' . $newFilterPath;
	}
	}
	$categoryUrlSuffix = $this->scopeConfig->getValue(
	CategoryUrlPathGenerator::XML_PATH_CATEGORY_URL_SUFFIX,
	'store'
	);
	// Replace all occurrences of double slashes with a single slash except those in scheme.
	// This can happen when $categoryUrlSuffix === '/' and in some other cases
	return preg_replace('/(?<!:)\/\//', '/', $url);
	}

When i add some logging i notice that:

• currentUrl is /kleding/schoenen/eigenschappen/rits/geslacht/unisex/merk/nike/merk/adidas
• currentFilterPath is empty
• newFilterPath is /eigenschappen/rits/geslacht/unisex/merk/adidas/

Line 385 checks if currentUrl contains newFilterPath and concludes that it doesn't. Therefore it adds newFilterPath to the current Url and returns it.

How is this function supposed to work? Should currentFilterPath not be empty?

Context:
We're running on Magento 2.4.6 with Hyvä 1.3.14, with the following Tweakwise extensions:

        "tweakwise/magento2-attributelanding-tweakwise": "4.4.1",
        "tweakwise/magento2-tweakwise": "8.6.1",
        "tweakwise/magento2-tweakwise-export": "7.6.0",
        "tweakwise/magento2-tweakwise-hyva": "4.4.0",

[ahuininga-orisha]

@dhacquebord In your example the current filterpath should be eigenschappen/rits/geslacht/unisex/merk/nike/merk/adidas.

The only reason i can think of why it is empty is that you have an ALP with that exact filter in the url of the ALP. Is that the case? Do you have an ALP with /kleding/schoenen/eigenschappen/rits/geslacht/unisex/merk/nike/merk/adidas in the URL?

[ahuininga-orisha]

@dhacquebord I did some testing and the 'currentFilterPath' variable doesn't have anything to do with this issue

Where does your current url come from? Because that causes the issue. The currentUrl variable should not include the selected filters. But only the real url of the current category or ALP. If it is an ALP can you make an screenshot of the ALP settings? Because i think that may be the cause of the issue.

[dhacquebord]

In your example the current filterpath should be eigenschappen/rits/geslacht/unisex/merk/nike/merk/adidas.

The only reason i can think of why it is empty is that you have an ALP with that exact filter in the url of the ALP. Is that the case? Do you have an ALP with /kleding/schoenen/eigenschappen/rits/geslacht/unisex/merk/nike/merk/adidas in the URL?

@ahuininga-orisha No i don't think that is the case. We do have ALP's for some of our brands, e.g. /werkkledij/werkshirts/blacklader.

I also just noticed that when i'm on /werkkledij/werkshirts and add the filter Blacklader it sends me to /werkkledij/werkshirts/merk/blaklader. There is a ALP for /werkkledij/werkshirts/blaklader, but for some reason it doesn't send me to that URL and doesn't show me the ALP content either.
The ALP content does show when i load /werkkledij/werkshirts/blaklader.

Here is a screenshot for the configuration of that ALP: https://share.cleanshot.com/K1YHVy4T

[ahuininga-orisha]

@dhacquebord

In your screenshot it seems that you use an external module/code for the ALP. Amasty facet page. I'm not sure what this does, but i would imagine that it does have an impact on the filter url or the ALP page.

That could also explain why i can't seem to reproduce the issue. Can you reproduce this issue on an clean magento install with sample data?