clean code

Author: CppCXY

.github/workflows/deepseek_review.yml

@@ -2,39 +2,19 @@ name: Deepseek Code Review
 on:
   pull_request_target:
     types:
-      - opened      # Triggers when a PR is opened
+      - opened # Triggers when a PR is opened
 
+# fix: GraphQL: Resource not accessible by integration (addComment) error
 permissions:
-  contents: read
   pull-requests: write
 
 jobs:
   setup-deepseek-review:
-    if: github.event_name == 'pull_request_target'
+    timeout-minutes: 30
     runs-on: ubuntu-latest
     name: Code Review
     steps:
-      - name: Checkout deepseek-review scripts
-        uses: actions/checkout@v4
-        with:
-          repository: hustcer/deepseek-review
-          path: .tmp/deepseek-review
-
-      - name: Setup Nu
-        uses: hustcer/setup-nu@v3.23
-        with:
-          version: 0.112.2
-
       - name: DeepSeek Code Review
-        shell: nu {0}
-        env:
-          REVIEW_PR_NUMBER: ${{ github.event.pull_request.number }}
-          REVIEW_REPO: ${{ github.repository }}
-          REVIEW_TOKEN: ${{ secrets.DEEPSEEK_CHAT_TOKEN }}
-          REVIEW_GITHUB_TOKEN: ${{ github.token }}
-          REVIEW_MODEL: deepseek-v4-flash
-        run: |
-          const NU_LIB_DIRS = [ '${{ github.workspace }}/.tmp/deepseek-review/nu' ]
-          use review.nu *
-
-          deepseek-review $env.REVIEW_TOKEN --model $env.REVIEW_MODEL --repo $env.REVIEW_REPO --pr-number $env.REVIEW_PR_NUMBER --gh-token $env.REVIEW_GITHUB_TOKEN
+        uses: hustcer/deepseek-review@v1
+        with:
+          chat-token: ${{ secrets.DEEPSEEK_CHAT_TOKEN }}

crates/emmylua_doc_cli/src/html_generator/generators.rs

@@ -4,7 +4,7 @@ use emmylua_code_analysis::{
 };
 use emmylua_parser::VisibilityKind;
 
-use crate::html_generator::html_type;
+use crate::html_generator::html_type::{self, TypeLinker};
 use crate::html_generator::types::{HtmlDoc, HtmlMember};
 use crate::markdown_generator::generator::collect_property;
 
@@ -16,7 +16,7 @@ pub struct GenContext<'a> {
     pub db: &'a DbIndex,
     /// Maps a type declaration id to a page href (prefixed relative to the
     /// page being generated).
-    pub linker: &'a super::html_type::TypeLinker<'a>,
+    pub linker: &'a TypeLinker<'a>,
 }
 
 pub fn build_type_doc(ctx: &GenContext, typ: &LuaTypeDecl) -> Option<HtmlDoc> {

crates/emmylua_doc_cli/src/html_generator/types.rs

@@ -1,5 +1,7 @@
 use serde::Serialize;
 
+use crate::markdown_generator::markdown_types;
+
 use super::markdown::render_markdown;
 use super::render::html_escape;
 
@@ -135,7 +137,7 @@ pub struct HtmlDoc {
 impl HtmlDoc {
     /// Stores rendered doc fields. Description / see / other are rendered as
     /// markdown HTML; deprecated is escaped plain text.
-    pub fn set_property(&mut self, property: crate::markdown_generator::markdown_types::Property) {
+    pub fn set_property(&mut self, property: markdown_types::Property) {
         self.description = property.description.map(|s| render_markdown(&s));
         self.deprecated = property.deprecated.map(|s| html_escape(&s));
         self.see = property.see.map(|s| render_markdown(&s));