Skip to content

Commit b53c69c

Browse files
committed
chore(ci): drop redundant deploy dispatch from release flow
The PAT-authored auto-merge push to main already triggers deploy.yml (on: push), so the release_created deploy dispatch just queued a second deploy of the same commit that failed as a duplicate. Also drop the now-unused actions:write permission.
1 parent ec74d9b commit b53c69c

1 file changed

Lines changed: 3 additions & 13 deletions

File tree

.github/workflows/release-please.yml

Lines changed: 3 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@ on:
66
workflow_dispatch:
77

88
permissions:
9-
actions: write
109
contents: write
1110
pull-requests: write
1211

@@ -26,21 +25,12 @@ jobs:
2625
manifest-file: .release-please-manifest.json
2726

2827
# Enable native auto-merge and stop; GitHub rebase-merges once the required
29-
# checks pass, and that PAT-authored merge re-triggers this workflow to cut
30-
# the tag/release.
28+
# checks pass, and that PAT-authored merge is a push to main that both
29+
# re-triggers this workflow to cut the tag/release and triggers the deploy
30+
# (on: push), so no explicit deploy dispatch is needed here.
3131
- if: ${{ steps.release.outputs.pr }}
3232
env:
3333
GH_TOKEN: ${{ secrets.RELEASE_PLEASE_TOKEN }}
3434
REPO: ${{ github.repository }}
3535
PR_JSON: ${{ steps.release.outputs.pr }}
3636
run: gh pr merge --rebase --auto -R "$REPO" "$(echo "$PR_JSON" | jq -r .number)"
37-
38-
# When a release is actually published, redeploy from main so the live
39-
# build carries the bumped version. release-please's own version-bump
40-
# commit is pushed by GITHUB_TOKEN and does NOT trigger the on:push deploy,
41-
# so the site would otherwise stay one release behind.
42-
- if: ${{ steps.release.outputs.release_created }}
43-
env:
44-
GH_TOKEN: ${{ secrets.RELEASE_PLEASE_TOKEN }}
45-
REPO: ${{ github.repository }}
46-
run: gh workflow run deploy.yml -R "$REPO" --ref main

0 commit comments

Comments
 (0)