(2/2) DEMOS-2237: Cleanup checks for !currentUser#1407
Merged
Conversation
Contributor
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
james-becwar-cms
approved these changes
Jun 9, 2026
tresdonicf
commented
Jun 9, 2026
Comment on lines
-103
to
-105
| if (!currentUser) { | ||
| throw new Error("FileAndHistoryTabs requires an authenticated user."); | ||
| } |
Contributor
Author
There was a problem hiding this comment.
We had to have a bunch of these sprinkled about in the codebase since getCurrentUser could return currentUser: undefined - now it's no longer needed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that
currentUseris not optional on theUserContextwe can clean up all this handling forif(!currentUser)around the codebase 🥳