Skip to content

Commit 0426b71

Browse files
committed
fix: lint, cleanup
1 parent 3e77c34 commit 0426b71

23 files changed

+241
-29
lines changed

.pyspelling.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -15,5 +15,5 @@ matrix:
1515
- code
1616
- pre
1717
sources:
18-
- '!dump/*|!**/INFO.md|!**/TODO.md|!venv/**|**/*.md'
18+
- '!**/INFO.md|!**/TODO.md|!venv/**|!scratch/**|!dump/**|**/*.md'
1919
default_encoding: utf-8

.yamllint

+13-3
Original file line numberDiff line numberDiff line change
@@ -7,10 +7,20 @@ rules:
77
new-line-at-end-of-file: disable
88
indentation:
99
indent-sequences: whatever
10-
ignore: dump/
10+
ignore: kludgeops/
1111
braces:
12-
ignore: components/operators/grafana-operator/base/instance/grafana.yaml
12+
min-spaces-inside: 0
13+
max-spaces-inside: 1
1314
truthy:
1415
ignore: .github/workflows/
1516
trailing-spaces:
16-
ignore: components/operators/openshift-gitops-operator/instance/overlays/default/patch-resource-customizations.yaml
17+
ignore: |
18+
# components/operators/openshift-gitops-operator/instance/overlays/default/patch-resource-customizations.yaml
19+
empty-lines:
20+
ignore: |
21+
components/operators/ack-controllers/base/adoptedresources-crd.yaml
22+
23+
ignore:
24+
- "scratch/*"
25+
- "components/containers/web-terminal/src/*"
26+
- "components/operators/gpu-operator-certified/operator/components/console-plugin-helm/*"
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,34 @@
1+
kind: DataScienceCluster
2+
apiVersion: datasciencecluster.opendatahub.io/v1
3+
metadata:
4+
name: default-dsc
5+
labels:
6+
app.kubernetes.io/name: datasciencecluster
7+
app.kubernetes.io/instance: default
8+
app.kubernetes.io/part-of: rhods-operator
9+
app.kubernetes.io/managed-by: kustomize
10+
app.kubernetes.io/created-by: rhods-operator
11+
spec:
12+
components:
13+
codeflare:
14+
managementState: Managed
15+
dashboard:
16+
managementState: Managed
17+
datasciencepipelines:
18+
managementState: Managed
19+
kserve:
20+
managementState: Managed
21+
serving:
22+
ingressGateway:
23+
certificate:
24+
type: SelfSigned
25+
managementState: Managed
26+
name: knative-serving
27+
modelmeshserving:
28+
managementState: Managed
29+
ray:
30+
managementState: Managed
31+
trustyai:
32+
managementState: Managed
33+
workbenches:
34+
managementState: Managed

components/demos/instance/rhods/kustomization.yaml

+1
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@ kind: Kustomization
44
resources:
55
- ../../base
66
- nb-culler-config.yaml
7+
- datasciencecluster.yaml
78
- odh-dashboard-config-cr.yaml
89
- rhods-admins-group.yaml
910
- rhods-self-provisioner-clusterrolebinding.yaml
+19-11
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,24 @@
11
# rhods-operator
22

3-
Red Hat OpenShift Data Science (RHODS) is a machine-learning-as-a-service
4-
platform built on Red Hat's Kubernetes-based OpenShift Container Platform,
5-
Ceph Object Storage, and integrating a collection of open source projects.
3+
Red Hat OpenShift AI is a complete platform for the entire lifecycle of your AI/ML projects.
64

7-
The RHODS operator allows users to install and manage RHODS components.
8-
Users can mix and match tools from each project to fulfill the needs of
9-
their use case. Each of the projects share some components, but can be
10-
mostly seen as an extension of each other to provide as complete a solution
11-
as possible for enterprise users.
5+
When using Red Hat OpenShift AI, your users will find all the tools they would expect from a modern AI/ML platform in an interface that is intuitive, requires no local install, and is backed by the power of your OpenShift cluster.
126

13-
### Components
7+
Your Data Scientists will feel right at home with quick and simple access to the Notebook interface they are used to. They can leverage the default Notebook Images (Including PyTorch, tensorflow, and CUDA), or add custom ones. Your MLOps engineers will be able to leverage Data Science Pipelines to easily parallelize and/or schedule the required workloads. They can then quickly serve, monitor, and update the created AI/ML models. They can do that by either using the provided out-of-the-box OpenVino Server Model Runtime or by adding their own custom serving runtime instead. These activities are tied together with the concept of Data Science Projects, simplifying both organization and collaboration.
8+
9+
But beyond the individual features, one of the key aspects of this platform is its flexibility. Not only can you augment it with your own Customer Workbench Image and Custom Model Serving Runtime Images, but you will also have a consistent experience across any infrastructure footprint. Be it in the public cloud, private cloud, on-premises, and even in disconnected clusters. Red Hat OpenShift AI can be installed on any supported OpenShift. It can scale out or in depending on the size of your team and its computing requirements.
10+
11+
Finally, thanks to the operator-driven deployment and updates, the administrative load of the platform is very light, leaving everyone more time to focus on the work that makes a difference.
1412

15-
* Notebook Controller - Open source multi-user notebook platform w/ GPU support
16-
* RHODS Dashboard - Dashboard for Red Hat OpenShift Data Science
13+
14+
### Components
15+
* Dashboard
16+
* Curated Workbench Images (incl CUDA, PyTorch, Tensorflow, code-server)
17+
* Ability to add Custom Images
18+
* Ability to leverage accelerators (such as NVIDIA GPU)
19+
* Data Science Pipelines. (including Elyra notebook interface, and based on standard OpenShift Pipelines)
20+
* Model Serving using ModelMesh and Kserve.
21+
* Ability to use other runtimes for serving
22+
* Model Monitoring
23+
* Distributed workloads (KubeRay, CodeFlare)
24+
* XAI explanations of predictive models (TrustyAI)

components/operators/rhods-operator/README.md

+6-3
Original file line numberDiff line numberDiff line change
@@ -1,17 +1,20 @@
1-
# Red Hat OpenShift Data Science
1+
# Red Hat OpenShift AI
22

3-
Install Red Hat OpenShift Data Science.
3+
Install Red Hat OpenShift AI.
44

55
Do not use the `base` directory directly, as you will need to patch the `channel` based on the version of OpenShift you are using, or the version of the operator you want to use.
66

77
The current *overlays* available are for the following channels:
88

9+
* [alpha](operator/overlays/alpha)
910
* [beta](operator/overlays/beta)
11+
* [embedded](operator/overlays/embedded)
12+
* [fast](operator/overlays/fast)
1013
* [stable](operator/overlays/stable)
1114

1215
## Usage
1316

14-
If you have cloned the `gitops-catalog` repository, you can install Red Hat OpenShift Data Science based on the overlay of your choice by running from the root (`gitops-catalog`) directory.
17+
If you have cloned the `gitops-catalog` repository, you can install Red Hat OpenShift AI based on the overlay of your choice by running from the root (`gitops-catalog`) directory.
1518

1619
```
1720
oc apply -k rhods-operator/operator/overlays/<channel>
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
apiVersion: kustomize.config.k8s.io/v1beta1
2+
kind: Kustomization
3+
4+
resources:
5+
- profile-nvidia.yaml
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,19 @@
1+
apiVersion: dashboard.opendatahub.io/v1
2+
kind: AcceleratorProfile
3+
metadata:
4+
annotations:
5+
# opendatahub.io/modified-date: '2024-02-14T00:57:22.878Z'
6+
name: nvidia
7+
namespace: redhat-ods-applications
8+
spec:
9+
description: Default Nvidia GPU Profile
10+
displayName: Nvidia GPU
11+
enabled: true
12+
identifier: nvidia.com/gpu
13+
tolerations:
14+
- effect: NoSchedule
15+
key: nvidia-gpu-only
16+
operator: Exists
17+
- effect: NoSchedule
18+
key: nvidia.com/gpu
19+
operator: Exists
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,34 @@
1+
kind: DataScienceCluster
2+
apiVersion: datasciencecluster.opendatahub.io/v1
3+
metadata:
4+
name: default-dsc
5+
labels:
6+
app.kubernetes.io/name: datasciencecluster
7+
app.kubernetes.io/instance: default
8+
app.kubernetes.io/part-of: rhods-operator
9+
app.kubernetes.io/managed-by: kustomize
10+
app.kubernetes.io/created-by: rhods-operator
11+
spec:
12+
components:
13+
codeflare:
14+
managementState: Managed
15+
dashboard:
16+
managementState: Managed
17+
datasciencepipelines:
18+
managementState: Managed
19+
kserve:
20+
managementState: Managed
21+
serving:
22+
ingressGateway:
23+
certificate:
24+
type: SelfSigned
25+
managementState: Managed
26+
name: knative-serving
27+
modelmeshserving:
28+
managementState: Managed
29+
ray:
30+
managementState: Managed
31+
trustyai:
32+
managementState: Managed
33+
workbenches:
34+
managementState: Managed
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
apiVersion: kustomize.config.k8s.io/v1beta1
2+
kind: Kustomization
3+
4+
resources:
5+
- ../../base
6+
- datasciencecluster.yaml
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,36 @@
1+
apiVersion: datasciencecluster.opendatahub.io/v1
2+
kind: DataScienceCluster
3+
metadata:
4+
name: default-dsc
5+
labels:
6+
app.kubernetes.io/name: datasciencecluster
7+
app.kubernetes.io/instance: default-dsc
8+
app.kubernetes.io/part-of: rhods-operator
9+
app.kubernetes.io/managed-by: kustomize
10+
app.kubernetes.io/created-by: rhods-operator
11+
spec:
12+
components:
13+
codeflare:
14+
managementState: Managed
15+
dashboard:
16+
managementState: Managed
17+
datasciencepipelines:
18+
managementState: Managed
19+
kserve:
20+
managementState: Managed
21+
serving:
22+
ingressGateway:
23+
certificate:
24+
type: SelfSigned
25+
managementState: Managed
26+
name: knative-serving
27+
kueue:
28+
managementState: Managed
29+
modelmeshserving:
30+
managementState: Managed
31+
ray:
32+
managementState: Managed
33+
trustyai:
34+
managementState: Managed
35+
workbenches:
36+
managementState: Managed
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
apiVersion: kustomize.config.k8s.io/v1beta1
2+
kind: Kustomization
3+
4+
resources:
5+
- ../../base
6+
- datasciencecluster.yaml

components/operators/rhods-operator/operator/base/namespace.yaml

+1-1
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ apiVersion: v1
22
kind: Namespace
33
metadata:
44
annotations:
5-
openshift.io/display-name: "Red Hat OpenShift Data Science"
5+
openshift.io/display-name: "Red Hat OpenShift AI"
66
labels:
77
openshift.io/cluster-monitoring: 'true'
88
name: redhat-ods-operator
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
apiVersion: operators.coreos.com/v1
22
kind: OperatorGroup
33
metadata:
4-
name: rhods-operator-group
4+
name: rhods-operator
55
namespace: redhat-ods-operator
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,11 @@
1+
apiVersion: kustomize.config.k8s.io/v1beta1
2+
kind: Kustomization
3+
4+
resources:
5+
- ../../base
6+
7+
patches:
8+
- target:
9+
kind: Subscription
10+
name: rhods-operator
11+
path: patch-channel.yaml
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
- op: replace
2+
path: /spec/channel
3+
value: alpha
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,11 @@
1+
apiVersion: kustomize.config.k8s.io/v1beta1
2+
kind: Kustomization
3+
4+
resources:
5+
- ../../base
6+
7+
patches:
8+
- target:
9+
kind: Subscription
10+
name: rhods-operator
11+
path: patch-channel.yaml
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
- op: replace
2+
path: /spec/channel
3+
value: embedded
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,11 @@
1+
apiVersion: kustomize.config.k8s.io/v1beta1
2+
kind: Kustomization
3+
4+
resources:
5+
- ../../base
6+
7+
patches:
8+
- target:
9+
kind: Subscription
10+
name: rhods-operator
11+
path: patch-channel.yaml
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
- op: replace
2+
path: /spec/channel
3+
value: fast
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,11 @@
1+
apiVersion: kustomize.config.k8s.io/v1beta1
2+
kind: Kustomization
3+
4+
resources:
5+
- ../../base
6+
7+
patches:
8+
- target:
9+
kind: Subscription
10+
name: rhods-operator
11+
path: patch-channel.yaml
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
- op: replace
2+
path: /spec/channel
3+
value: stable
4+
- op: replace
5+
path: /spec/startingCSV
6+
value: rhods-operator.1.30.0

components/operators/rhods-operator/operator/overlays/stable/kustomization.yaml

-9
Original file line numberDiff line numberDiff line change
@@ -9,12 +9,3 @@ patches:
99
kind: Subscription
1010
name: rhods-operator
1111
path: patch-channel.yaml
12-
# kludge: for rhdp - just don't install operator
13-
- target:
14-
group: operators.coreos.com
15-
kind: OperatorGroup
16-
name: rhods-operator-group
17-
patch: |-
18-
- op: replace
19-
path: /metadata/name
20-
value: rhods-ods-operator

0 commit comments

Comments
 (0)