Skip to content

Custom rule tape fixup#2816

Merged
wsmoses merged 1 commit intomainfrom
crulet
Nov 25, 2025
Merged

Custom rule tape fixup#2816
wsmoses merged 1 commit intomainfrom
crulet

Conversation

@wsmoses
Copy link
Member

@wsmoses wsmoses commented Nov 25, 2025

No description provided.

@github-actions
Copy link
Contributor

Your PR requires formatting changes to meet the project's style guidelines.
Please consider running Runic (git runic main) to apply these changes.

Click here to view the suggested changes.
diff --git a/src/rules/customrules.jl b/src/rules/customrules.jl
index 839b4ac0..a38d8208 100644
--- a/src/rules/customrules.jl
+++ b/src/rules/customrules.jl
@@ -1517,7 +1517,7 @@ function enzyme_custom_common_rev(
         end
     elseif tape isa LLVM.Value && length(byval_tapes) != 0
         if needsTape
-            @assert length(LLVM.elements(value_type(tape))) ==  length(byval_tapes) + 1
+            @assert length(LLVM.elements(value_type(tape))) == length(byval_tapes) + 1
             tape = extract_value!(B, tape, length(byval_tapes))
         else
             tape = nothing

@github-actions
Copy link
Contributor

Benchmark Results

main 7ae10ba... main / 7ae10ba...
basics/make_zero/namedtuple 0.0531 ± 0.0025 μs 0.0513 ± 0.0026 μs 1.04 ± 0.072
basics/make_zero/struct 0.256 ± 0.007 μs 0.253 ± 0.0073 μs 1.01 ± 0.04
basics/overhead 5.56 ± 0.92 ns 4.03 ± 0.01 ns 1.38 ± 0.23
basics/remake_zero!/namedtuple 0.239 ± 0.0072 μs 0.233 ± 0.0071 μs 1.03 ± 0.044
basics/remake_zero!/struct 0.232 ± 0.01 μs 0.233 ± 0.0091 μs 0.997 ± 0.06
fold_broadcast/multidim_sum_bcast/1D 10.4 ± 1.7 μs 10.4 ± 1.7 μs 1 ± 0.24
fold_broadcast/multidim_sum_bcast/2D 12.1 ± 0.25 μs 12.1 ± 0.26 μs 1 ± 0.03
time_to_load 1.25 ± 0.0068 s 1.25 ± 0.0079 s 0.999 ± 0.0083

Benchmark Plots

A plot of the benchmark results has been uploaded as an artifact at https://github.com/EnzymeAD/Enzyme.jl/actions/runs/19683198778/artifacts/4678501874.

@codecov
Copy link

codecov bot commented Nov 25, 2025

Codecov Report

❌ Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 67.78%. Comparing base (15be528) to head (7ae10ba).
⚠️ Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
src/rules/customrules.jl 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2816      +/-   ##
==========================================
- Coverage   67.79%   67.78%   -0.02%     
==========================================
  Files          58       58              
  Lines       20723    20726       +3     
==========================================
- Hits        14050    14049       -1     
- Misses       6673     6677       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@wsmoses wsmoses merged commit 98740e3 into main Nov 25, 2025
53 of 56 checks passed
@wsmoses wsmoses deleted the crulet branch November 25, 2025 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant