Handle case in EnzymeTestUtils of reduction over empties#3131
Open
kshyatt wants to merge 2 commits into
Open
Conversation
Contributor
|
Your PR requires formatting changes to meet the project's style guidelines. Click here to view the suggested changes.diff --git a/lib/EnzymeTestUtils/src/finite_difference_calls.jl b/lib/EnzymeTestUtils/src/finite_difference_calls.jl
index d6fe9026..9e355106 100644
--- a/lib/EnzymeTestUtils/src/finite_difference_calls.jl
+++ b/lib/EnzymeTestUtils/src/finite_difference_calls.jl
@@ -71,7 +71,7 @@ function j′vp(fdm, f_vec, ȳ, x)
end
end
end
- mat = isempty(ẏs) ? zeros(x, 0) : transpose(reduce(hcat, ẏs))
+ mat = isempty(ẏs) ? zeros(x, 0) : transpose(reduce(hcat, ẏs))
result = zero(x)
for i in 1:length(ȳ)
tp = @inbounds ȳ[i] |
Contributor
Benchmark Results
Benchmark PlotsA plot of the benchmark results has been uploaded as an artifact at https://github.com/EnzymeAD/Enzyme.jl/actions/runs/26741441976/artifacts/7325909088. |
wsmoses
reviewed
May 29, 2026
| end | ||
| end | ||
| mat = transpose(reduce(hcat, ẏs)) | ||
| mat = isempty(ẏs) ? [] : transpose(reduce(hcat, ẏs)) |
Member
There was a problem hiding this comment.
would it be better to have it be similar or zeros of x or something, to keep the type?
Collaborator
Author
There was a problem hiding this comment.
Yeah that could work, I'll try it out!
Collaborator
Author
I'd love to but it's kind of annoying because this function is only tested implicitly by other stuff... I'll see if I can think of a good way to do it. Or do you mind if I just call it directly in a test? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This keeps screwing up my life!!!!