[UE5.7] fix(eslint): pin tsconfigRootDir so lint works from any CWD (#834) (#837)

* fix(eslint): pin tsconfigRootDir so lint works from any CWD (#834)

Each workspace's eslint.config.mjs set parserOptions.project to a
workspace-prefixed path (e.g. 'Common/tsconfig.cjs.json') on the
assumption that typescript-eslint resolves it relative to the repo
root. That assumption holds only for some versions of typescript-eslint
and breaks outright when lint is invoked with CWD = workspace dir —
which is exactly how .github/workflows/healthcheck-libraries.yml runs
it (working-directory: Common, etc.).

Pin parserOptions.tsconfigRootDir to import.meta.dirname so the
relative project path is always resolved against the eslint config
file's own directory, regardless of CWD or typescript-eslint version.
Drop the workspace prefix from project accordingly.

(cherry picked from commit 7aa1fe2)

* fix: rebuilt package-lock

* fix: fixing lint issues.

---------

Co-authored-by: mcottontensor <80377552+mcottontensor@users.noreply.github.com>
Co-authored-by: Matthew.Cotton <matt@tensorworks.com.au>

Author: github-actions[bot]

.changeset/quiet-foxes-dance.md

@@ -0,0 +1,9 @@
+---
+"@epicgames-ps/lib-pixelstreamingcommon-ue5.7": patch
+"@epicgames-ps/lib-pixelstreamingsignalling-ue5.7": patch
+"@epicgames-ps/wilbur": patch
+"@epicgames-ps/lib-pixelstreamingfrontend-ue5.7": patch
+"@epicgames-ps/lib-pixelstreamingfrontend-ui-ue5.7": patch
+---
+
+Make `npm run lint` work regardless of the directory it's invoked from. Each workspace's `eslint.config.mjs` now pins `parserOptions.tsconfigRootDir` to `import.meta.dirname`, so `parserOptions.project` resolves relative to the config file's own directory rather than whichever CWD `typescript-eslint` happens to pick by default. Previously the six workspace configs prefixed `project` with the workspace directory (e.g. `'Common/tsconfig.cjs.json'`), which only worked under one specific `typescript-eslint` version's resolution behavior and broke CI when run from within the workspace.

Common/eslint.config.mjs

@@ -13,7 +13,8 @@ export default tseslint.config(
         languageOptions: {
             parser: tseslint.parser,
             parserOptions: {
-                project: 'Common/tsconfig.cjs.json',
+                project: 'tsconfig.cjs.json',
+                tsconfigRootDir: import.meta.dirname,
             },
         },
         files: ["src/**/*.ts"],

Extras/JSStreamer/eslint.config.mjs

@@ -13,7 +13,8 @@ export default tseslint.config(
         languageOptions: {
             parser: tseslint.parser,
             parserOptions: {
-                project: 'Extras/JSStreamer/tsconfig.cjs.json',
+                project: 'tsconfig.cjs.json',
+                tsconfigRootDir: import.meta.dirname,
             },
         },
         files: ["src/**/*.ts"],

Frontend/library/eslint.config.mjs

@@ -12,7 +12,8 @@ export default tseslint.config(
         languageOptions: {
             parser: tseslint.parser,
             parserOptions: {
-                project: 'Frontend/library/tsconfig.json',
+                project: 'tsconfig.json',
+                tsconfigRootDir: import.meta.dirname,
             },
         },
         files: ["src/**/*.ts"],

Frontend/library/src/DataChannel/DataChannelController.ts

@@ -35,7 +35,7 @@ export class DataChannelController {
         this.label = label;
         this.datachannelOptions = datachannelOptions;
         if (datachannelOptions == null) {
-            this.datachannelOptions = {} as RTCDataChannelInit;
+            this.datachannelOptions = {};
             this.datachannelOptions.ordered = true;
         }
 

Frontend/library/src/Inputs/GamepadController.ts

@@ -170,10 +170,10 @@ export class GamepadController implements IInputController {
                 const previousButton = controller.prevState.buttons[i];
                 if (currentButton.pressed) {
                     // press
-                    if ((i as GamepadLayout) === GamepadLayout.LeftTrigger) {
+                    if (i === Number(GamepadLayout.LeftTrigger)) {
                         // UEs left analog has a button index of 5
                         toStreamerHandlers.get('GamepadAnalog')([controllerId, 5, currentButton.value]);
-                    } else if ((i as GamepadLayout) === GamepadLayout.RightTrigger) {
+                    } else if (i === Number(GamepadLayout.RightTrigger)) {
                         // UEs right analog has a button index of 6
                         toStreamerHandlers.get('GamepadAnalog')([controllerId, 6, currentButton.value]);
                     } else {
@@ -185,10 +185,10 @@ export class GamepadController implements IInputController {
                     }
                 } else if (!currentButton.pressed && previousButton.pressed) {
                     // release
-                    if ((i as GamepadLayout) === GamepadLayout.LeftTrigger) {
+                    if (i === Number(GamepadLayout.LeftTrigger)) {
                         // UEs left analog has a button index of 5
                         toStreamerHandlers.get('GamepadAnalog')([controllerId, 5, 0]);
-                    } else if ((i as GamepadLayout) === GamepadLayout.RightTrigger) {
+                    } else if (i === Number(GamepadLayout.RightTrigger)) {
                         // UEs right analog has a button index of 6
                         toStreamerHandlers.get('GamepadAnalog')([controllerId, 6, 0]);
                     } else {

Frontend/library/src/WebRtcPlayer/WebRtcPlayerController.ts

@@ -175,7 +175,7 @@ export class WebRtcPlayerController {
         this.transport = new WebSocketTransport(config.webSocketProtocols);
         this.protocol = new SignallingProtocol(this.transport);
         this.protocol.addListener(Messages.config.typeName, (msg: BaseMessage) =>
-            this.handleOnConfigMessage(msg as Messages.config)
+            this.handleOnConfigMessage(msg)
         );
         this.protocol.addListener(Messages.ping.typeName, (msg: BaseMessage) =>
             this.handlePingMessage(msg as Messages.ping)

Frontend/ui-library/eslint.config.mjs

@@ -12,7 +12,8 @@ export default tseslint.config(
         languageOptions: {
             parser: tseslint.parser,
             parserOptions: {
-                project: 'Frontend/ui-library/tsconfig.json',
+                project: 'tsconfig.json',
+                tsconfigRootDir: import.meta.dirname,
             },
         },
         files: ["src/**/*.ts"],

Signalling/eslint.config.mjs

@@ -13,7 +13,8 @@ export default tseslint.config(
         languageOptions: {
             parser: tseslint.parser,
             parserOptions: {
-                project: 'Signalling/tsconfig.cjs.json',
+                project: 'tsconfig.cjs.json',
+                tsconfigRootDir: import.meta.dirname,
             },
         },
         files: ["src/**/*.ts"],

SignallingWebServer/eslint.config.mjs

@@ -14,7 +14,8 @@ export default tseslint.config(
         languageOptions: {
             parser: tseslint.parser,
             parserOptions: {
-                project: 'SignallingWebServer/tsconfig.json',
+                project: 'tsconfig.json',
+                tsconfigRootDir: import.meta.dirname,
             },
         },
         files: ["src/**/*.ts"],