Skip to content

Commit 083a739

Browse files
authored
Merge pull request opf#498 from opf/code-maintenance/dream-689-investigate-github-actions-issues-discovered-by-zizmor-in-primer_view_components-repo
[DREAM-689] Investigate GitHub Actions issues discovered by zizmor in primer_view_components repo
2 parents faa7dba + 5425c2c commit 083a739

4 files changed

Lines changed: 10 additions & 5 deletions

File tree

.github/workflows/release.yml

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -21,8 +21,8 @@ jobs:
2121
uses: ruby/setup-ruby@6aaa311d81eba98ae12eaffbcb63296ace0efcde # v1
2222
with:
2323
ruby-version: "3.4"
24-
bundler-cache: true
25-
- uses: actions/setup-node@a0853c24544627f65ddf259abe73b1d18a591444 # v5
24+
bundler-cache: false
25+
- uses: actions/setup-node@a0853c24544627f65ddf259abe73b1d18a591444 # v5 # zizmor: ignore[cache-poisoning]
2626
with:
2727
node-version: 24
2828
cache: "npm"
@@ -36,17 +36,18 @@ jobs:
3636
chmod 0600 $HOME/.gem/credentials
3737
env:
3838
RUBYGEMS_TOKEN: ${{ secrets.RUBYGEMS_TOKEN_SHARED }}
39-
- uses: actions/setup-node@48b55a011bda9f5d6aeb4c2d9c7362e8dae4041e # v6
39+
- uses: actions/setup-node@48b55a011bda9f5d6aeb4c2d9c7362e8dae4041e # v6 # zizmor: ignore[cache-poisoning]
4040
with:
4141
node-version: 24
4242
registry-url: 'https://registry.npmjs.org'
43+
cache: "npm"
4344
- name: NPM install
4445
run: |
4546
npm ci
4647
- name: Publish Gem
4748
run: bundle exec rake release
4849
- name: Publish NPM
49-
run: npm publish --access public
50+
run: npm publish --access public --provenance
5051

5152
release-main:
5253
name: Main
@@ -64,7 +65,7 @@ jobs:
6465
persist-credentials: false
6566

6667
- name: Set up Node.js
67-
uses: actions/setup-node@48b55a011bda9f5d6aeb4c2d9c7362e8dae4041e # v6
68+
uses: actions/setup-node@48b55a011bda9f5d6aeb4c2d9c7362e8dae4041e # v6 # zizmor: ignore[cache-poisoning]
6869
with:
6970
node-version: 24
7071
cache: "npm"
@@ -90,6 +91,8 @@ jobs:
9091
private-key: ${{ secrets.PRIMER_APP_PRIVATE_KEY_SHARED }}
9192
repositories: |
9293
primer_view_components
94+
permission-contents: write
95+
permission-pull-requests: write
9396

9497
- name: Create release pull request or publish to npm
9598
id: changesets

.github/workflows/static-files.yml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,9 +21,11 @@ jobs:
2121
private-key: ${{ secrets.PRIMER_APP_PRIVATE_KEY_SHARED }}
2222
owner: opf
2323
repositories: primer_view_components
24+
permission-contents: write
2425
- uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6
2526
with:
2627
token: ${{ steps.app-token.outputs.token }}
28+
persist-credentials: false
2729
- uses: ruby/setup-ruby@6aaa311d81eba98ae12eaffbcb63296ace0efcde # v1
2830
with:
2931
ruby-version: '3.4'
2 Bytes
Loading
0 Bytes
Loading

0 commit comments

Comments
 (0)