Merge pull request #130 from ErikEJ/dependabot/nuget/src/SqlClientExt… #241
ErikEJAnnotations
10 warnings
|
build:
src/SqlClientExtensions/SqlClientListener.cs#L38
Evaluation of this argument may be expensive and unnecessary if logging is disabled (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1873)
|
|
build:
src/SqlClientExtensions/SqlLoggingConfiguration.cs#L18
Call System.IDisposable.Dispose on object created by 'new SqlClientListener(loggerFactory, enableVerbose)' before all references to it are out of scope (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2000)
|
|
build:
src/SqlClientExtensions/SqlClientListener.cs#L6
Type 'SqlClientListener' can be sealed because it has no subtypes in its containing assembly and is not externally visible (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1852)
|
|
build:
src/SqlClientExtensions/SqlDataSource.cs#L93
Call System.IDisposable.Dispose on object created by 'OpenConnection()' before all references to it are out of scope (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2000)
|
|
build:
src/SqlClientExtensions/SqlDataSource.cs#L96
Review if the query string passed to 'string SqlCommand.CommandText' in 'CreateCommand', accepts any user input (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2100)
|
|
build:
src/SqlClientExtensions/SqlLoggingConfiguration.cs#L18
Call System.IDisposable.Dispose on object created by 'new SqlClientListener(loggerFactory, enableVerbose)' before all references to it are out of scope (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2000)
|
|
build:
src/SqlClientExtensions/SqlClientListener.cs#L38
The logging message template should not vary between calls to 'LoggerExtensions.Log(ILogger, LogLevel, string?, params object?[])' (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2254)
|
|
build:
src/SqlClientExtensions/SqlClientListener.cs#L38
For improved performance, use the LoggerMessage delegates instead of calling 'LoggerExtensions.Log(ILogger, LogLevel, string?, params object?[])' (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1848)
|
|
build:
src/SqlClientExtensions/SqlClientListener.cs#L38
Evaluation of this argument may be expensive and unnecessary if logging is disabled (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1873)
|
|
build:
src/SqlClientExtensions/SqlClientListener.cs#L38
Evaluation of this argument may be expensive and unnecessary if logging is disabled (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1873)
|
Artifacts
Produced during runtime
| Name | Size | Digest | |
|---|---|---|---|
|
artifact
|
37.1 KB |
sha256:cd446a6af16c75289c87d09ba043b5c8ed210566e215600409ea8babb64b38a6
|
|