Skip to content

Commit 0dfd1c4

Browse files
authored
Fix Ae parsing and improve grades tests (#272)
1 parent 4cf6b49 commit 0dfd1c4

File tree

2 files changed

+13
-3
lines changed

2 files changed

+13
-3
lines changed

src/main/kotlin/data/Grade.kt

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -31,9 +31,8 @@ enum class Grade {
3131
val name = value
3232
.uppercase()
3333
.replace("+", "_PLUS")
34-
.replace("E", "_EQUIPPED")
3534
.replace("º", "A")
36-
println("Looking for grade with name: $name")
35+
.replace("AE", "A_EQUIPPED")
3736
return Grade.entries.find { it.name.endsWith(name) } ?: UNKNOWN
3837
}
3938
}

src/test/kotlin/data/TestGrades.kt

Lines changed: 12 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ import kotlin.test.assertEquals
55

66
class TestGrades {
77
@Test
8-
fun `Test grade conversions`() {
8+
fun `test fromString text`() {
99
assertEquals(Grade.G4A, Grade.fromString(""))
1010
assertEquals(Grade.G5A, Grade.fromString(""))
1111
assertEquals(Grade.G5_PLUS, Grade.fromString("5+"))
@@ -17,4 +17,15 @@ class TestGrades {
1717
assertEquals(Grade.A_EQUIPPED, Grade.fromString("Ae"))
1818
assertEquals(Grade.UNKNOWN, Grade.fromString("¿?"))
1919
}
20+
21+
@Test
22+
fun `test fromString name`() {
23+
for (grade in Grade.entries) {
24+
assertEquals(
25+
grade,
26+
Grade.fromString(grade.name),
27+
"Conversion failed for name \"${grade.name}\" => $grade",
28+
)
29+
}
30+
}
2031
}

0 commit comments

Comments
 (0)