Merge pull request #695 from Esri/Fix-RevertUpdateLintingRules

[Update] Revert `[Update] Linter rules`

Author: CalebRas

.swiftlint.yml

@@ -21,8 +21,8 @@ disabled_rules:
   - file_length
   - for_where
   - force_cast
-  - force_try
   - line_length
+  - notification_center_detachment
   - type_body_length
   - type_name
 

Shared/Samples/Add vector tiled layer from custom style/AddVectorTiledLayerFromCustomStyleView.swift

@@ -183,6 +183,7 @@ private extension FileManager {
     /// Creates a temporary directory.
     /// - Returns: The URL of the created directory
     static func createTemporaryDirectory() -> URL {
+        // swiftlint:disable:next force_try
         try! FileManager.default.url(
             for: .itemReplacementDirectory,
             in: .userDomainMask,

Shared/Samples/Apply function to raster from service/ApplyFunctionToRasterFromServiceView.swift

@@ -29,7 +29,7 @@ struct ApplyFunctionToRasterFromServiceView: View {
                         url: URL(string: "https://sampleserver6.arcgisonline.com/arcgis/rest/services/NLCDLandCover2001/ImageServer")!
                     )
                     // Creates a raster function from a json string.
-                    let function = try! RasterFunction.fromJSON(rasterFunctionJSON)
+                    let function = try! RasterFunction.fromJSON(rasterFunctionJSON) // swiftlint:disable:this force_try
                     // Sets the arguments on the function.
                     function.arguments!.setRaster(
                         imageServiceRaster,

Shared/Samples/Apply scheduled updates to preplanned map area/ApplyScheduledUpdatesToPreplannedMapAreaView.swift

@@ -188,6 +188,7 @@ private extension FileManager {
     /// Creates a temporary directory.
     /// - Returns: The URL of the created directory.
     static func createTemporaryDirectory() -> URL {
+        // swiftlint:disable:next force_try
         try! FileManager.default.url(
             for: .itemReplacementDirectory,
             in: .userDomainMask,

Shared/Samples/Configure electronic navigational charts/ConfigureElectronicNavigationalChartsView.swift

@@ -256,6 +256,7 @@ private extension FileManager {
     /// Creates a temporary directory.
     /// - Returns: The URL of the created directory.
     static func createTemporaryDirectory() -> URL {
+        // swiftlint:disable:next force_try
         try! FileManager.default.url(
             for: .itemReplacementDirectory,
             in: .userDomainMask,

Shared/Samples/Create KML multi-track/CreateKMLMultiTrackView.Model.swift

@@ -141,6 +141,7 @@ private extension FileManager {
     /// Creates a temporary directory.
     /// - Returns: The URL of the created directory.
     static func createTemporaryDirectory() -> URL {
+        // swiftlint:disable:next force_try
         try! FileManager.default.url(
             for: .itemReplacementDirectory,
             in: .userDomainMask,

Shared/Samples/Create and edit geometries/CreateAndEditGeometriesView.swift

@@ -480,6 +480,7 @@ private class GeometryEditorModel: ObservableObject {
 }
 
 private extension Geometry {
+    // swiftlint:disable force_try
     static func house() -> Point {
         let json = Data(
             """
@@ -516,7 +517,7 @@ private extension Geometry {
                         [-1067889.49,6998483.56],[-1067880.98,6998527.26]]],
                     "spatialReference":{"latestWkid":3857,"wkid":102100}}
             """.utf8
-        )
+            )
         return try! Polyline.fromJSON(json)
     }
 
@@ -554,6 +555,7 @@ private extension Geometry {
         )
         return try! Polygon.fromJSON(json)
     }
+    // swiftlint:enable force_try
 }
 
 private extension Symbol {

Shared/Samples/Create and save KML file/CreateAndSaveKMLView.swift

@@ -121,6 +121,7 @@ extension CreateAndSaveKMLView {
 private extension FileManager {
     /// Creates a temporary directory and returns the URL of the created directory.
     static func createTemporaryDirectory() -> URL {
+        // swiftlint:disable:next force_try
         try! FileManager.default.url(
             for: .itemReplacementDirectory,
             in: .userDomainMask,

Shared/Samples/Download preplanned map area/DownloadPreplannedMapAreaView.Model.swift

@@ -310,6 +310,7 @@ private extension DownloadPreplannedMapAreaView.OfflineMapModel {
 private extension FileManager {
     /// Creates a temporary directory and returns the URL of the created directory.
     static func createTemporaryDirectory() -> URL {
+        // swiftlint:disable:next force_try
         try! FileManager.default.url(
             for: .itemReplacementDirectory,
             in: .userDomainMask,

Shared/Samples/Download vector tiles to local cache/DownloadVectorTilesToLocalCacheView.swift

@@ -294,6 +294,7 @@ private extension DownloadVectorTilesToLocalCacheView {
         /// Creates a temporary directory.
         /// - Returns: The URL to the temporary directory.
         private static func createTemporaryDirectory() -> URL {
+            // swiftlint:disable:next force_try
             try! FileManager.default.url(
                 for: .itemReplacementDirectory,
                 in: .userDomainMask,