SwiftLint not run with Swift package

[yo1995]

I spotted some linter warnings from the toolkit source files. I realized that with the Swift package manifest setup, it is different than an Xcode project file where we can place a shell script in its Build Phases. Is this already taken into consideration?

One of the linter warning example ⚠️ Closure Opening Space Violation: Use one space between the brace and bracket. (closure_opening_space)

arcgis-runtime-toolkit-ios/Sources/ArcGISToolkit/Compass.swift

Line 68 in de6ebdb

rotationObservation = mapView.observe(\.rotation, options: .new) {[weak self] (_, change) in

[mhdostal]

@yo1995 That's currently a known issue, because, as you noted, there are no longer "Build Phases" in which to run the linter. The recommendation is to run the linter by hand until we come up with an automated solution. I will add an item to our internal release process to run the linter and fix issues before a release. Thanks!

[yo1995]

Sounds good. It's worth keeping an eye on this proposal: realm/SwiftLint#3679 that comes with Swift 5.6 which might sorta address this issue.

[yo1995]

Today in Sate of the Union they introduced https://www.hackingwithswift.com/swift/5.6/swiftpm-plugins Swift Package Plugins.