[getLabelText] Add `labelText` as first fallback after `label`

[isaacbraun]

monday.com sync: #12613802737

Check existing issues

• I have checked for existing issues to avoid duplicates

Which Component

N/A

Description

Brought up in #14845 (comment), the getLabelText() utility should be enhanced to use labelText as the first fallback before looking for the textContent element.

Additionally, getting the labelEl.textContent element may no longer be needed now that labels are internal to the component. Unless we still want to fallback to external labels.

Existing:

export function getLabelText(component: LabelTextComponent): string {
  return component.label || component.labelEl?.textContent?.trim() || "";
}

Improved:

export function getLabelText(component: LabelTextComponent): string {
  return component.label || component.labelText || component.labelEl?.textContent?.trim() || "";
}

Acceptance Criteria

• getLabelText() looks for these values in the following order: label, labelText, labelEl (up for discussion).

Relevant Info

No response

Example Use Case

No response

Priority impact

impact - p3 - not time sensitive

Calcite package

• @esri/calcite-components
• @esri/calcite-components-react
• @esri/calcite-design-tokens
• @esri/calcite-ui-icons
• @esri/eslint-plugin-calcite-components

Esri team

Calcite (dev)