fix(network): follow 302 redirects in shared httpx client (#983)

Mikanime's mirror (and some CDN-fronted sources) respond with 302 to the
canonical host. httpx AsyncClient defaults to follow_redirects=False, so
raise_for_status surfaced the 302 as an HTTPStatusError and the RSS pull
failed in a retry loop.

Enable follow_redirects=True for every construction of the shared client
(proxy, socks5, and direct branches) via a shared kwargs dict.

Closes #983

Author: EstrellaXD

backend/src/module/network/request_url.py

@@ -36,30 +36,32 @@ async def get_shared_client() -> httpx.AsyncClient:
     if _shared_client is not None:
         await _shared_client.aclose()
     timeout = httpx.Timeout(connect=10.0, read=30.0, write=10.0, pool=10.0)
+    # follow_redirects=True: Mikan mirrors and some CDNs respond with 302 to the
+    # canonical host; without this, raise_for_status treats the redirect as an
+    # error and the RSS pull fails (#983).
+    common_kwargs = {
+        "timeout": timeout,
+        "limits": _CONNECTION_LIMITS,
+        "follow_redirects": True,
+    }
     if settings.proxy.enable:
         if "http" in settings.proxy.type:
             if settings.proxy.username:
                 proxy_url = f"http://{settings.proxy.username}:{settings.proxy.password}@{settings.proxy.host}:{settings.proxy.port}"
             else:
                 proxy_url = f"http://{settings.proxy.host}:{settings.proxy.port}"
-            _shared_client = httpx.AsyncClient(
-                proxy=proxy_url, timeout=timeout, limits=_CONNECTION_LIMITS
-            )
+            _shared_client = httpx.AsyncClient(proxy=proxy_url, **common_kwargs)
         elif settings.proxy.type == "socks5":
             if settings.proxy.username:
                 socks_url = f"socks5://{settings.proxy.username}:{settings.proxy.password}@{settings.proxy.host}:{settings.proxy.port}"
             else:
                 socks_url = f"socks5://{settings.proxy.host}:{settings.proxy.port}"
             transport = AsyncProxyTransport.from_url(socks_url, rdns=True)
-            _shared_client = httpx.AsyncClient(
-                transport=transport, timeout=timeout, limits=_CONNECTION_LIMITS
-            )
+            _shared_client = httpx.AsyncClient(transport=transport, **common_kwargs)
         else:
-            _shared_client = httpx.AsyncClient(
-                timeout=timeout, limits=_CONNECTION_LIMITS
-            )
+            _shared_client = httpx.AsyncClient(**common_kwargs)
     else:
-        _shared_client = httpx.AsyncClient(timeout=timeout, limits=_CONNECTION_LIMITS)
+        _shared_client = httpx.AsyncClient(**common_kwargs)
     _shared_client_proxy_key = current_key
     return _shared_client
 
@@ -91,7 +93,9 @@ def _get_headers(self, url: str) -> dict:
         }
         # For torrent files, use different Accept header
         if url.endswith(".torrent") or "/download/" in url:
-            base_headers["Accept"] = "application/x-bittorrent, application/octet-stream, */*"
+            base_headers["Accept"] = (
+                "application/x-bittorrent, application/octet-stream, */*"
+            )
         else:
             base_headers["Accept"] = "application/xml, text/xml, */*"
         return base_headers
@@ -102,7 +106,11 @@ async def get_url(self, url, retry=3):
         while True:
             try:
                 req = await self._client.get(url=url, headers=headers)
-                logger.debug("[Network] Successfully connected to %s. Status: %s", url, req.status_code)
+                logger.debug(
+                    "[Network] Successfully connected to %s. Status: %s",
+                    url,
+                    req.status_code,
+                )
                 req.raise_for_status()
                 return req
             except httpx.HTTPStatusError as e:
@@ -122,16 +130,16 @@ async def get_url(self, url, retry=3):
             except Exception as e:
                 logger.warning(f"[Network] Unexpected error for {url}: {e}")
                 break
-        logger.error(f"[Network] Unable to connect to {url}, Please check your network settings")
+        logger.error(
+            f"[Network] Unable to connect to {url}, Please check your network settings"
+        )
         return None
 
     async def post_url(self, url: str, data: dict, retry=3):
         try_time = 0
         while True:
             try:
-                req = await self._client.post(
-                    url=url, headers=self.header, data=data
-                )
+                req = await self._client.post(url=url, headers=self.header, data=data)
                 req.raise_for_status()
                 return req
             except httpx.RequestError:

backend/src/test/test_request_url.py

@@ -33,6 +33,12 @@ async def test_client_has_max_connections(self):
         assert pool._max_connections is not None
         assert pool._max_connections > 0
 
+    async def test_client_follows_redirects(self):
+        """Regression for #983: mikanime mirror returns 302 to the canonical
+        URL but httpx refuses to follow by default, so the RSS fetch fails."""
+        client = await get_shared_client()
+        assert client.follow_redirects is True
+
 
 class TestResetSharedClient:
     async def test_reset_closes_existing_client(self):