Skip to content

Commit b8f3bfe

Browse files
committed
fix(ci): fix CI/CD workflow bugs for 3.2.0 release
- Upgrade actions/upload-artifact and download-artifact from v3 to v4 (v3 is deprecated and no longer functional) - Upgrade Docker actions: setup-qemu v2→v3, setup-buildx v2→v3, metadata v4→v5, login v2→v3, build-push v4→v6 - Upgrade softprops/action-gh-release from v1 to v2 - Fix shell quoting bugs: unquoted ${{ github.ref }} and ${{ github.event.pull_request.merged }} in bash conditions - Remove `tree` command from release job (not installed on ubuntu-latest)
1 parent 0408ecd commit b8f3bfe

1 file changed

Lines changed: 20 additions & 20 deletions

File tree

.github/workflows/build.yml

Lines changed: 20 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -69,20 +69,20 @@ jobs:
6969
id: release
7070
run: |
7171
if [[ '${{ github.event_name }}' == 'pull_request' && '${{ github.event.pull_request.head.ref }}' == *'dev'* ]]; then
72-
if [ ${{ github.event.pull_request.merged }} == true ]; then
72+
if [ '${{ github.event.pull_request.merged }}' == 'true' ]; then
7373
echo "release=1" >> $GITHUB_OUTPUT
7474
else
7575
echo "release=0" >> $GITHUB_OUTPUT
7676
fi
77-
elif [[ '${{ github.event_name }}' == 'push' && (${{ github.ref }} == *'alpha'* || ${{ github.ref }} == *'beta'*) ]]; then
77+
elif [[ '${{ github.event_name }}' == 'push' && ('${{ github.ref }}' == *'alpha'* || '${{ github.ref }}' == *'beta'*) ]]; then
7878
echo "release=1" >> $GITHUB_OUTPUT
7979
else
8080
echo "release=0" >> $GITHUB_OUTPUT
8181
fi
8282
- name: If dev
8383
id: dev
8484
run: |
85-
if [[ '${{ github.event_name }}' == 'push' && (${{ github.ref }} == *'alpha'* || ${{ github.ref }} == *'beta'*) ]]; then
85+
if [[ '${{ github.event_name }}' == 'push' && ('${{ github.ref }}' == *'alpha'* || '${{ github.ref }}' == *'beta'*) ]]; then
8686
echo "dev=1" >> $GITHUB_OUTPUT
8787
else
8888
echo "dev=0" >> $GITHUB_OUTPUT
@@ -91,10 +91,10 @@ jobs:
9191
id: version
9292
run: |
9393
if [ '${{ github.event_name }}' == 'pull_request' ]; then
94-
if [ ${{ github.event.pull_request.merged }} == true ]; then
94+
if [ '${{ github.event.pull_request.merged }}' == 'true' ]; then
9595
echo "version=${{ github.event.pull_request.title }}" >> $GITHUB_OUTPUT
9696
fi
97-
elif [[ ${{ github.event_name }} == 'push' && (${{ github.ref }} == *'alpha'* || ${{ github.ref }} == *'beta'*) ]]; then
97+
elif [[ '${{ github.event_name }}' == 'push' && ('${{ github.ref }}' == *'alpha'* || '${{ github.ref }}' == *'beta'*) ]]; then
9898
echo "version=${{ github.ref_name }}" >> $GITHUB_OUTPUT
9999
else
100100
echo "version=Test" >> $GITHUB_OUTPUT
@@ -149,7 +149,7 @@ jobs:
149149
cd webui && pnpm build
150150
151151
- name: Upload artifact
152-
uses: actions/upload-artifact@v3
152+
uses: actions/upload-artifact@v4
153153
with:
154154
name: dist
155155
path: webui/dist
@@ -168,16 +168,16 @@ jobs:
168168
echo "VERSION='${{ needs.version-info.outputs.version }}'" >> module/__version__.py
169169
170170
- name: Set up QEMU
171-
uses: docker/setup-qemu-action@v2
171+
uses: docker/setup-qemu-action@v3
172172

173173
- name: Set up Docker Buildx
174174
id: buildx
175-
uses: docker/setup-buildx-action@v2
175+
uses: docker/setup-buildx-action@v3
176176

177177
- name: Docker metadata main
178178
if: ${{ needs.version-info.outputs.release == 1 && needs.version-info.outputs.dev != 1 }}
179179
id: meta
180-
uses: docker/metadata-action@v4
180+
uses: docker/metadata-action@v5
181181
with:
182182
images: |
183183
estrellaxd/auto_bangumi
@@ -189,7 +189,7 @@ jobs:
189189
- name: Docker metadata dev
190190
if: ${{ needs.version-info.outputs.dev == 1 }}
191191
id: meta-dev
192-
uses: docker/metadata-action@v4
192+
uses: docker/metadata-action@v5
193193
with:
194194
images: |
195195
estrellaxd/auto_bangumi
@@ -200,28 +200,28 @@ jobs:
200200
201201
- name: Login to DockerHub
202202
if: ${{ needs.version-info.outputs.release == 1 }}
203-
uses: docker/login-action@v2
203+
uses: docker/login-action@v3
204204
with:
205205
username: ${{ secrets.DOCKER_HUB_USERNAME }}
206206
password: ${{ secrets.DOCKER_HUB_ACCESS_TOKEN }}
207207

208208
- name: Login to ghcr.io
209209
if: ${{ needs.version-info.outputs.release == 1 }}
210-
uses: docker/login-action@v2
210+
uses: docker/login-action@v3
211211
with:
212212
registry: ghcr.io
213213
username: ${{ github.actor }}
214214
password: ${{ secrets.ACCESS_TOKEN }}
215215

216216
- name: Download artifact
217-
uses: actions/download-artifact@v3
217+
uses: actions/download-artifact@v4
218218
with:
219219
name: dist
220220
path: backend/src/dist
221221

222222
- name: Build and push
223223
if: ${{ needs.version-info.outputs.release == 1 && needs.version-info.outputs.dev != 1 }}
224-
uses: docker/build-push-action@v4
224+
uses: docker/build-push-action@v6
225225
with:
226226
context: .
227227
builder: ${{ steps.buildx.output.name }}
@@ -234,7 +234,7 @@ jobs:
234234

235235
- name: Build and push dev
236236
if: ${{ needs.version-info.outputs.dev == 1 }}
237-
uses: docker/build-push-action@v4
237+
uses: docker/build-push-action@v6
238238
with:
239239
context: .
240240
builder: ${{ steps.buildx.output.name }}
@@ -247,7 +247,7 @@ jobs:
247247

248248
- name: Build test
249249
if: ${{ needs.version-info.outputs.release == 0 }}
250-
uses: docker/build-push-action@v4
250+
uses: docker/build-push-action@v6
251251
with:
252252
context: .
253253
builder: ${{ steps.buildx.output.name }}
@@ -269,17 +269,17 @@ jobs:
269269
uses: actions/checkout@v4
270270

271271
- name: Download artifact webui
272-
uses: actions/download-artifact@v3
272+
uses: actions/download-artifact@v4
273273
with:
274274
name: dist
275275
path: webui/dist
276276

277277
- name: Zip webui
278278
run: |
279-
cd webui && ls -al && tree && zip -r dist.zip dist
279+
cd webui && ls -al && zip -r dist.zip dist
280280
281281
- name: Download artifact app
282-
uses: actions/download-artifact@v3
282+
uses: actions/download-artifact@v4
283283
with:
284284
name: dist
285285
path: backend/src/dist
@@ -307,7 +307,7 @@ jobs:
307307
308308
- name: Release
309309
id: release
310-
uses: softprops/action-gh-release@v1
310+
uses: softprops/action-gh-release@v2
311311
with:
312312
tag_name: ${{ needs.version-info.outputs.version }}
313313
name: ${{ steps.release-info.outputs.version }}

0 commit comments

Comments
 (0)