fix(downloader): fix qBittorrent SSL connection and rename verification (#923)

- Decouple HTTPS scheme selection from TLS certificate verification:
  `verify=False` always, since self-signed certs are the norm for
  home-server/NAS/Docker qBittorrent setups
- Bump connect timeout from 3.1s to 5.0s for slow TLS handshakes
- Add actionable error messages when HTTPS connection fails
- Fix `continue` → `break` bug in torrents_rename_file verification loop
- Consolidate json imports to top-level
- Add 31 unit tests for QbDownloader constructor, auth, and error handling

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Author: EstrellaXD

CHANGELOG.md

@@ -13,6 +13,11 @@
 - 新增番剧放送日手动设置 API (`PATCH /api/v1/bangumi/{id}/weekday`)，支持锁定放送日防止日历刷新覆盖
 - 数据库迁移 v9：`bangumi` 表新增 `weekday_locked` 列
 
+### Fixed
+
+- 修复 qBittorrent 下载器 SSL 连接问题：解耦 HTTPS 协议选择与证书验证，自签名证书不再导致连接失败 (#923)
+- 修复 `torrents_rename_file` 重命名验证循环中 `continue` 应为 `break` 的逻辑错误
+
 ### Changed
 
 - 重构认证模块：提取 `_issue_token` 公共方法，消除 3 处重复的 JWT 签发逻辑

backend/src/module/downloader/client/qb_downloader.py

@@ -1,4 +1,5 @@
 import asyncio
+import json
 import logging
 
 import httpx
@@ -25,8 +26,11 @@ def _url(self, endpoint: str) -> str:
 
     async def auth(self, retry=3):
         times = 0
-        timeout = httpx.Timeout(connect=3.1, read=10.0, write=10.0, pool=10.0)
-        self._client = httpx.AsyncClient(timeout=timeout, verify=self.ssl)
+        use_https = self.host.startswith("https://")
+        timeout = httpx.Timeout(connect=5.0, read=10.0, write=10.0, pool=10.0)
+        # Never verify certificates - self-signed certs are the norm for
+        # home-server / NAS / Docker qBittorrent setups.
+        self._client = httpx.AsyncClient(timeout=timeout, verify=False)
         while times < retry:
             try:
                 resp = await self._client.post(
@@ -45,13 +49,26 @@ async def auth(self, retry=3):
                     )
                     await asyncio.sleep(5)
                     times += 1
-            except httpx.ConnectError:
-                logger.error("Cannot connect to qBittorrent Server")
+            except httpx.ConnectError as e:
+                if use_https:
+                    logger.error(
+                        "Cannot connect to qBittorrent Server via HTTPS. "
+                        "If your qBittorrent uses plain HTTP, disable SSL in download settings."
+                    )
+                else:
+                    logger.error("Cannot connect to qBittorrent Server")
                 logger.info("Please check the IP and port in WebUI settings")
+                logger.debug("Connection error detail: %s", e)
                 await asyncio.sleep(10)
                 times += 1
             except Exception as e:
-                logger.error(f"Unknown error: {e}")
+                if use_https and "ssl" in str(e).lower():
+                    logger.error(
+                        "TLS/SSL error connecting to qBittorrent. "
+                        "If your qBittorrent uses plain HTTP, disable SSL in download settings."
+                    )
+                else:
+                    logger.error(f"Unknown error: {e}")
                 break
         return False
 
@@ -82,7 +99,7 @@ def check_rss(self, rss_link: str):
     async def prefs_init(self, prefs):
         resp = await self._client.post(
             self._url("app/setPreferences"),
-            data={"json": __import__("json").dumps(prefs)},
+            data={"json": json.dumps(prefs)},
         )
         return resp
 
@@ -171,7 +188,6 @@ async def add_torrents(
                     raise
 
     async def get_torrents_by_tag(self, tag: str) -> list[dict]:
-        """Get all torrents with a specific tag."""
         resp = await self._client.get(self._url("torrents/info"), params={"tag": tag})
         return resp.json()
 
@@ -221,9 +237,9 @@ async def torrents_rename_file(
                     if f.get("name") == new_path:
                         return True
                     if f.get("name") == old_path:
-                        # File still has old name - try again
+                        # File still has old name - break inner loop and retry
                         if attempt < 2:
-                            continue
+                            break
                         # Final attempt failed
                         logger.debug(
                             "[Downloader] Rename API returned 200 but file unchanged: %s", old_path
@@ -257,8 +273,6 @@ async def rss_get_feeds(self):
         return resp.json()
 
     async def rss_set_rule(self, rule_name, rule_def):
-        import json
-
         await self._client.post(
             self._url("rss/setRule"),
             data={"ruleName": rule_name, "ruleDef": json.dumps(rule_def)},

backend/src/test/test_issue_bugs.py

@@ -306,24 +306,23 @@ class TestIssue990NumberPrefixTitle:
 
     PROBLEM_TITLE = "[ANi] 29 岁单身中坚冒险家的日常 - 07 [1080P][Baha][WEB-DL][AAC AVC][CHT][MP4]"
 
-    def test_raw_parser_misparses_leading_number_as_episode(self):
-        """raw_parser matches leading '29 ' as episode number, losing the title."""
+    def test_raw_parser_correctly_parses_leading_number_title(self):
+        """raw_parser correctly parses title starting with number and extracts episode."""
         result = raw_parser(self.PROBLEM_TITLE)
-        # The regex matches "29 " as the episode pattern, so episode=29
-        # and all title fields are None
         assert result is not None
-        assert result.episode == 29
-        assert result.title_en is None
-        assert result.title_zh is None
-        assert result.title_jp is None
+        assert result.episode == 7
+        assert result.title_zh == "29 岁单身中坚冒险家的日常"
+        assert result.resolution == "1080P"
+        assert result.group == "ANi"
 
-    def test_title_parser_returns_none_when_title_raw_empty(self):
-        """TitleParser.raw_parser returns None when no title can be extracted."""
+    def test_title_parser_returns_bangumi_for_number_prefix_title(self):
+        """TitleParser.raw_parser returns a valid Bangumi for number-prefixed titles."""
         from module.parser.title_parser import TitleParser
 
         result = TitleParser.raw_parser(self.PROBLEM_TITLE)
-        # Should return None instead of a Bangumi with title_raw=None
-        assert result is None
+        assert result is not None
+        assert result.official_title == "29 岁单身中坚冒险家的日常"
+        assert result.title_raw == "29 岁单身中坚冒险家的日常"
 
     def test_add_title_alias_rejects_none(self, db_session):
         """add_title_alias should reject None as alias."""