Merge pull request #81 from EtaCassiopeia/feat/batch-add-hooks

Add batch addHooks method to FeatureFlags

Author: EtaCassiopeia

core/src/main/scala/zio/openfeature/FeatureFlags.scala

@@ -155,6 +155,7 @@ trait FeatureFlags {
   def on(eventType: ProviderEventType, handler: ProviderEvent => UIO[Unit]): UIO[UIO[Unit]]
 
   def addHook(hook: FeatureHook): UIO[Unit]
+  def addHooks(hooks: List[FeatureHook]): UIO[Unit]
   def clearHooks: UIO[Unit]
   def hooks: UIO[List[FeatureHook]]
 
@@ -347,6 +348,9 @@ object FeatureFlags {
   def addHook(hook: FeatureHook): ZIO[FeatureFlags, Nothing, Unit] =
     ZIO.serviceWithZIO(_.addHook(hook))
 
+  def addHooks(hooks: List[FeatureHook]): ZIO[FeatureFlags, Nothing, Unit] =
+    ZIO.serviceWithZIO(_.addHooks(hooks))
+
   def clearHooks: ZIO[FeatureFlags, Nothing, Unit] =
     ZIO.serviceWithZIO(_.clearHooks)
 

core/src/main/scala/zio/openfeature/FeatureFlagsLive.scala

@@ -658,6 +658,9 @@ final private[openfeature] class FeatureFlagsLive(
   override def addHook(hook: FeatureHook): UIO[Unit] =
     state.hooksRef.update(_ :+ hook)
 
+  override def addHooks(hooks: List[FeatureHook]): UIO[Unit] =
+    state.hooksRef.update(_ ++ hooks)
+
   override def clearHooks: UIO[Unit] =
     state.hooksRef.set(List.empty)
 

docs/hooks.md

@@ -226,9 +226,8 @@ FeatureFlags.addHook(combined)
 Hooks are executed in the order they were added:
 
 ```scala
-FeatureFlags.addHook(loggingHook)   // Runs first in before
-FeatureFlags.addHook(metricsHook)   // Runs second in before
-FeatureFlags.addHook(validatorHook) // Runs third in before
+// Hooks run in registration order (first added = first to run in `before`)
+FeatureFlags.addHooks(List(loggingHook, metricsHook, validatorHook))
 ```
 
 For the `before` stage, hooks run in order. For `after`, `error`, and `finallyAfter`, they run in reverse order.
@@ -261,6 +260,9 @@ Client-level hooks apply to a specific FeatureFlags instance:
 // Add a single hook at runtime
 FeatureFlags.addHook(myHook)
 
+// Add multiple hooks atomically
+FeatureFlags.addHooks(List(loggingHook, metricsHook, validatorHook))
+
 // Create layer with initial hooks
 val hooks = List(
   FeatureHook.logging(),
@@ -444,11 +446,7 @@ override def after[A](...): UIO[Unit] =
 Consider hook order for dependencies:
 
 ```scala
-// Validation should run first
-FeatureFlags.addHook(validatorHook)
-// Then enrichment
-FeatureFlags.addHook(enrichmentHook)
-// Then logging/metrics
-FeatureFlags.addHook(loggingHook)
+// Order matters: validation → enrichment → logging
+FeatureFlags.addHooks(List(validatorHook, enrichmentHook, loggingHook))
 ```
 

docs/spec-compliance.md

@@ -124,7 +124,7 @@ FeatureFlags.booleanDetails("flag", false, context, options)
 | Hook hints | ✅ | `HookHints` for passing data between stages |
 | Hook data (4.6.1) | ✅ | `HookData` per-hook mutable state across stages |
 | API-level hooks | ✅ | `FeatureFlags.addApiHook` / `clearApiHooks` |
-| Client-level hooks | ✅ | `FeatureFlags.addHook` / `clearHooks` |
+| Client-level hooks | ✅ | `FeatureFlags.addHook` / `addHooks` / `clearHooks` |
 | Invocation-level hooks | ✅ | Via `EvaluationOptions` |
 | Provider-level hooks | ✅ | Automatically included from `provider.getProviderHooks()` |
 | Execution order | ✅ | API → Client → Invocation → Provider (reversed for after/error/finally) |

testkit/src/test/scala/zio/openfeature/testkit/FeatureFlagsSpec.scala

@@ -237,6 +237,13 @@ object FeatureFlagsSpec extends ZIOSpecDefault {
         } yield assertTrue(initial.isEmpty) &&
           assertTrue(after.length == 1)
       }.provide(testLayer()),
+      test("addHooks adds multiple hooks atomically") {
+        val hooks = List(FeatureHook.noop, FeatureHook.noop, FeatureHook.noop)
+        for {
+          _     <- FeatureFlags.addHooks(hooks)
+          after <- FeatureFlags.hooks
+        } yield assertTrue(after.length == 3)
+      }.provide(testLayer()),
       test("clearHooks removes all hooks") {
         val hook = FeatureHook.noop
         for {