Follow Gemini review and fix build

Author: imDMK

eternalcombat-plugin/src/main/java/com/eternalcode/combat/CombatPlugin.java

@@ -20,6 +20,9 @@
 import com.eternalcode.combat.fight.controller.FightBypassCreativeController;
 import com.eternalcode.combat.fight.controller.FightBypassPermissionController;
 import com.eternalcode.combat.fight.controller.FightInventoryController;
+import com.eternalcode.combat.fight.controller.FightMessageController;
+import com.eternalcode.combat.fight.controller.FightTagController;
+import com.eternalcode.combat.fight.controller.FightUnTagController;
 import com.eternalcode.combat.fight.death.DeathFlareController;
 import com.eternalcode.combat.fight.death.DeathLightningController;
 import com.eternalcode.combat.fight.drop.DropKeepInventoryService;
@@ -190,7 +193,7 @@ public void onEnable() {
             new FightBypassPermissionController(server, pluginConfig),
             new FightBypassCreativeController(server, pluginConfig),
             new FightActionBlockerController(this.fightManager, noticeService, pluginConfig, server),
-            new FightPearlController(pluginConfig.pearl, noticeService, this.fightManager, this.fightPearlService),
+            new FightPearlController(pluginConfig, noticeService, this.fightManager, this.fightPearlService),
             new DeathFlareController(pluginConfig, server, scheduler, this),
             new DeathLightningController(pluginConfig, server),
             new UpdaterNotificationController(updaterService, pluginConfig, this.audienceProvider, miniMessage),

eternalcombat-plugin/src/main/java/com/eternalcode/combat/time/DurationFormatter.java

@@ -90,12 +90,18 @@ public String format(Duration duration) {
     private static Token[] parsePattern(String pattern) {
         List<Token> tokens = new ArrayList<>(DurationUnit.values().length);
 
-        for (int i = 0; i < pattern.length(); i++) {
+        int i = 0;
+
+        while (i < pattern.length()) {
             if (pattern.charAt(i) != '%') {
+                i++;
                 continue;
             }
 
-            int start = ++i;
+            i++; // skip %
+
+            int start = i;
+
             while (i < pattern.length() && Character.isLetter(pattern.charAt(i))) {
                 i++;
             }
@@ -115,17 +121,27 @@ private static Token[] parsePattern(String pattern) {
                 i++;
             }
 
-            if (pattern.charAt(i) != '{') {
+            if (i >= pattern.length() || pattern.charAt(i) != '{') {
                 throw new IllegalArgumentException("Missing plural definition");
             }
 
-            int blockStart = ++i;
-            while (pattern.charAt(i) != '}') {
+            i++; // skip {
+
+            int blockStart = i;
+
+            while (i < pattern.length() && pattern.charAt(i) != '}') {
                 i++;
             }
 
+            if (i >= pattern.length()) {
+                throw new IllegalArgumentException("Unclosed plural definition");
+            }
+
             String block = pattern.substring(blockStart, i);
+            i++; // skip }
+
             int split = block.indexOf('|');
+
             if (split == -1) {
                 throw new IllegalArgumentException("Plural must be singular|plural");
             }