* Added AdvancementCommand in examples:bukkit to demonstrate advancements via PacketEvents.

* Replaced `AdvancementType` with `AdvancementFrameType` for improved clarity across modules.
* Updated `AdvancementResolver` to use `AdvancementFrameType` and streamlined icon/background parsing.
* Adjusted `build.gradle.kts` with updated repository and dependency configurations for PacketEvents.
* Incremented Minecraft version in server tasks to `1.21.8`.

Author: P1otrulla

examples/bukkit/build.gradle.kts

@@ -1,5 +1,3 @@
-import gradle.kotlin.dsl.accessors._729aa7c1588b83738f7ec34c0a320432.api
-
 plugins {
     id("java")
     id("com.gradleup.shadow") version "9.0.0-beta4"
@@ -13,6 +11,7 @@ repositories {
     mavenCentral()
     maven("https://repo.panda-lang.org/releases/")
     maven("https://hub.spigotmc.org/nexus/content/repositories/snapshots/")
+    maven("https://repo.codemc.io/repository/maven-releases/") // packetevents
     maven("https://repo.stellardrift.ca/repository/snapshots/")
 }
 
@@ -29,7 +28,7 @@ dependencies {
     implementation(project(":multification-cdn"))
     implementation(project(":multification-packetevents"))
 
-    api("com.github.retrooper:packetevents-spigot:${Versions.PACKETEVENTS}")
+    compileOnly("com.github.retrooper:packetevents-spigot:${Versions.PACKETEVENTS}")
 }
 
 val pluginName = "ExamplePlugin"
@@ -61,5 +60,9 @@ sourceSets.test {
 }
 
 tasks.runServer {
-    minecraftVersion("1.21.4")
+    minecraftVersion("1.21.8")
+
+    downloadPlugins {
+        downloadPlugins.url("https://cdn.modrinth.com/data/HYKaKraK/versions/Kee6pozk/packetevents-spigot-2.9.5.jar")
+    }
 }

examples/bukkit/src/main/java/com/eternalcode/example/bukkit/ExamplePlugin.java

@@ -1,5 +1,6 @@
 package com.eternalcode.example.bukkit;
 
+import com.eternalcode.example.bukkit.command.AdvancementCommand;
 import com.eternalcode.example.bukkit.command.GiveCommand;
 import com.eternalcode.example.bukkit.command.ReloadCommand;
 import com.eternalcode.example.bukkit.command.TeleportCommand;
@@ -41,6 +42,7 @@ public void onEnable() {
                 new FlyCommand(multification),
                 new GiveCommand(multification),
                 new ReloadCommand(configurationManager, multification),
+                new AdvancementCommand(multification, this),
                 new TimerCommand(new TimerManager(this.getServer().getScheduler(), this, multification))
             )
             .build();

examples/bukkit/src/main/java/com/eternalcode/example/bukkit/command/AdvancementCommand.java

@@ -1,23 +1,29 @@
 package com.eternalcode.example.bukkit.command;
 
 import com.eternalcode.example.bukkit.multification.YourMultification;
+import com.eternalcode.multification.notice.Notice;
 import com.eternalcode.multification.packetevents.notice.PacketEventsNotice;
+import com.eternalcode.multification.packetevents.notice.resolver.AdvancementFrameType;
 import dev.rollczi.litecommands.annotations.command.Command;
 import dev.rollczi.litecommands.annotations.context.Context;
 import dev.rollczi.litecommands.annotations.execute.Execute;
 import dev.rollczi.litecommands.annotations.permission.Permission;
+import org.bukkit.Bukkit;
 import org.bukkit.entity.Player;
 
 import java.time.Duration;
+import org.bukkit.plugin.Plugin;
 
 @Command(name = "testadvancements")
 @Permission("example.testadvancements")
 public class AdvancementCommand {
 
     private final YourMultification multification;
+    private final Plugin plugin;
 
-    public AdvancementCommand(YourMultification multification) {
+    public AdvancementCommand(YourMultification multification, Plugin plugin) {
         this.multification = multification;
+        this.plugin = plugin;
     }
 
     @Execute(name = "simple")
@@ -39,7 +45,7 @@ void executeChallenge(@Context Player player) {
                         "<dark_purple>Epic Challenge",
                         "Hold down Left Button",
                         "DIAMOND_SWORD",
-                        AdvancementType.CHALLENGE,
+                        AdvancementFrameType.CHALLENGE,
                         Duration.ofSeconds(5)
                 ))
                 .send();
@@ -53,7 +59,7 @@ void executeGoal(@Context Player player) {
                         "<gold>Reach the Goal",
                         "Destroy the tree",
                         "OAK_SAPLING",
-                        AdvancementType.GOAL,
+                        AdvancementFrameType.GOAL,
                         "minecraft:textures/gui/advancements/backgrounds/stone.png"
                 ))
                 .send();
@@ -68,7 +74,7 @@ void executeCustom(@Context Player player) {
                                 "<red>Custom Toast",
                                 "<gray>With all options configured",
                                 "GOLD_INGOT",
-                                AdvancementType.TASK,
+                                AdvancementFrameType.TASK,
                                 "minecraft:textures/gui/advancements/backgrounds/adventure.png",
                                 true,  // showToast
                                 true,  // hidden
@@ -84,7 +90,7 @@ void executeCustom(@Context Player player) {
     void executeTranslated(@Context Player player) {
         this.multification.create()
                 .viewer(player)
-                .notice(messages -> messages.welcomeAdvancement)
+                .notice(Notice.chat("<green>Hello, {player}! This is a translated message."))
                 .placeholder("{player}", player.getName())
                 .send();
     }
@@ -99,28 +105,27 @@ void executeAll(@Context Player player) {
                         "<yellow>Wait for it...",
                         "More coming soon!",
                         "CLOCK",
-                        AdvancementType.TASK,
+                        AdvancementFrameType.TASK,
                         Duration.ofSeconds(2)
                 ))
                 .send();
 
-        // Schedule next ones
-        org.bukkit.Bukkit.getScheduler().runTaskLater(
-                org.bukkit.Bukkit.getPluginManager().getPlugin("ExamplePlugin"),
+        Bukkit.getScheduler().runTaskLater(
+                this.plugin,
                 () -> executeChallenge(player),
-                40L // 2 seconds
+                40L
         );
 
-        org.bukkit.Bukkit.getScheduler().runTaskLater(
-                org.bukkit.Bukkit.getPluginManager().getPlugin("ExamplePlugin"),
+        Bukkit.getScheduler().runTaskLater(
+                this.plugin,
                 () -> executeGoal(player),
                 80L
         );
 
-        org.bukkit.Bukkit.getScheduler().runTaskLater(
-                org.bukkit.Bukkit.getPluginManager().getPlugin("ExamplePlugin"),
+        Bukkit.getScheduler().runTaskLater(
+                this.plugin,
                 () -> executeCustom(player),
-                120L // 6 seconds
+                120L
         );
     }
 }

multification-packetevents/src/com/eternalcode/multification/packetevents/notice/PacketEventsNotice.java

@@ -2,8 +2,8 @@
 
 import com.eternalcode.multification.notice.Notice;
 import com.eternalcode.multification.packetevents.notice.resolver.AdvancementContent;
+import com.eternalcode.multification.packetevents.notice.resolver.AdvancementFrameType;
 import com.eternalcode.multification.packetevents.notice.resolver.PacketEventsNoticeKey;
-import com.github.retrooper.packetevents.protocol.advancements.AdvancementType;
 
 import java.time.Duration;
 
@@ -21,19 +21,19 @@ public static Notice advancement(String title, String description, String icon)
                 .build();
     }
 
-    public static Notice advancement(String title, String description, String icon, AdvancementType frameType) {
+    public static Notice advancement(String title, String description, String icon, AdvancementFrameType frameType) {
         return PacketEventsNotice.builder()
                 .advancement(title, description, icon, frameType)
                 .build();
     }
 
-    public static Notice advancement(String title, String description, String icon, AdvancementType frameType, String background) {
+    public static Notice advancement(String title, String description, String icon, AdvancementFrameType frameType, String background) {
         return PacketEventsNotice.builder()
                 .advancement(title, description, icon, frameType, background)
                 .build();
     }
 
-    public static Notice advancement(String title, String description, String icon, AdvancementType frameType, Duration showTime) {
+    public static Notice advancement(String title, String description, String icon, AdvancementFrameType frameType, Duration showTime) {
         return PacketEventsNotice.builder()
                 .advancement(title, description, icon, frameType, showTime)
                 .build();
@@ -53,23 +53,23 @@ public Builder advancement(String title, String description, String icon) {
             return this.advancement(title, description, icon, null, null, true, true, 0.0f, 0.0f, null);
         }
 
-        public Builder advancement(String title, String description, String icon, AdvancementType frameType) {
+        public Builder advancement(String title, String description, String icon, AdvancementFrameType frameType) {
             return this.advancement(title, description, icon, frameType, null, true, true, 0.0f, 0.0f, null);
         }
 
-        public Builder advancement(String title, String description, String icon, AdvancementType frameType, String background) {
+        public Builder advancement(String title, String description, String icon, AdvancementFrameType frameType, String background) {
             return this.advancement(title, description, icon, frameType, background, true, true, 0.0f, 0.0f, null);
         }
 
-        public Builder advancement(String title, String description, String icon, AdvancementType frameType, Duration showTime) {
+        public Builder advancement(String title, String description, String icon, AdvancementFrameType frameType, Duration showTime) {
             return this.advancement(title, description, icon, frameType, null, true, true, 0.0f, 0.0f, showTime);
         }
 
         public Builder advancement(
                 String title,
                 String description,
                 String icon,
-                AdvancementType frameType,
+                AdvancementFrameType frameType,
                 String background,
                 boolean showToast,
                 boolean hidden,

multification-packetevents/src/com/eternalcode/multification/packetevents/notice/resolver/AdvancementFrameType.java

@@ -1,9 +1,15 @@
 package com.eternalcode.multification.packetevents.notice.resolver;
 
+import com.github.retrooper.packetevents.protocol.advancements.AdvancementType;
+
 public enum AdvancementFrameType {
 
     TASK,
     CHALLENGE,
     GOAL;
+
+    public AdvancementType toPacketEventsType() {
+        return AdvancementType.valueOf(this.name());
+    }
 }
 

multification-packetevents/src/com/eternalcode/multification/packetevents/notice/resolver/AdvancementResolver.java

@@ -8,14 +8,12 @@
 import com.github.retrooper.packetevents.protocol.advancements.AdvancementDisplay;
 import com.github.retrooper.packetevents.protocol.advancements.AdvancementHolder;
 import com.github.retrooper.packetevents.protocol.advancements.AdvancementProgress;
-import com.github.retrooper.packetevents.protocol.advancements.AdvancementType;
 import com.github.retrooper.packetevents.protocol.item.ItemStack;
 import com.github.retrooper.packetevents.protocol.item.type.ItemType;
 import com.github.retrooper.packetevents.protocol.item.type.ItemTypes;
 import com.github.retrooper.packetevents.protocol.player.User;
 import com.github.retrooper.packetevents.resources.ResourceLocation;
 import com.github.retrooper.packetevents.wrapper.play.server.WrapperPlayServerUpdateAdvancements;
-import java.time.Duration;
 import net.kyori.adventure.audience.Audience;
 import net.kyori.adventure.key.Key;
 import net.kyori.adventure.text.Component;
@@ -26,7 +24,16 @@
 import org.jetbrains.annotations.NotNull;
 import org.jetbrains.annotations.Nullable;
 
-import java.util.*;
+import java.time.Duration;
+import java.util.ArrayList;
+import java.util.Collections;
+import java.util.HashMap;
+import java.util.HashSet;
+import java.util.List;
+import java.util.Map;
+import java.util.Optional;
+import java.util.Set;
+import java.util.UUID;
 import java.util.function.UnaryOperator;
 
 public class AdvancementResolver implements TextContentResolver<AdvancementContent> {
@@ -64,14 +71,13 @@ public void send(Audience audience, ComponentSerializer<Component, Component, St
         Component descComponent = serializer.deserialize(content.description());
 
         ItemStack icon = this.createIcon(content.iconOrDefault());
-
         ResourceLocation background = this.parseBackground(content.background());
 
         AdvancementDisplay display = new AdvancementDisplay(
                 titleComponent,
                 descComponent,
                 icon,
-                content.frameTypeOrDefault(),
+                content.frameTypeOrDefault().toPacketEventsType(),
                 background,
                 content.showToast(),
                 content.hidden(),
@@ -160,8 +166,8 @@ public Optional<AdvancementContent> deserialize(NoticeSerdesResult result) {
             String title = parts[0];
             String description = parts[1];
             String icon = parts.length > 2 && !parts[2].isEmpty() ? parts[2] : null;
-            AdvancementType frameType = parts.length > 3 && !parts[3].isEmpty()
-                    ? AdvancementType.valueOf(parts[3])
+            AdvancementFrameType frameType = parts.length > 3 && !parts[3].isEmpty()
+                    ? AdvancementFrameType.valueOf(parts[3])
                     : null;
             String background = parts.length > 4 && !parts[4].isEmpty() ? parts[4] : null;
             boolean showToast = parts.length > 5 ? Boolean.parseBoolean(parts[5]) : AdvancementContent.DEFAULT_SHOW_TOAST;
@@ -205,13 +211,6 @@ public AdvancementContent applyText(AdvancementContent content, UnaryOperator<St
         );
     }
 
-    /**
-     * Creates an ItemStack icon from material name string.
-     * Falls back to GRASS_BLOCK if material is invalid.
-     *
-     * @param materialName the material name (e.g., "OAK_SAPLING", "DIAMOND")
-     * @return ItemStack with the specified material type
-     */
     private ItemStack createIcon(@NotNull String materialName) {
         try {
             ItemType materialType = ItemTypes.getByName(materialName);
@@ -232,25 +231,14 @@ private ItemStack createIcon(@NotNull String materialName) {
         }
     }
 
-    /**
-     * Parses ResourceLocation from string format "namespace:path".
-     * Examples:
-     * - "minecraft:textures/gui/advancements/backgrounds/stone.png"
-     * - "mypack:custom/background.png"
-     *
-     * @param backgroundString the background string in format "namespace:path"
-     * @return ResourceLocation or null if string is null/invalid
-     */
     private ResourceLocation parseBackground(@Nullable String backgroundString) {
         if (backgroundString == null || backgroundString.isEmpty()) {
             return null;
         }
 
-        // Split by colon to get namespace and path
         String[] parts = backgroundString.split(":", 2);
 
         if (parts.length != 2) {
-            // Invalid format, default to minecraft namespace
             return new ResourceLocation("minecraft", backgroundString);
         }