Merge pull request #392 from Hahfyeex/fix/issues-206-212-223-225

fix: resolve issues #206, #212, #223, #225

Author: Mystery-CLI

backend/src/config/assets.js

@@ -9,16 +9,19 @@ const ASSETS = {
   },
 };
 
-const isTestnet = process.env.STELLAR_NETWORK === 'testnet';
-const network = isTestnet ? 'testnet' : 'mainnet';
+import { getConfig } from './env.js';
 
 /**
  * Returns the issuer public key for a supported non-native asset.
  * Falls back to ASSET_ISSUER env var for custom assets.
  */
 export function getIssuer(assetCode) {
-  return ASSETS[network][assetCode] ?? process.env.ASSET_ISSUER ?? null;
+  const network = getConfig().stellar.network;
+  return ASSETS[network]?.[assetCode] ?? process.env.ASSET_ISSUER ?? null;
 }
 
 /** Returns the list of supported asset codes (including XLM). */
-export const SUPPORTED_ASSETS = ['XLM', ...Object.keys(ASSETS[network])];
+export function getSupportedAssets() {
+  const network = getConfig().stellar.network;
+  return ['XLM', ...Object.keys(ASSETS[network] ?? {})];
+}

backend/src/services/stellar.js

@@ -26,9 +26,10 @@ export function wrapWithFeeBump(innerTx, feeAccountSecret) {
     ? StellarSDK.Networks.TESTNET
     : StellarSDK.Networks.PUBLIC;
 
+  const multiplier = parseInt(process.env.FEE_BUMP_MULTIPLIER ?? '10', 10);
   const feeBumpTx = StellarSDK.TransactionBuilder.buildFeeBumpTransaction(
     feeKeypair,
-    StellarSDK.BASE_FEE * 10, // fee bump pays 10x base fee
+    StellarSDK.BASE_FEE * multiplier,
     innerTx,
     networkPassphrase
   );
@@ -161,15 +162,14 @@ export async function sendPayment(sourceSecret, destination, amount, assetCode =
       });
       // Track stats for cost monitoring
       feeBumpStats.total += 1;
-      feeBumpStats.totalFeeStroops += StellarSDK.BASE_FEE * 10;
+      feeBumpStats.totalFeeStroops += StellarSDK.BASE_FEE * parseInt(process.env.FEE_BUMP_MULTIPLIER ?? '10', 10);
       feeBumpStats.accounts.add(sourcePublicKey);
     }
   }
 
   let result;
   try {
     result = await getHorizonServer().submitTransaction(txToSubmit);
-    result = await getHorizonServer().submitTransaction(transaction);
   } catch (err) {
     logger.error('stellar.sendPayment.failed', { source: sourcePublicKey, destination, amount, assetCode, error: err.message });
     throw err;

frontend/src/App.jsx

@@ -41,7 +41,6 @@ function App() {
   const [recipient, setRecipient] = useState('');
   const [amount, setAmount] = useState('');
   const [memo, setMemo] = useState('');
-  const [loading, setLoading] = useState('');
   const [showQR, setShowQR] = useState(false);
   const [showShortcuts, setShowShortcuts] = useState(false);
   const [showImportForm, setShowImportForm] = useState(false);