Skip to content

Commit 45c2c21

Browse files
committed
Remove entry level from indices in DelayLineDetector and AdqRawChannel
1 parent 501f73a commit 45c2c21

5 files changed

Lines changed: 10 additions & 12 deletions

File tree

docs/changelog.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,8 @@ Changed:
2222
instead of zeros as a fill value for runs with a varying number of pulses
2323
(!347).
2424
- [imshow2()][extra.utils.imshow2] will now add a colorbar automatically (!351).
25+
- [DelayLineDetector][extra.components.DelayLineDetector] now longer attaches an index level for each row in [hits()][extra.components.DelayLineDetector.hits] and [signals()][extra.components.DelayLineDetector.signals] (!362).
26+
- [AdqRawChannel][extra.components.AdqRawChannel] now longer attaches an index level for each row in [train_edges()][extra.components.AdqRawChannel.train_edges] and [pulse_edges()][extra.components.AdqRawChannel.pulse_edges] (!362).
2527

2628
## [2025.1]
2729

src/extra/components/adq.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -447,9 +447,9 @@ def _shape_edges(self, edges, amplitudes, index):
447447
from . import DelayLineDetector
448448

449449
edges = DelayLineDetector._build_reduced_pd(
450-
None, edges, index, entry_level='edgeIndex')
450+
None, edges, index)
451451
amplitudes = DelayLineDetector._build_reduced_pd(
452-
None, amplitudes, index, entry_level='edgeIndex')
452+
None, amplitudes, index)
453453

454454
return pd.DataFrame({'edge': edges, 'amplitude': amplitudes})
455455

src/extra/components/dld.py

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -235,8 +235,7 @@ def insert_aligned_columns(df, columns):
235235
if shared_index[:2] == df.index.names[:2]:
236236
# Same pulse dimensions as the dataframe.
237237
if num_per_pulse is None:
238-
num_per_pulse = df.groupby(
239-
level=df.index.names[:-1]).size()
238+
num_per_pulse = df.groupby(level=df.index.names).size()
240239

241240
align = num_per_pulse
242241

@@ -392,8 +391,7 @@ def signals(self, pulse_dim='pulseId', extra_columns={}, max_method=None):
392391

393392
df = self._build_reduced_pd(
394393
(kd := self._instrument_src['rec.signals']).ndarray(),
395-
self._align_pulse_index(kd, pulse_dim), 'signalIndex',
396-
mask_func)
394+
self._align_pulse_index(kd, pulse_dim), None, mask_func)
397395

398396
if extra_columns:
399397
self.insert_aligned_columns(df, extra_columns)
@@ -433,8 +431,7 @@ def hits(self, pulse_dim='pulseId', extra_columns={}, max_method=None):
433431

434432
df = self._build_reduced_pd(
435433
(kd := self._instrument_src['rec.hits']).ndarray(),
436-
self._align_pulse_index(kd, pulse_dim), 'hitIndex',
437-
mask_func)
434+
self._align_pulse_index(kd, pulse_dim), None, mask_func)
438435

439436
if extra_columns:
440437
self.insert_aligned_columns(df, extra_columns)

tests/test_components_adq.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -277,7 +277,7 @@ def test_train_edges(mock_sqs_remi_run):
277277

278278
assert isinstance(df, pd.DataFrame)
279279
np.testing.assert_array_equal(df.columns, ['edge', 'amplitude'])
280-
np.testing.assert_array_equal(df.index.names, ['trainId', 'edgeIndex'])
280+
np.testing.assert_array_equal(df.index.name, 'trainId')
281281
assert len(df) == 100
282282

283283
np.testing.assert_allclose(df['edge'], 8944.0)
@@ -311,7 +311,7 @@ def test_pulse_edges(mock_sqs_remi_run):
311311
assert isinstance(df, pd.DataFrame)
312312
np.testing.assert_array_equal(df.columns, ['edge', 'amplitude'])
313313
np.testing.assert_array_equal(
314-
df.index.names, ['trainId', 'pulseId', 'edgeIndex'])
314+
df.index.names, ['trainId', 'pulseId'])
315315
assert len(df) == 40
316316

317317
np.testing.assert_array_equal(

tests/test_components_dld.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -70,8 +70,7 @@ def test_dld_df(mock_sqs_remi_run, key, pulse_dim):
7070
df = getattr(dld, f'{key}s')(pulse_dim)
7171

7272
assert (df.columns == list(dtype.names)).all()
73-
assert df.index.names == [
74-
'trainId', pulse_dim, 'fel', 'ppl', f'{key}Index']
73+
assert df.index.names == ['trainId', pulse_dim, 'fel', 'ppl']
7574

7675
# Check counts per pulse, should be a repeating pattern of 1-4.
7776
np.testing.assert_equal(

0 commit comments

Comments
 (0)