refactor GetLocalPaths

Author: lxymahatma

src/Euterpe.Core/Extensions/StorageItemExtensions.cs

@@ -4,6 +4,6 @@ namespace Euterpe.Core.Extensions;
 
 public static class StorageItemExtensions
 {
-    public static IEnumerable<string?> GetLocalPaths(this IReadOnlyList<IStorageItem> items) =>
-        items.Select(item => item.TryGetLocalPath());
+    public static IEnumerable<string> GetLocalPaths(this IReadOnlyList<IStorageItem> items) =>
+        items.Select(item => item.TryGetLocalPath()).OfType<string>();
 }

src/Euterpe.Core/Services/FileSystemPickerService.cs

@@ -51,7 +51,7 @@ public async Task<IReadOnlyList<string>> GetMultipleFolderPathsAsync(string dial
                 Title = dialogTitle
             }).ConfigureAwait(true);
 
-        return folders.GetLocalPaths().OfType<string>().ToArray();
+        return folders.GetLocalPaths().ToArray();
     }
 
     public async Task<IStorageFile?> GetSingleFileAsync(string dialogTitle)
@@ -101,6 +101,6 @@ public async Task<IReadOnlyList<string>> GetMultipleFilePathsAsync(string dialog
                 FileTypeFilter = fileTypes ?? [new FilePickerFileType(FilePickerFileType_AllFiles) { Patterns = ["*.*"] }]
             }).ConfigureAwait(true);
 
-        return files.GetLocalPaths().OfType<string>().ToArray();
+        return files.GetLocalPaths().ToArray();
     }
 }

src/Euterpe/Features/Charting/ChartManagePanelViewModel.Import.cs

@@ -30,7 +30,7 @@ private async Task MigrateCustomAlbumsAsync()
     [RelayCommand]
     private async Task ImportChartsAsync(IReadOnlyList<IStorageItem> files)
     {
-        var paths = files.GetLocalPaths().OfType<string>().ToArray();
+        var paths = files.GetLocalPaths().ToArray();
         if (paths is [])
         {
             return;

src/Euterpe/Features/Modding/ModManagePanelViewModel.cs

@@ -83,7 +83,7 @@ private Task OpenConfigFileAsync()
     [RelayCommand]
     private async Task ImportModsAsync(IReadOnlyList<IStorageItem> files)
     {
-        var paths = files.GetLocalPaths().OfType<string>().ToArray();
+        var paths = files.GetLocalPaths().ToArray();
         if (paths is [])
         {
             return;