Skip to content

Conversation

@Tohrusky
Copy link
Member

@Tohrusky Tohrusky commented Nov 9, 2024

Summary by Sourcery

Add support for DAT models and update core binary download URLs to the latest release version.

New Features:

  • Add support for multiple DAT model options in the ModelOptions.ts file.

Enhancements:

  • Update download URLs for macOS and Windows core binaries to a new release version in download-core.js.

@sourcery-ai
Copy link

sourcery-ai bot commented Nov 9, 2024

Reviewer's Guide by Sourcery

This PR adds support for DAT (Dual Aggregation Transformer) models by adding new model options and updating the core download URLs. The implementation involves adding various DAT model configurations with different scaling factors and variants (standard, light, and APISR GAN) to the model options list, and updating the core binary download links to a newer release.

Class diagram for updated ModelOptions

classDiagram
    class ModelOptions {
        +String label
        +String value
    }

    ModelOptions : +DAT_S_2x
    ModelOptions : +DAT_S_3x
    ModelOptions : +DAT_S_4x
    ModelOptions : +DAT_2x
    ModelOptions : +DAT_3x
    ModelOptions : +DAT_4x
    ModelOptions : +DAT_2_2x
    ModelOptions : +DAT_2_3x
    ModelOptions : +DAT_2_4x
    ModelOptions : +DAT_light_2x
    ModelOptions : +DAT_light_3x
    ModelOptions : +DAT_light_4x
    ModelOptions : +DAT_APISR_GAN_generator_4x
    note for ModelOptions "New DAT model options added"
Loading

File-Level Changes

Change Details Files
Added DAT model options with various configurations
  • Added standard DAT models with 2x, 3x, and 4x scaling factors
  • Added DAT_S (small) variants with 2x, 3x, and 4x scaling factors
  • Added DAT_2 variants with 2x, 3x, and 4x scaling factors
  • Added light variants with 2x, 3x, and 4x scaling factors
  • Added DAT APISR GAN generator model with 4x scaling
src/renderer/src/utils/ModelOptions.ts
Updated core binary download URLs
  • Updated download URLs from 2024-11-08 to 2024-11-09 release
  • Updated URLs for macos-arm64, macos-x64, and windows-x64 platforms
resources/download-core.js

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Tohrusky - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@Tohrusky Tohrusky merged commit bb91a8b into EutropicAI:main Nov 9, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant