Skip to content

Commit 6e85a15

Browse files
authored
fix: replace KeyError with warning for duplicate registration (#7)
1 parent 80fefa4 commit 6e85a15

File tree

1 file changed

+6
-4
lines changed

1 file changed

+6
-4
lines changed

cccv/util/registry.py

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,5 @@
11
# Copyright (c) Facebook, Inc. and its affiliates. All Rights Reserved
2-
3-
# pyre-strict
4-
# pyre-ignore-all-errors[2,3]
2+
import warnings
53
from typing import Any, Dict, Iterable, Iterator, Optional, Tuple
64

75

@@ -41,7 +39,11 @@ def __init__(self, name: str) -> None:
4139

4240
def _do_register(self, name: str, obj: Any) -> None:
4341
if name in self._obj_map:
44-
raise KeyError(f"[CCCV] An object named '{name}' was already registered in '{self._name}' registry!")
42+
warnings.warn(
43+
f"[CCCV] An object named '{name}' was already registered in '{self._name}' registry! We will NOT overwrite the existing one.",
44+
UserWarning,
45+
stacklevel=2,
46+
)
4547
else:
4648
self._obj_map[name] = obj
4749

0 commit comments

Comments
 (0)