fix tets

Author: colin-ho

daft/expressions/expressions.py

@@ -1457,7 +1457,7 @@ def is_in(self, other: Any) -> Expression:
             other = [Expression._to_expression(item) for item in other]
         elif not isinstance(other, Expression):
             series = item_to_series("items", other)
-            other = Expression._from_pyexpr(_series_lit(series._series))
+            other = [Expression._from_pyexpr(_series_lit(series._series))]
         else:
             other = [other]
 

tests/expressions/test_expressions.py

@@ -11,7 +11,6 @@
 from daft.expressions import col, lit
 from daft.expressions.testing import expr_structurally_equal
 from daft.recordbatch import MicroPartition
-from daft.series import Series
 
 
 @pytest.mark.parametrize(
@@ -25,7 +24,6 @@
         (b"a", DataType.binary()),
         (True, DataType.bool()),
         (None, DataType.null()),
-        (Series.from_pylist([1, 2, 3]), DataType.int64()),
         (date(2023, 1, 1), DataType.date()),
         (time(1, 2, 3, 4), DataType.time(timeunit=TimeUnit.from_str("us"))),
         (datetime(2023, 1, 1), DataType.timestamp(timeunit=TimeUnit.from_str("us"))),
@@ -638,12 +636,6 @@ def test_duration_lit(input, expected) -> None:
     assert output == expected
 
 
-def test_repr_series_lit() -> None:
-    s = lit(Series.from_pylist([1, 2, 3]))
-    output = repr(s)
-    assert output == "lit([1, 2, 3])"
-
-
 def test_list_value_counts():
     # Create a MicroPartition with a list column
     mp = MicroPartition.from_pydict(

tests/expressions/test_null_safe_equals.py

@@ -338,33 +338,6 @@ def test_left_nulls_all_types(type_name, left_data, right_data, expected_values)
     assert result_values == expected_values, f"Failed for {type_name} comparison"
 
 
-@pytest.mark.parametrize(
-    "type_name,left_data,right_data",
-    [
-        ("int", [1, 2, 3], [1, 2]),
-        ("float", [1.0, 2.0, 3.0], [1.0, 2.0]),
-        ("boolean", [True, False, True], [True, False]),
-        ("string", ["a", "b", "c"], ["a", "b"]),
-        ("binary", [b"a", b"b", b"c"], [b"a", b"b"]),
-        ("fixed_size_binary", [b"aaa", b"bbb", b"ccc"], [b"aaa", b"bbb"]),
-    ],
-)
-def test_length_mismatch_all_types(type_name, left_data, right_data):
-    """Test that length mismatches raise appropriate error for all data types."""
-    # Create two separate tables
-    left_table = MicroPartition.from_pydict({"value": left_data})
-    right_table = MicroPartition.from_pydict({"value": right_data})
-
-    with pytest.raises(ValueError) as exc_info:
-        result = left_table.eval_expression_list([col("value").eq_null_safe(right_table.get_column_by_name("value"))])
-        # Force evaluation by accessing the result
-        result.get_column_by_name("value").to_pylist()
-
-    # Verify error message format
-    error_msg = str(exc_info.value)
-    assert "trying to compare different length arrays" in error_msg
-
-
 @pytest.mark.parametrize(
     "type_name,left_data,right_data,expected_values",
     [

tests/expressions/typing/test_float.py

@@ -36,7 +36,7 @@ def test_fill_nan(binary_data_fixture):
     lhs, rhs = binary_data_fixture
     assert_typing_resolve_vs_runtime_behavior(
         data=binary_data_fixture,
-        expr=col(lhs.name()).float.fill_nan(rhs),
+        expr=col(lhs.name()).float.fill_nan(col(rhs.name())),
         run_kernel=lambda: lhs.float.fill_nan(rhs),
         resolvable=(
             lhs.datatype() in (DataType.float32(), DataType.float64())