Commit 31868b8
committed
fix(ce-product-pulse): close schema gap and tighten config-driven prose
Addresses functional gaps and copy nits surfaced in a trace-through of
both first-run and subsequent-run flows.
Schema gap:
- Add pulse_pending_metrics and pulse_excluded_metrics CSV keys to
config-template.yaml and the rendered example. The interview promised
these dispositions for un-instrumented strategy metrics, but the prior
flat YAML had no slot for them. Matches the pulse_completion_events
CSV pattern.
- Update references/interview.md section 6.0 to write to those keys.
- Update references/report-template.md to honor both keys when rendering
strategy metrics.
Config-driven prose tightening:
- Phase 2.2: stale "see interview config" reference replaced with the
precise key check (pulse_quality_scoring is true).
- Phase 1.0: product-name extraction guidance now specifies stripping
the trailing " Strategy" suffix from the H1 title; seed message
rewritten as a directive to the agent rather than a literal-template
string.
Issue 1 (CWD vs repo-root for docs/ paths) was checked against repo
precedent and intentionally NOT changed: ce-brainstorm, ce-plan, and
ce-compound all use bare relative docs/ paths and rely on
target-announcement for cross-repo cases. ce-strategy and
ce-product-pulse already announce, so the existing pattern holds.1 parent 0ef57af commit 31868b8
5 files changed
Lines changed: 20 additions & 9 deletions
File tree
- .compound-engineering
- plugins/compound-engineering/skills
- ce-product-pulse
- references
- ce-setup/references
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
26 | 26 | | |
27 | 27 | | |
28 | 28 | | |
| 29 | + | |
| 30 | + | |
Lines changed: 7 additions & 5 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
70 | 70 | | |
71 | 71 | | |
72 | 72 | | |
| 73 | + | |
| 74 | + | |
73 | 75 | | |
74 | 76 | | |
75 | 77 | | |
| |||
84 | 86 | | |
85 | 87 | | |
86 | 88 | | |
87 | | - | |
88 | | - | |
| 89 | + | |
| 90 | + | |
89 | 91 | | |
90 | | - | |
| 92 | + | |
91 | 93 | | |
92 | | - | |
| 94 | + | |
93 | 95 | | |
94 | 96 | | |
95 | 97 | | |
| |||
132 | 134 | | |
133 | 135 | | |
134 | 136 | | |
135 | | - | |
| 137 | + | |
136 | 138 | | |
137 | 139 | | |
138 | 140 | | |
| |||
Lines changed: 5 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
126 | 126 | | |
127 | 127 | | |
128 | 128 | | |
129 | | - | |
130 | | - | |
| 129 | + | |
| 130 | + | |
131 | 131 | | |
132 | | - | |
| 132 | + | |
133 | 133 | | |
134 | 134 | | |
135 | 135 | | |
| |||
242 | 242 | | |
243 | 243 | | |
244 | 244 | | |
| 245 | + | |
| 246 | + | |
245 | 247 | | |
246 | 248 | | |
247 | 249 | | |
| |||
Lines changed: 4 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
9 | 9 | | |
10 | 10 | | |
11 | 11 | | |
12 | | - | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
13 | 16 | | |
14 | 17 | | |
15 | 18 | | |
| |||
Lines changed: 2 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
26 | 26 | | |
27 | 27 | | |
28 | 28 | | |
| 29 | + | |
| 30 | + | |
0 commit comments