Skip to content

Commit 150d8be

Browse files
authored
Merge pull request #221 from Evilazaro:feature/userGroupAllProjects
role assingment
2 parents 652b095 + fc30d24 commit 150d8be

File tree

1 file changed

+21
-21
lines changed

1 file changed

+21
-21
lines changed

src/workload/project/project.bicep

Lines changed: 21 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -96,43 +96,43 @@ resource project 'Microsoft.DevCenter/projects@2025-04-01-preview' = {
9696
}
9797

9898
@description('Configure project identity role assignments')
99-
module projectIdentityUG '../../identity/projectIdentityRoleAssignment.bicep' = [
99+
module projectIdentity '../../identity/projectIdentityRoleAssignment.bicep' = [
100100
for (role, i) in identity.roleAssignments: {
101-
name: 'prj-rbac-UG-${i}-${uniqueString(project.id, role.azureADGroupId)}'
102-
scope: resourceGroup()
101+
name: 'prj-rbac${i}-${uniqueString(project.id, project.name)}'
102+
scope: resourceGroup(securityResourceGroupName)
103103
params: {
104104
projectName: project.name
105-
principalId: role.azureADGroupId
105+
principalId: project.identity.principalId
106106
roles: role.azureRBACRoles
107-
principalType: 'Group'
107+
principalType: 'ServicePrincipal'
108108
}
109109
}
110110
]
111111

112112
@description('Configure project identity role assignments')
113-
module projectIdentityUGRG '../../identity/projectIdentityRoleAssignmentRG.bicep' = [
113+
module projectIdentityRG '../../identity/projectIdentityRoleAssignmentRG.bicep' = [
114114
for (role, i) in identity.roleAssignments: {
115-
name: 'prj-rbac-UGRG-${i}-${uniqueString(project.id, role.azureADGroupId)}'
115+
name: 'prj-rbac-RG-${i}-${uniqueString(project.id, project.name)}'
116116
scope: resourceGroup(securityResourceGroupName)
117117
params: {
118118
projectName: project.name
119-
principalId: role.azureADGroupId
119+
principalId: project.identity.principalId
120120
roles: role.azureRBACRoles
121-
principalType: 'Group'
121+
principalType: 'ServicePrincipal'
122122
}
123123
}
124124
]
125125

126-
@description('Configure project identity role assignments')
127-
module projectIdentity '../../identity/projectIdentityRoleAssignmentRG.bicep' = [
126+
@description('Add the AD Group to the DevCenter project')
127+
module projectADGroup '../../identity/projectIdentityRoleAssignment.bicep' = [
128128
for (role, i) in identity.roleAssignments: {
129-
name: 'prj-rbac-RG-${i}-${uniqueString(project.id, role.azureADGroupId)}'
130-
scope: resourceGroup(securityResourceGroupName)
129+
name: 'prj-adgroup-${i}-${uniqueString(project.id, project.name)}'
130+
scope: resourceGroup()
131131
params: {
132132
projectName: project.name
133-
principalId: project.identity.principalId
133+
principalId: role.azureADGroupId
134+
principalType: 'Group'
134135
roles: role.azureRBACRoles
135-
principalType: 'ServicePrincipal'
136136
}
137137
}
138138
]
@@ -147,9 +147,9 @@ module catalogs 'projectCatalog.bicep' = {
147147
secretIdentifier: secretIdentifier
148148
}
149149
dependsOn: [
150-
projectIdentityUG
151-
projectIdentityUGRG
152150
projectIdentity
151+
projectIdentityRG
152+
projectADGroup
153153
]
154154
}
155155

@@ -163,9 +163,9 @@ module environmentTypes 'projectEnvironmentType.bicep' = [
163163
environmentConfig: envType
164164
}
165165
dependsOn: [
166-
projectIdentityUG
167-
projectIdentityUGRG
168166
projectIdentity
167+
projectIdentityRG
168+
projectADGroup
169169
catalogs
170170
]
171171
}
@@ -182,9 +182,9 @@ module connectivity '../../connectivity/connectivity.bicep' = {
182182
location: resourceGroup().location
183183
}
184184
dependsOn: [
185-
projectIdentityUG
186-
projectIdentityUGRG
187185
projectIdentity
186+
projectIdentityRG
187+
projectADGroup
188188
catalogs
189189
]
190190
}

0 commit comments

Comments
 (0)