Refactoring Bicep to acces new Azure APIs

Evilazaro · Evilazaro · commit e5e7fea0ffd8 · 2024-11-27T10:07:16.000-03:00
diff --git a/src/deploy/bicep/devBox/devCenter/configureDevCenterCatalogs.bicep b/src/deploy/bicep/devBox/devCenter/configureDevCenterCatalogs.bicep
@@ -16,5 +16,6 @@ resource projectCatalog 'Microsoft.DevCenter/devcenters/catalogs@2024-10-01-prev
       branch: catalogInfo.branch
       path: catalogInfo.path
     }
+    syncType: 'Scheduled'
   }
 }
diff --git a/src/deploy/bicep/devBox/devCenter/configureDevCenterEnvironments.bicep b/src/deploy/bicep/devBox/devCenter/configureDevCenterEnvironments.bicep
@@ -8,6 +8,9 @@ resource deployDevCenter 'Microsoft.DevCenter/devcenters@2024-10-01-preview' exi
 resource devCenterDevEnvironment 'Microsoft.DevCenter/devcenters/environmentTypes@2024-10-01-preview' = {
   parent: deployDevCenter
   name: 'Development'
+  properties: {
+    displayName: 'Development'
+  }
 }
 
 output devCenterDevEnvironmentId string = devCenterDevEnvironment.id
@@ -17,6 +20,9 @@ output devCenterDevEnvironmentName string = devCenterDevEnvironment.name
 resource devCenterStagingEnvironment 'Microsoft.DevCenter/devcenters/environmentTypes@2024-10-01-preview' = {
   parent: deployDevCenter
   name: 'Staging'
+  properties: {
+    displayName: 'Staging'
+  }
 }
 
 output devCenterStagingEnvironmentId string = devCenterStagingEnvironment.id
diff --git a/src/deploy/bicep/devBox/devCenter/createDevCenterProjects.bicep b/src/deploy/bicep/devBox/devCenter/createDevCenterProjects.bicep
@@ -22,6 +22,7 @@ resource project 'Microsoft.DevCenter/projects@2024-10-01-preview' = {
     catalogSettings: {
       catalogItemSyncTypes: [
         'EnvironmentDefinition'
+        'ImageDefinition'
       ]
     }
   }
@@ -54,8 +55,14 @@ resource backEndPool 'Microsoft.DevCenter/projects/pools@2024-10-01-preview' = {
     networkConnectionName: networkConnectionName
     stopOnDisconnect: {
       gracePeriodMinutes: 60
-      status: 'Disabled'
+      status: 'Enabled'
     }
+    stopOnNoConnect: {
+      gracePeriodMinutes: 60
+      status: 'Enabled'
+    }
+    singleSignOnStatus: 'Enabled'
+    virtualNetworkType: 'Unmanaged'
   }
 }
 
@@ -71,7 +78,13 @@ resource frontEndPool 'Microsoft.DevCenter/projects/pools@2024-10-01-preview' =
     networkConnectionName: networkConnectionName
     stopOnDisconnect: {
       gracePeriodMinutes: 60
-      status: 'Disabled'
+      status: 'Enabled'
+    }
+    stopOnNoConnect: {
+      gracePeriodMinutes: 60
+      status: 'Enabled'
     }
+    singleSignOnStatus: 'Enabled'
+    virtualNetworkType: 'Unmanaged'
   }
 }
diff --git a/src/deploy/bicep/identity/deployCustomRole.bicep b/src/deploy/bicep/identity/deployCustomRole.bicep
@@ -23,6 +23,7 @@ resource deployCustomRole 'Microsoft.Authorization/roleDefinitions@2022-05-01-pr
         notDataActions: []
       }
     ]
+    type: 'CustomRole'
   }
 }
 
diff --git a/src/deploy/bicep/network/virtualNetwork/virtualNetwork.bicep b/src/deploy/bicep/network/virtualNetwork/virtualNetwork.bicep
@@ -18,6 +18,9 @@ resource virtualNetwork 'Microsoft.Network/virtualNetworks@2024-03-01' = {
     addressSpace: {
       addressPrefixes: addressPrefix
     }
+    encryption: {
+      enabled: true
+    }
   }
   tags: tags
 }

Original file line number	Diff line number	Diff line change
`@@ -16,5 +16,6 @@ resource projectCatalog 'Microsoft.DevCenter/devcenters/catalogs@2024-10-01-prev`
`16`	`16`	`branch: catalogInfo.branch`
`17`	`17`	`path: catalogInfo.path`
`18`	`18`	`}`
	`19`	`+ syncType: 'Scheduled'`
`19`	`20`	`}`
`20`	`21`	`}`
Original file line number	Diff line number	Diff line change
`@@ -22,6 +22,7 @@ resource project 'Microsoft.DevCenter/projects@2024-10-01-preview' = {`
`22`	`22`	`catalogSettings: {`
`23`	`23`	`catalogItemSyncTypes: [`
`24`	`24`	`'EnvironmentDefinition'`
	`25`	`+ 'ImageDefinition'`
`25`	`26`	`]`
`26`	`27`	`}`
`27`	`28`	`}`
`@@ -54,8 +55,14 @@ resource backEndPool 'Microsoft.DevCenter/projects/pools@2024-10-01-preview' = {`
`54`	`55`	`networkConnectionName: networkConnectionName`
`55`	`56`	`stopOnDisconnect: {`
`56`	`57`	`gracePeriodMinutes: 60`
`57`		`- status: 'Disabled'`
	`58`	`+ status: 'Enabled'`
`58`	`59`	`}`
	`60`	`+ stopOnNoConnect: {`
	`61`	`+ gracePeriodMinutes: 60`
	`62`	`+ status: 'Enabled'`
	`63`	`+ }`
	`64`	`+ singleSignOnStatus: 'Enabled'`
	`65`	`+ virtualNetworkType: 'Unmanaged'`
`59`	`66`	`}`
`60`	`67`	`}`
`61`	`68`
`@@ -71,7 +78,13 @@ resource frontEndPool 'Microsoft.DevCenter/projects/pools@2024-10-01-preview' =`
`71`	`78`	`networkConnectionName: networkConnectionName`
`72`	`79`	`stopOnDisconnect: {`
`73`	`80`	`gracePeriodMinutes: 60`
`74`		`- status: 'Disabled'`
	`81`	`+ status: 'Enabled'`
	`82`	`+ }`
	`83`	`+ stopOnNoConnect: {`
	`84`	`+ gracePeriodMinutes: 60`
	`85`	`+ status: 'Enabled'`
`75`	`86`	`}`
	`87`	`+ singleSignOnStatus: 'Enabled'`
	`88`	`+ virtualNetworkType: 'Unmanaged'`
`76`	`89`	`}`
`77`	`90`	`}`
Original file line number	Diff line number	Diff line change
`@@ -23,6 +23,7 @@ resource deployCustomRole 'Microsoft.Authorization/roleDefinitions@2022-05-01-pr`
`23`	`23`	`notDataActions: []`
`24`	`24`	`}`
`25`	`25`	`]`
	`26`	`+ type: 'CustomRole'`
`26`	`27`	`}`
`27`	`28`	`}`
`28`	`29`
Original file line number	Diff line number	Diff line change
`@@ -18,6 +18,9 @@ resource virtualNetwork 'Microsoft.Network/virtualNetworks@2024-03-01' = {`
`18`	`18`	`addressSpace: {`
`19`	`19`	`addressPrefixes: addressPrefix`
`20`	`20`	`}`
	`21`	`+ encryption: {`
	`22`	`+ enabled: true`
	`23`	`+ }`
`21`	`24`	`}`
`22`	`25`	`tags: tags`
`23`	`26`	`}`