Skip to content

Commit 57055c8

Browse files
committed
Fix format better
1 parent 1e5a57f commit 57055c8

2 files changed

Lines changed: 8 additions & 2 deletions

File tree

lmms_eval/loggers/evaluation_tracker.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,7 @@ def extract_model_name(model_args: str, key: str) -> str:
6868
return args_after_key.split(",")[0]
6969

7070
# order does matter, e.g. peft and delta are provided together with pretrained
71-
prefixes = ["peft=", "delta=", "pretrained=", "model=", "path=", "engine="]
71+
prefixes = ["peft=", "delta=", "pretrained=", "model=", "path=", "engine=", "model_version=", "model_name=", "model_id="]
7272
for prefix in prefixes:
7373
if prefix in model_args:
7474
return extract_model_name(model_args, prefix)

lmms_eval/models/chat/async_openai.py

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -184,11 +184,17 @@ async def maybe_forward_with_tool(self, request: Instance, idx: int):
184184
for call in message.tool_calls:
185185
eval_logger.debug(f"Calling {call.function.name}...")
186186
result = await self.mcp_client.run_tool(call.function.name, eval(call.function.arguments))
187-
all_response += f"<tool_call>{call.function.name} {call.function.arguments}</tool_call>"
187+
all_response += f"<tool_call>{call.function.name} {call.function.arguments}</tool_call></tool_response>"
188188
tool_messages.append({"role": "tool", "name": call.function.name, "content": []})
189189
for content in result.content:
190190
tool_message = self.mcp_client.convert_result_to_openai_format(content)
191+
for content in tool_message:
192+
if content["type"] == "image_url":
193+
all_response += "<image_url>"
194+
elif content["type"] == "text":
195+
all_response += content["text"]
191196
tool_messages[-1]["content"].extend(tool_message)
197+
all_response += "</tool_response>"
192198

193199
response = await self.client.chat.completions.create(
194200
model=self.model_version,

0 commit comments

Comments
 (0)