Docs: Complete xxx-cleanup → comment-cleanup, mark all phases done

- Rename plan/xxx-cleanup/ to plan/comment-cleanup/
- Mark Phase 4 (API Design) complete: 4/4 resolved
- Mark Phase 5 (Investigation) complete: 6/6 resolved
- Update all references across plan/ and .claude/ directories

All XXX comments have been addressed through implementation,
documentation, or verification that current design is correct.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <[email protected]>

Author: thomas-mangin

.claude/DOCUMENTATION_PLACEMENT_GUIDE.md

@@ -125,7 +125,7 @@ plan/                              # Project root
 ├── coverage.md                    # Test coverage audit
 ├── python312-buffer-protocol.md   # Future: Python 3.12 + memoryview
 ├── type-annotations/              # Type annotation detailed plans
-└── xxx-cleanup/                   # XXX comment cleanup
+└── comment-cleanup/               # XXX comment cleanup (✅ Complete)
 ```
 
 **Format:**

.claude/PLANNING_GUIDE.md

@@ -15,7 +15,7 @@ plan/                              # Project root
 ├── coverage.md                    # Test coverage audit
 ├── python312-buffer-protocol.md   # Future: Python 3.12 + memoryview
 ├── type-annotations/              # Type annotation detailed plans
-└── xxx-cleanup/                   # XXX comment cleanup
+└── comment-cleanup/               # XXX comment cleanup (✅ Complete)
 ```
 
 **Naming:** Lowercase with hyphens: `type-annotations/`, `python312-buffer-protocol.md`

.claude/README.md

@@ -168,7 +168,7 @@ Central tracking for all quality improvement work:
 - `plan/packed-attribute.md` - Packed-bytes-first refactoring waves
 - `plan/coverage.md` - Test coverage audit
 - `plan/type-annotations/` - Type annotation detailed plans
-- `plan/xxx-cleanup/` - XXX comment cleanup
+- `plan/comment-cleanup/` - XXX comment cleanup (✅ Complete)
 
 ---
 

.claude/docs/INDEX.md

@@ -65,7 +65,7 @@
 - `plan/packed-attribute.md` - Packed-bytes-first refactoring waves
 - `plan/coverage.md` - Test coverage audit
 - `plan/type-annotations/` - Type annotation detailed plans
-- `plan/xxx-cleanup/` - XXX comment cleanup (Phases 4-5 pending)
+- `plan/comment-cleanup/` - XXX comment cleanup (✅ Complete)
 
 ### Completed Projects (`.claude/docs/projects/` - 50+ files)
 

.claude/docs/README.md

@@ -19,7 +19,7 @@ Project documentation for completed work, historical development, and reference
 - `plan/packed-attribute.md` - Packed-bytes-first refactoring
 - `plan/coverage.md` - Test coverage audit
 - `plan/type-annotations/` - Type annotation detailed plans
-- `plan/xxx-cleanup/` - XXX comment cleanup
+- `plan/comment-cleanup/` - XXX comment cleanup (✅ Complete)
 
 ---
 

plan/README.md

@@ -23,7 +23,7 @@ plan/
 │   ├── README.md
 │   └── *.md
 │
-├── xxx-cleanup/                 # XXX comment resolution
+├── comment-cleanup/             # XXX comment resolution (✅ Complete)
 │   ├── README.md
 │   └── TODO.md
 │

plan/code-quality.md

@@ -2,7 +2,7 @@
 
 **Status:** 📋 Planning (low priority)
 **Priority:** Low
-**See also:** `type-safety/`, `xxx-cleanup/`
+**See also:** `type-safety/`, `comment-cleanup/`
 
 ## Goal
 

plan/xxx-cleanup/README.md plan/comment-cleanup/README.mdplan/xxx-cleanup/README.md renamed to plan/comment-cleanup/README.md

@@ -1,6 +1,6 @@
 # XXX Comment Cleanup
 
-**Status:** 🔄 Active
+**Status:** ✅ Complete
 
 ## Overview
 
@@ -30,4 +30,4 @@ See `TODO.md` for:
 
 ---
 
-**Last Updated:** 2025-11-30
+**Last Updated:** 2025-12-04

plan/xxx-cleanup/TODO.md plan/comment-cleanup/TODO.mdplan/xxx-cleanup/TODO.md renamed to plan/comment-cleanup/TODO.md

@@ -1,6 +1,6 @@
 # XXX Comment Cleanup - TODO
 
-**Status:** Partial - Phase 1-3 complete, 2 resolved + 1 reopened during audit
+**Status:** ✅ COMPLETE - All phases resolved
 **Started:** 2025-11-25
 **Updated:** 2025-12-04
 
@@ -101,43 +101,42 @@
 - **Action:** Make CODE non-instantiable, update usages
 
 ### 4.3 VPLS signature alignment
-- **File:** `src/exabgp/bgp/message/update/nlri/vpls.py:71-107`
-- **Status:** REOPENED - XXX removed but issue persists
-- **Issue:** `make_vpls()` missing `action` and `addpath` params that other NLRIs have (INET, IPVPN, EVPN, Flow)
-- **Action:** Add `action: Action = Action.ANNOUNCE` and `addpath: PathInfo = PathInfo.DISABLED` to `make_vpls()`
+- **File:** `src/exabgp/bgp/message/update/nlri/vpls.py:73-105`
+- **Status:** ✅ RESOLVED - `make_vpls()` has `action` and `addpath` params
+- **Also:** `make_empty()` factory method added with same params (lines 107-125)
 
 ### 4.4 TrafficNextHopSimpson inheritance
-- **File:** `src/exabgp/bgp/message/update/attribute/community/extended/traffic.py:277`
-- **Status:** Pending
-- **Action:** Make subclass of NextHop or IP
+- **File:** `src/exabgp/bgp/message/update/attribute/community/extended/traffic.py:282-304`
+- **Status:** ✅ RESOLVED - No change needed
+- **Analysis:** Current design is correct. TrafficNextHopSimpson is an ExtendedCommunity (not NextHop/IP) because it doesn't contain an IP address - it only signals "use the UPDATE's existing NextHop" with a copy flag. Inheriting from NextHop or IP would be semantically wrong.
 
 ---
 
-## Phase 5: Investigation Required - NOT STARTED
+## Phase 5: Investigation Required - ✅ COMPLETE
 
 ### 5.1 VPLS unique key
-- **File:** `src/exabgp/bgp/message/update/nlri/vpls.py:218-219`
-- **Status:** Pending investigation
+- **File:** `src/exabgp/bgp/message/update/nlri/vpls.py:237-240`
+- **Status:** ✅ RESOLVED - XXX removed, unique key = all fields (rd, endpoint, base, offset, size) documented
 
 ### 5.2 RTC variable length prefixing
-- **File:** `src/exabgp/bgp/message/update/nlri/rtc.py:37`
-- **Status:** Pending investigation
+- **File:** `src/exabgp/bgp/message/update/nlri/rtc.py:30-38`
+- **Status:** ✅ RESOLVED - XXX removed, limitation documented in docstring (RFC 4684 prefix filtering not implemented)
 
 ### 5.3 EVPN MAC index
-- **File:** `src/exabgp/bgp/message/update/nlri/evpn/mac.py:132`
-- **Status:** Pending investigation
+- **File:** `src/exabgp/bgp/message/update/nlri/evpn/mac.py:132-138`
+- **Status:** ✅ RESOLVED - XXX removed, design documented: index() uses full bytes, __eq__() uses RFC key fields
 
 ### 5.4 SRCAP redundant parsing
-- **File:** `src/exabgp/bgp/message/update/attribute/bgpls/node/srcap.py:92`
-- **Status:** Pending investigation
+- **File:** `src/exabgp/bgp/message/update/attribute/bgpls/node/srcap.py:88-91`
+- **Status:** ✅ RESOLVED - XXX removed, offset calculation (7 = 3 range + 4 header) is correct, not redundant
 
 ### 5.5 PMSI length discrepancy
 - **File:** `src/exabgp/bgp/message/update/attribute/pmsi.py:90`
 - **Status:** ✅ RESOLVED - XXX comment no longer exists
 
 ### 5.6 BGP-LS IGP tags LEN checks
 - **Files:** `igpextags.py:31`, `igptags.py:34`
-- **Status:** Pending investigation
+- **Status:** ✅ RESOLVED - XXX removed, cls.check(data) validates length, comments document expected format
 
 ---
 
@@ -152,6 +151,9 @@
 | 2025-11-25 | Phase 3 implementation | Caching init removed, comments clarified |
 | 2025-11-25 | All tests pass | Ready for commit |
 | 2025-12-04 | Validation audit | 2 resolved (4.1, 5.5), 4.3 reopened (make_vpls needs action/addpath), line numbers updated |
+| 2025-12-04 | Recheck 4.3 | 4.3 resolved - make_vpls() has action/addpath params |
+| 2025-12-04 | Investigate 4.4 | 4.4 resolved - current design correct, no inheritance change needed |
+| 2025-12-04 | Investigate Phase 5 | All 6 items resolved - XXX comments replaced with documentation in commit c948819c |
 
 ---
 

plan/todo.md

@@ -130,12 +130,12 @@ Migrate to Python 3.12+ and use `memoryview` for zero-copy parsing.
 
 ---
 
-### XXX Cleanup (Phases 4-5)
+### XXX Cleanup ✅
 
-**See:** `plan/xxx-cleanup/`
+**See:** `plan/comment-cleanup/`
 
-- [ ] Phase 4: API Design Issues
-- [ ] Phase 5: Investigation Required
+- [x] Phase 4: API Design Issues ✅
+- [x] Phase 5: Investigation Required ✅
 
 ---
 
@@ -155,7 +155,7 @@ All plans in `plan/` directory:
 | `architecture.md` | 📋 Planning | Circular dependency fixes |
 | `code-quality.md` | 📋 Planning | Misc improvements |
 | `family-tuple.md` | 📋 Planning | FamilyTuple type alias |
-| `xxx-cleanup/` | 🔄 Active | XXX comment resolution |
+| `comment-cleanup/` | ✅ Complete | XXX comment resolution |
 
 ---