Skip to content

Commit e039aab

Browse files
thomas-manginclaude
andcommitted
Cleanup: Remove legacy reactor mode from test suite
Legacy/sync reactor mode has been removed from the codebase. Remove test_functional_encoding_legacy which tested with exabgp_reactor_legacy=true environment variable. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
1 parent 4694adf commit e039aab

File tree

1 file changed

+5
-35
lines changed

1 file changed

+5
-35
lines changed

qa/bin/test_everything

Lines changed: 5 additions & 35 deletions
Original file line numberDiff line numberDiff line change
@@ -201,16 +201,16 @@ def test_type_ignore_regression(test_num: int, total: int) -> bool:
201201

202202

203203
def test_functional_encoding(test_num: int, total: int) -> bool:
204-
"""Functional encoding tests (async mode - default)"""
204+
"""Functional encoding tests"""
205205
# Kill any leftover processes first
206206
subprocess.run('killall -9 python 2>/dev/null', shell=True)
207207
time.sleep(0.5)
208208

209209
returncode, stdout, stderr = run_command('./qa/bin/functional encoding --quiet')
210210

211211
if returncode != 0:
212-
print_header(test_num, total, 'Functional Encoding Tests (Async Mode)')
213-
print_error('Functional encoding tests (async) failed')
212+
print_header(test_num, total, 'Functional Encoding Tests')
213+
print_error('Functional encoding tests failed')
214214
print(stdout)
215215
if stderr:
216216
print(stderr)
@@ -219,37 +219,8 @@ def test_functional_encoding(test_num: int, total: int) -> bool:
219219
# Check for 100% pass rate - quiet mode outputs "passed N/N (100.0%)"
220220
pass_rate_match = re.search(r'100(?:\.\d+)?%', stdout)
221221
if not pass_rate_match:
222-
print_header(test_num, total, 'Functional Encoding Tests (Async Mode)')
223-
print_error('Functional encoding tests (async) did not achieve 100% pass rate')
224-
print(stdout)
225-
return False
226-
227-
return True
228-
229-
230-
def test_functional_encoding_legacy(test_num: int, total: int) -> bool:
231-
"""Functional encoding tests (legacy/sync mode)"""
232-
# Kill any leftover processes first
233-
subprocess.run('killall -9 python 2>/dev/null', shell=True)
234-
time.sleep(0.5)
235-
236-
returncode, stdout, stderr = run_command(
237-
'./qa/bin/functional encoding --quiet', env={'exabgp_reactor_legacy': 'true'}
238-
)
239-
240-
if returncode != 0:
241-
print_header(test_num, total, 'Functional Encoding Tests (Legacy Mode)')
242-
print_error('Functional encoding tests (legacy) failed')
243-
print(stdout)
244-
if stderr:
245-
print(stderr)
246-
return False
247-
248-
# Check for 100% pass rate - quiet mode outputs "passed N/N (100.0%)"
249-
pass_rate_match = re.search(r'100(?:\.\d+)?%', stdout)
250-
if not pass_rate_match:
251-
print_header(test_num, total, 'Functional Encoding Tests (Legacy Mode)')
252-
print_error('Functional encoding tests (legacy) did not achieve 100% pass rate')
222+
print_header(test_num, total, 'Functional Encoding Tests')
223+
print_error('Functional encoding tests did not achieve 100% pass rate')
253224
print(stdout)
254225
return False
255226

@@ -285,7 +256,6 @@ def main() -> int:
285256
test_encode_decode,
286257
test_functional_decoding,
287258
test_functional_encoding,
288-
test_functional_encoding_legacy,
289259
test_type_ignore_regression,
290260
]
291261

0 commit comments

Comments
 (0)