Fix potential null pointer dereference (#117)

marchdf · web-flow · commit b726a1128f02 · 2025-10-28T11:25:12.000-06:00
diff --git a/src/OversetSimulation.h b/src/OversetSimulation.h
@@ -106,7 +106,11 @@ class OversetSimulation
     //! set number of nalu-wind instances
     void set_nw_start_rank(const std::vector<int>& start_ranks)
     {
-        m_nw_start_rank = start_ranks;
+        if (!start_ranks.empty()) {
+            m_nw_start_rank = start_ranks;
+        } else {
+            m_nw_start_rank.clear();
+        }
         m_num_nw_solvers = m_nw_start_rank.size();
     }
 

Original file line number	Diff line number	Diff line change
`@@ -106,7 +106,11 @@ class OversetSimulation`
`106`	`106`	`//! set number of nalu-wind instances`
`107`	`107`	`void set_nw_start_rank(const std::vector<int>& start_ranks)`
`108`	`108`	`{`
`109`		`- m_nw_start_rank = start_ranks;`
	`109`	`+ if (!start_ranks.empty()) {`
	`110`	`+ m_nw_start_rank = start_ranks;`
	`111`	`+ } else {`
	`112`	`+ m_nw_start_rank.clear();`
	`113`	`+ }`
`110`	`114`	`m_num_nw_solvers = m_nw_start_rank.size();`
`111`	`115`	`}`
`112`	`116`