optimized the isSquareAttacked function

Author: Exclusivefrog28

CMakeLists.txt

@@ -26,7 +26,7 @@ add_subdirectory(src)
 target_link_libraries(ChessEngine src)
 
 if (NOT WASM)
-    add_subdirectory(tests)
+#    add_subdirectory(tests)
 endif ()
 
 if (WASM)

src/CLI.cpp

@@ -11,6 +11,7 @@ namespace Interface {
 	void CLI::start() {
 		board = ChessBoard();
 		Instruction currentInstruction;
+		currentInstruction.command = invalid;
 		while (currentInstruction.command != quit) {
 			std::string input;
 			std::getline(std::cin, input);

src/Move.h

@@ -88,8 +88,8 @@ namespace Moves {
 		{-21, -19, -12, -8, 8, 12, 19, 21},
 		{-11, -9, 9, 11, 0, 0, 0, 0},
 		{-10, -1, 1, 10, 0, 0, 0, 0},
-		{-11, -10, -9, -1, 1, 9, 10, 11},
-		{-11, -10, -9, -1, 1, 9, 10, 11}
+		{-11, -10, -9, -1, 11, 10, 9, 1},
+		{-11, -10, -9, -1, 11, 10, 9, 1}
 	};
 }
 

src/MoveGenerator.cpp

@@ -174,27 +174,27 @@ std::vector<Move> MoveGenerator::tacticalMoves(const ChessBoard&board) {
 }
 
 
-bool MoveGenerator::isSquareAttacked(const ChessBoard&board, int_fast8_t square, Color color) {
+bool MoveGenerator::isSquareAttacked(const ChessBoard&board, const int_fast8_t square, const Color color) {
 	const int_fast8_t sign = (color == WHITE) ? -1 : 1;
 
 	//PAWNS
 	for (int i = 1; i < 3; ++i) {
 		const int_fast8_t n = MAILBOX[MAILBOX64[square] + (sign * OFFSET[PAWN][i])];
 		if (n != -1) {
-			if (board.squares[n].color != color && board.squares[n].type == PAWN) return true;
+			if (board.squares[n].type == PAWN && board.squares[n].color != color) return true;
 		}
 	}
 	//KNIGHTS
 	for (int i = 0; i < OFFSETS[KNIGHT]; ++i) {
 		const int_fast8_t n = MAILBOX[MAILBOX64[square] + OFFSET[KNIGHT][i]];
 		if (n != -1) {
-			if (board.squares[n].color != color && board.squares[n].type == KNIGHT) return true;
+			if (board.squares[n].type == KNIGHT && board.squares[n].color != color) return true;
 		}
 	}
 	//REST
 	for (int i = 0; i < OFFSETS[QUEEN]; ++i) {
 		int_fast8_t n = square;
-		int_fast8_t offset = OFFSET[QUEEN][i];
+		const int_fast8_t offset = OFFSET[QUEEN][i];
 		bool sliding = false;
 		while (true) {
 			n = MAILBOX[MAILBOX64[n] + offset];
@@ -203,9 +203,9 @@ bool MoveGenerator::isSquareAttacked(const ChessBoard&board, int_fast8_t square,
 			if (target.type != EMPTY) {
 				if (target.color != color && (SLIDE[target.type] || !sliding) && target.type != PAWN &&
 				    target.type != KNIGHT) {
-					const int_fast8_t* offsetPtr = std::find(OFFSET[target.type], OFFSET[target.type] + OFFSETS[target.type],
-					                                         offset);
-					if (offsetPtr != OFFSET[target.type] + OFFSETS[target.type]) return true;
+					if (target.type == QUEEN || target.type == KING) return true;
+					if (i % 2 == 0) {if (target.type == BISHOP) return true;}
+					else {if (target.type == ROOK) return true;}
 				}
 				break;
 			}
@@ -232,10 +232,6 @@ unsigned long long MoveGenerator::perft(int depth, ChessBoard&board) {
 		board.makeMove(move);
 		if (!inCheck(board, invertColor(board.sideToMove))) {
 			const unsigned long long childNodes = perft(depth - 1, board);
-			//            if(depth == 6){
-			//                printf("Move: %s-%s %d\n", Util::positionToString(move.start).c_str(), Util::positionToString(move.end).c_str(), move.flag);
-			//                printf("Nodes: %llu\n", childNodes);
-			//            }
 			nodes += childNodes;
 		}
 		board.unMakeMove();

src/Search.cpp

@@ -148,7 +148,6 @@ int Search::alphaBeta(const int depth, int alpha, int beta, const int ply) {
 		bool shouldFullSearch = true;
 		if (i > 2 && depth > 3 && !move.tactical()) {
 			score = -alphaBeta(depth - 2, -alpha - 1, -alpha, ply + 1);
-
 			shouldFullSearch = score > alpha;
 		}