[Dependencies] Migrate to Django 5.2 (#670)

* dependecies: upgrade django framework to version 5.2

* storage: use new MinioException

* import: use logging

* remove deprecated setting USE_L10N

See https://docs.djangoproject.com/en/5.2/releases/5.0/#features-removed-in-5-0

Author: codeurimpulsif

Pipfile

@@ -7,12 +7,12 @@ name = "pypi"
 androguard = "==4.1.1"
 beautifulsoup4 = "~=4.10"
 celery = "~=5.2.3"
-django = "==3.2.25"
-django-celery-beat = "~=2.2.1"
-django-environ = "~=0.9.0"
-django-eventlog = "==1.1"
-django-minio-storage = "~=0.3.10"
-djangorestframework = "~=3.13.1"
+django = "==5.2.5"
+django-celery-beat = "~=2.8.1"
+django-environ = "~=0.12.0"
+django-eventlog = "==2.2"
+django-minio-storage = "~=0.5.8"
+djangorestframework = "~=3.16.1"
 exodus-core = "==1.3.13"
 google-play-scraper = "~=1.2.2"
 gunicorn = "~=23.0"

Pipfile.lock

@@ -14,7 +14,7 @@
 
 from django.conf import settings
 from google_play_scraper import app as google_app
-from minio.error import (ResponseError)
+from minio.error import MinioException
 
 from exodus_core.analysis.static_analysis import StaticAnalysis as CoreSA
 from exodus.core.storage import RemoteStorageHelper
@@ -53,8 +53,8 @@ def get_icon_and_phash(self, storage, icon_name, source):
 
             try:
                 storage.put_file(f.name, icon_name)
-            except ResponseError as err:
-                logging.info(err)
+            except MinioException:
+                logging.exception(f"An error occured while putting the file '{f.name}' in storage")
                 return None
 
             icon_phash = self.get_phash(f.name)
@@ -181,8 +181,8 @@ def download_fdroid_apk(storage, handle, tmp_dir, apk_name, apk_tmp):
         try:
             storage.put_file(apk_tmp, apk_name)
             return True
-        except ResponseError as err:
-            logging.error(err)
+        except MinioException:
+            logging.exception(f"An error occured while storing new apk '{apk_name}'")
             return False
     else:
         return False
@@ -224,8 +224,8 @@ def download_google_apk(storage, handle, tmp_dir, apk_name, apk_tmp):
         try:
             storage.put_file(apk_tmp, apk_name)
             return True
-        except ResponseError as err:
-            logging.error(err)
+        except MinioException:
+            logging.error(f"An error occured while storing new apk '{apk_name}'")
             return False
 
     return False

exodus/exodus/core/static_analysis.py

@@ -1,7 +1,7 @@
-from IPython.core.magics import logging
+import logging
 from django.conf import settings
 from minio import Minio
-from minio.error import (ResponseError, BucketAlreadyOwnedByYou, BucketAlreadyExists)
+from minio.error import MinioException
 
 
 class RemoteStorageHelper():
@@ -15,9 +15,8 @@ def __init__(self, prefix=''):
         # Create Minio storage if needed
         try:
             self.minio_client.make_bucket(settings.MINIO_STORAGE_MEDIA_BUCKET_NAME, location="")
-        except BucketAlreadyOwnedByYou:
-            pass
-        except BucketAlreadyExists:
+        except MinioException:
+            logging.error(f"An error occured while creating new bucket '{settings.MINIO_STORAGE_MEDIA_BUCKET_NAME}'")
             pass
 
     def get_prefix(self):
@@ -38,8 +37,8 @@ def clear_prefix(self, prefix=None):
             )
             for obj in objects:
                 self.minio_client.remove_object(settings.MINIO_STORAGE_MEDIA_BUCKET_NAME, obj.object_name)
-        except ResponseError as err:
-            logging.info(err)
+        except MinioException:
+            logging.exception(f"An error occured with MinIO while clearing prefix '{ prefix }'")
 
     def put_file(self, local_path, remote_name):
         """
@@ -76,8 +75,8 @@ def download_and_put(self, url, remote_name):
                 fp.write(f.read())
                 try:
                     self.minio_client.fput_object(settings.MINIO_STORAGE_MEDIA_BUCKET_NAME, remote_name, fp.name)
-                except ResponseError as err:
-                    logging.info(err)
+                except MinioException:
+                    logging.exception(f"An error occured while storing {fp.name} to {remote_name}")
                     return ''
                 return remote_name
         except Exception as e:

exodus/exodus/core/storage.py

@@ -133,8 +133,6 @@
 
 USE_I18N = True
 
-USE_L10N = True
-
 USE_TZ = True
 
 # File storage

exodus/exodus/settings/base.py

@@ -2,13 +2,14 @@
 from __future__ import unicode_literals
 
 import json
+import logging
 
 from django.conf import settings
 from django.db import models
 from django.db.models.signals import post_delete
 from django.dispatch import receiver
 from minio import Minio
-from minio.error import (ResponseError, NoSuchBucket)
+from minio.error import MinioException
 
 from django.utils import translation
 from trackers.models import Tracker
@@ -229,7 +230,5 @@ def remove_report_files(sender, instance, using, **kwargs):
                                             recursive=True)
         for obj in objects:
             minio_client.remove_object(settings.MINIO_STORAGE_MEDIA_BUCKET_NAME, obj.object_name)
-    except ResponseError as err:
-        print(err)
-    except NoSuchBucket as err:
-        print(err)
+    except MinioException:
+        logging.exception("An error occured while removing report files")