PHP8 deprecating warning

[theblindfrog]

Hi there,

I'm getting this warning when running on PHP8

Deprecated: Required parameter $amount follows optional parameter $refundFee in /Users/Code/project/vendor/expdev07/laravel-cashier-stripe-connect/src/Concerns/ManagesTransfer.php on line 53

As far as I can tell, this is due to PHP 8 requiring required arg first, before optional items per this article

public function reverseTransferFromStripeAccount(Transfer $transfer, $refundFee = false, ?int $amount, array $options = []): TransferReverse

could be altered to

public function reverseTransferFromStripeAccount(Transfer $transfer, ?int $amount, $refundFee = false, array $options = []): TransferReverse

but this is a breaking change, I'd imagine

[ExpDev07]

Could u fix this in ur most resent PR? Thanks :)

[theblindfrog]

Can do! But this is a breaking change to any folks using v1.1.0 of the package

[ExpDev07]

Yes, let's just keep this issue open then, and not do anything about it right now :).