fix: terminology

Author: chrispader

contributingGuides/PERFORMANCE_METRICS.md

@@ -25,9 +25,9 @@ Project is using Firebase for tracking these metrics. However, not all of them a
 | `open_report_thread`   | ✅ | Time taken to open a thread in a report.<br><br>**Platforms:** All      | Starts when user presses Report Action Item.     | Stops when the `ReportActionsList` finishes laying out.     |
 | `send_message`    | ✅ | Time taken to send a message.<br><br>**Platforms:** All      | Starts when the new message is sent.     | Stops when the message is being rendered in the chat.     |
 | `pusher_ping_pong`    | ✅ | The time it takes to receive a PONG event through Pusher.<br><br>**Platforms:** All      | Starts every minute and repeats on the minute.     | Stops when the event is received from the server.     |
-| `open_submit_expense`    | ❌ | Time taken to open "Submit expense" screen.<br><br>**Platforms:** All      | Starts when the `Create expense` is pressed.     | Stops when the `IOURequestStartPage` finishes laying out.     |
-| `open_submit_expense_contact`    | ❌ | Time taken to Submit expense screen.<br><br>**Platforms:** All      | Starts when the `Next` button on `Create expense` screen is pressed.     | Stops when the `IOURequestStepParticipants` finishes laying out.     |
-| `open_submit_expense_approve`    | ❌ | Time taken to Submit expense screen.<br><br>**Platforms:** All      | Starts when the `Contact` on `Choose recipient` screen is selected.     | Stops when the `IOURequestStepConfirmation` finishes laying out.     |
+| `open_create_expense`    | ❌ | Time taken to open "Create expense" screen.<br><br>**Platforms:** All      | Starts when the `Create expense` is pressed.     | Stops when the `IOURequestStartPage` finishes laying out.     |
+| `open_create_expense_contact`    | ❌ | Time taken to "Create expense" screen.<br><br>**Platforms:** All      | Starts when the `Next` button on `Create expense` screen is pressed.     | Stops when the `IOURequestStepParticipants` finishes laying out.     |
+| `open_create_expense_approve`    | ❌ | Time taken to "Create expense" screen.<br><br>**Platforms:** All      | Starts when the `Contact` on `Choose recipient` screen is selected.     | Stops when the `IOURequestStepConfirmation` finishes laying out.     |
 
 ## Documentation Maintenance
 

src/CONST.ts

@@ -1519,9 +1519,9 @@ const CONST = {
         SIDEBAR_LOADED: 'sidebar_loaded',
         LOAD_SEARCH_OPTIONS: 'load_search_options',
         SEND_MESSAGE: 'send_message',
-        OPEN_SUBMIT_EXPENSE: 'open_submit_expense',
-        OPEN_SUBMIT_EXPENSE_CONTACT: 'open_submit_expense_contact',
-        OPEN_SUBMIT_EXPENSE_APPROVE: 'open_submit_expense_approve',
+        OPEN_CREATE_EXPENSE: 'open_create_expense',
+        OPEN_CREATE_EXPENSE_CONTACT: 'open_create_expense_contact',
+        OPEN_CREATE_EXPENSE_APPROVE: 'open_create_expense_approve',
         APPLY_AIRSHIP_UPDATES: 'apply_airship_updates',
         APPLY_PUSHER_UPDATES: 'apply_pusher_updates',
         APPLY_HTTPS_UPDATES: 'apply_https_updates',

src/libs/E2E/tests/moneyRequestTest.e2e.ts

@@ -28,7 +28,7 @@ const test = (config: NativeConfig) => {
             .then(() => tap('floating-action-button'))
             .then(() => waitForElement('create-expense'))
             .then(() => tap('create-expense'))
-            .then(() => waitForEvent(CONST.TIMING.OPEN_SUBMIT_EXPENSE))
+            .then(() => waitForEvent(CONST.TIMING.OPEN_CREATE_EXPENSE))
             .then((entry) => {
                 E2EClient.submitTestResults({
                     branch: Config.E2E_BRANCH,
@@ -43,7 +43,7 @@ const test = (config: NativeConfig) => {
             .then(() => tap('button_2'))
             .then(() => waitForTextInputValue('2', 'moneyRequestAmountInput'))
             .then(() => tap('next-button'))
-            .then(() => waitForEvent(CONST.TIMING.OPEN_SUBMIT_EXPENSE_CONTACT))
+            .then(() => waitForEvent(CONST.TIMING.OPEN_CREATE_EXPENSE_CONTACT))
             .then((entry) => {
                 E2EClient.submitTestResults({
                     branch: Config.E2E_BRANCH,
@@ -54,7 +54,7 @@ const test = (config: NativeConfig) => {
             })
             .then(() => waitForElement('+66 65 490 0617'))
             .then(() => tap('+66 65 490 0617'))
-            .then(() => waitForEvent(CONST.TIMING.OPEN_SUBMIT_EXPENSE_APPROVE))
+            .then(() => waitForEvent(CONST.TIMING.OPEN_CREATE_EXPENSE_APPROVE))
             .then((entry) => {
                 E2EClient.submitTestResults({
                     branch: Config.E2E_BRANCH,

src/pages/iou/request/step/IOURequestStepConfirmation.tsx

@@ -186,7 +186,7 @@ function IOURequestStepConfirmation({
     useFetchRoute(transaction, transaction?.comment?.waypoints, action, shouldUseTransactionDraft(action) ? CONST.TRANSACTION.STATE.DRAFT : CONST.TRANSACTION.STATE.CURRENT);
 
     useEffect(() => {
-        Performance.markEnd(CONST.TIMING.OPEN_SUBMIT_EXPENSE_APPROVE);
+        Performance.markEnd(CONST.TIMING.OPEN_CREATE_EXPENSE_APPROVE);
     }, []);
     useEffect(() => {
         const policyExpenseChat = participants?.find((participant) => participant.isPolicyExpenseChat);

src/pages/iou/request/step/IOURequestStepParticipants.tsx

@@ -87,7 +87,7 @@ function IOURequestStepParticipants({
     const isMobileSafari = isMobileSafariBrowser();
 
     useEffect(() => {
-        Performance.markEnd(CONST.TIMING.OPEN_SUBMIT_EXPENSE_CONTACT);
+        Performance.markEnd(CONST.TIMING.OPEN_CREATE_EXPENSE_CONTACT);
     }, []);
 
     // When the component mounts, if there is a receipt, see if the image can be read from the disk. If not, redirect the user to the starting step of the flow.
@@ -214,7 +214,7 @@ function IOURequestStepParticipants({
             ? ROUTES.MONEY_REQUEST_STEP_CATEGORY.getRoute(action, iouType, transactionID, selectedReportID.current || reportID, iouConfirmationPageRoute)
             : iouConfirmationPageRoute;
 
-        Performance.markStart(CONST.TIMING.OPEN_SUBMIT_EXPENSE_APPROVE);
+        Performance.markStart(CONST.TIMING.OPEN_CREATE_EXPENSE_APPROVE);
         waitForKeyboardDismiss(() => {
             // If the backTo parameter is set, we should navigate back to the confirmation screen that is already on the stack.
             if (backTo) {