Skip to content

Commit d97c089

Browse files
committed
chore: apply code review amends
1 parent 6666314 commit d97c089

4 files changed

+24
-14
lines changed

.github/workflows/remote-build-android-hybrid.yml

+6-4
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,10 @@ name: Remote Build Android Hybrid
33
on:
44
workflow_dispatch:
55
push:
6-
branches: [main]
6+
branches-ignore: [staging, production]
7+
8+
concurrency:
9+
group: ${{ github.workflow }}-${{ github.ref }}
710

811
jobs:
912
build:
@@ -14,10 +17,9 @@ jobs:
1417
uses: actions/checkout@8ade135a41bc03ea155e62e844d188df1ea18608
1518
with:
1619
submodules: true
17-
ref: ${{ github.event.pull_request.head.sha }}
1820
token: ${{ secrets.OS_BOTIFY_TOKEN }}
1921

20-
- name: Setup NodeJS
22+
- name: Setup Node
2123
uses: ./.github/actions/composite/setupNode
2224

2325
- name: RNEF Remote Build - Android
@@ -26,5 +28,5 @@ jobs:
2628
PROJECT_ROOT_PATH: "Mobile-Expensify/"
2729
with:
2830
variant: Debug
29-
github-token: ${{ secrets.GITHUB_TOKEN }}
31+
github-token: ${{ github.token }}
3032
comment-bot: false

.github/workflows/remote-build-android-newdot.yml

+6-3
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,10 @@ name: Remote Build Android Newdot
33
on:
44
workflow_dispatch:
55
push:
6-
branches: [main]
6+
branches-ignore: [staging, production]
7+
8+
concurrency:
9+
group: ${{ github.workflow }}-${{ github.ref }}
710

811
jobs:
912
build:
@@ -13,12 +16,12 @@ jobs:
1316
# v4
1417
uses: actions/checkout@8ade135a41bc03ea155e62e844d188df1ea18608
1518

16-
- name: Setup NodeJS
19+
- name: Setup Node
1720
uses: ./.github/actions/composite/setupNode
1821

1922
- name: RNEF Remote Build - Android
2023
uses: callstackincubator/android@a49920aadab9f41951944ea52bb7983fa6b20b03
2124
with:
2225
variant: developmentDebug
23-
github-token: ${{ secrets.GITHUB_TOKEN }}
26+
github-token: ${{ github.token }}
2427
comment-bot: false

.github/workflows/remote-build-ios-hybrid.yml

+6-4
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,10 @@ name: Remote Build iOS Hybrid
33
on:
44
workflow_dispatch:
55
push:
6-
branches: [main]
6+
branches-ignore: [staging, production]
7+
8+
concurrency:
9+
group: ${{ github.workflow }}-${{ github.ref }}
710

811
jobs:
912
build:
@@ -14,10 +17,9 @@ jobs:
1417
uses: actions/checkout@8ade135a41bc03ea155e62e844d188df1ea18608
1518
with:
1619
submodules: true
17-
ref: ${{ github.event.pull_request.head.sha }}
1820
token: ${{ secrets.OS_BOTIFY_TOKEN }}
1921

20-
- name: Setup NodeJS
22+
- name: Setup Node
2123
uses: ./.github/actions/composite/setupNode
2224

2325
- name: RNEF Remote Build - iOS
@@ -28,5 +30,5 @@ jobs:
2830
destination: simulator
2931
scheme: 'Expensify Dev'
3032
configuration: Debug
31-
github-token: ${{ secrets.GITHUB_TOKEN }}
33+
github-token: ${{ github.token }}
3234
comment-bot: false

.github/workflows/remote-build-ios-newdot.yml

+6-3
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,10 @@ name: Remote Build iOS Newdot
33
on:
44
workflow_dispatch:
55
push:
6-
branches: [main]
6+
branches-ignore: [staging, production]
7+
8+
concurrency:
9+
group: ${{ github.workflow }}-${{ github.ref }}
710

811
jobs:
912
build:
@@ -13,7 +16,7 @@ jobs:
1316
# v4
1417
uses: actions/checkout@8ade135a41bc03ea155e62e844d188df1ea18608
1518

16-
- name: Setup NodeJS
19+
- name: Setup Node
1720
uses: ./.github/actions/composite/setupNode
1821

1922
- name: RNEF Remote Build - iOS
@@ -22,5 +25,5 @@ jobs:
2225
destination: simulator
2326
scheme: 'New Expensify Dev'
2427
configuration: DebugDevelopment
25-
github-token: ${{ secrets.GITHUB_TOKEN }}
28+
github-token: ${{ github.token }}
2629
comment-bot: false

0 commit comments

Comments
 (0)