[Due for payment 2025-06-05] [$250] Expense report - Category and Tag column are displayed in the expense report for p2p expense

[mitarachim]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.1.32-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: No, reproducible on hybrid only
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp
Email or phone of affected tester (no customers): applausetester+cnmnmc4@applause.expensifail.com
Issue reported by: Applause Internal Team
Device used: Mac 15.3 / Chrome
App Component: Money Requests

Action Performed:

Precondition:

• Log in with Expensifail account.

1. Go to staging.new.expensify.com
2. Go to 1:1 DM.
3. Submit a manual expense to the user.
4. Click on the expense preview.

Expected Result:

There should be no Category and Tag column because p2p expense does not have Category and Tag field.

Actual Result:

Category and Tag column are displayed in the expense report for p2p expense when p2p expense does not have Category and Tag field.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6811257_1745464297889.20250424_110831.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021915464812428758182
• Upwork Job ID: 1915464812428758182
• Last Price Increase: 2025-04-24
• Automatic offers:
• nkdengineer | Contributor | 107110915

Issue Owner

Current Issue Owner: @slafortune

[melvin-bot]

Triggered auto assignment to @slafortune (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[nkdengineer]

🚨 Edited by proposal-police: This proposal was edited at 2025-04-24 07:14:36 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Category and Tag column are displayed in the expense report for p2p expense when p2p expense does not have Category and Tag field.

What is the root cause of that problem?

All columns are always shown without checking it should be shown or not

App/src/components/MoneyRequestReportView/MoneyRequestReportTableHeader.tsx

Line 71 in e1e89c9

columns={columnConfig}

App/src/components/MoneyRequestReportView/MoneyRequestReportTableHeader.tsx

Lines 16 to 50 in e1e89c9

	const columnConfig: ColumnConfig[] = [
	{
	columnName: CONST.SEARCH.TABLE_COLUMNS.RECEIPT,
	translationKey: 'common.receipt',
	isColumnSortable: false,
	},
	{
	columnName: CONST.SEARCH.TABLE_COLUMNS.TYPE,
	translationKey: 'common.type',
	isColumnSortable: false,
	},
	{
	columnName: CONST.SEARCH.TABLE_COLUMNS.DATE,
	translationKey: 'common.date',
	},
	{
	columnName: CONST.SEARCH.TABLE_COLUMNS.MERCHANT,
	translationKey: 'common.merchant',
	},
	{
	columnName: CONST.SEARCH.TABLE_COLUMNS.CATEGORY,
	translationKey: 'common.category',
	},
	{
	columnName: CONST.SEARCH.TABLE_COLUMNS.TAG,
	translationKey: 'common.tag',
	},
	{
	columnName: CONST.REPORT.TRANSACTION_LIST.COLUMNS.COMMENTS,
	translationKey: undefined, // comments have no title displayed
	isColumnSortable: false,
	},
	{
	columnName: CONST.SEARCH.TABLE_COLUMNS.TOTAL_AMOUNT,
	translationKey: 'common.total',

What changes do you think we should make in order to solve the problem?

We can create shouldShowColumnConfig like we did here

App/src/components/MoneyRequestReportView/MoneyRequestReportTableHeader.tsx

Line 71 in e1e89c9

columns={columnConfig}

Then we can create the metadata and pass to MoneyRequestReportTableHeader. The metadata can build based on report if the report is iou report, category/tag column shouldShow will be false. otherwise all columns will be shown.

App/src/components/MoneyRequestReportView/MoneyRequestReportTransactionList.tsx

Line 169 in e1e89c9

<MoneyRequestReportTableHeader

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

UI bug

What alternative solutions did you explore? (Optional)

We can simple create an isIOUReport prop in MoneyRequestReportTableHeader

App/src/components/MoneyRequestReportView/MoneyRequestReportTableHeader.tsx

Line 71 in e1e89c9

columns={columnConfig}

and filter out the category and tag columns here if isIOUReport is true

App/src/components/MoneyRequestReportView/MoneyRequestReportTableHeader.tsx

Line 71 in e1e89c9

columns={columnConfig}

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[github-actions]

⚠️ @nkdengineer Thanks for your proposal. Please update it to follow the proposal template, as proposals are only reviewed if they follow that format (note the mandatory sections).

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021915464812428758182

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @abdulrahuman5196 (External)

[melvin-bot]

@abdulrahuman5196 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!